From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.3456.1613798172790880514 for ; Fri, 19 Feb 2021 21:16:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 20 Feb 2021 13:16:04 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Laszlo Ersek'" References: <20210212204926.1114-1-bret.barkelew@microsoft.com> <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> <000f01d705a7$9c1c59e0$d4550da0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gQmFzZVRvb2xzOiBVcGRhdGUgdGhlIE5BU00gZGVwZW5kZW5jeQ==?= Date: Sat, 20 Feb 2021 13:16:04 +0800 Message-ID: <007401d70747$7cf78e30$76e6aa90$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJAeFucT3w2Afa0rtyinI99RZKPxAFe/vLgAZS59kQCQCUwYgMMAag/Ak83VWmpOSVoMA== Content-Type: multipart/alternative; boundary="----=_NextPart_000_0075_01D7078A.8B1C06B0" Content-Language: zh-cn ------=_NextPart_000_0075_01D7078A.8B1C06B0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I suggest to send patch v2.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71849+4905953+8761045@groups.io = =E4=BB=A3=E8=A1=A8 Bret Bark= elew =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8820=E6=97=A5 1= :10 =E6=94=B6=E4=BB=B6=E4=BA=BA: Laszlo Ersek =E6=8A=84=E9=80=81: gaoliming ; devel@edk2.group= s.io =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the = NASM dependency =20 Good note. Is there an easy way to resubmit? Just edit the patch as is, or= does there need to be a v2? =20 On Fri, Feb 19, 2021 at 6:30 AM Laszlo Ersek > wrote: On 02/18/21 05:07, Bret Barkelew wrote: > I'm not opposed to moving to 2.15.03 for consistency, but we'll have to > publish a new package. This one is already pushed to Nuget. Thanks for the answers. From Liming's answer, I understand we don't try to keep CI strictly in sync with edk2's (internal) BaseTools. So the patch should be fine; however, I think the subject line could be clarified. "BaseTools: Update the NASM dependency" doesn't make it clear that the CI builds are targeted primarily. Thanks Laszlo >=20 > On Wed, Feb 17, 2021 at 7:39 PM gaoliming > wrote: >=20 >> Laszlo: >> >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71686+4905953+8761045@groups= .io =20 >>> > =E4=BB=A3=E8=A1=A8 Laszlo Ersek >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8816=E6=97= =A5 5:00 >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; bret@corthon.com =20 >>> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update = the NASM >>> dependency >>> >>> Hi Bret, >>> >>> On 02/12/21 21:49, Bret Barkelew wrote: >>>> This is primarily used by CI builds, but may also be used by platform= s. >>>> >>>> Update NASM to support newer structures and features, as agreed in >> recent >>>> community meetings: >>>> https://edk2.groups.io/g/devel/message/71289 >>>> --- >>>> BaseTools/Bin/nasm_ext_dep.yaml | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml >>> b/BaseTools/Bin/nasm_ext_dep.yaml >>>> index 60b1f71b56aa..56703d4c18e7 100644 >>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml >>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml >>>> @@ -13,6 +13,6 @@ >>>> "type": "nuget", >>>> "name": "mu_nasm", >>>> "source": "https://api.nuget.org/v3/index.json", >>>> - "version": "2.14.02", >>>> + "version": "2.15.5", >>>> "flags": ["set_path", "host_specific"] >>>> } >>>> >>> >>> (1) I'm confused by the "patchlevel" number being "5" and not "05", in >>> the "2.15.5" version. Per >>> , my understanding has >>> been that the latest release is "2.15.05". >>> >>> (2) The minimum required version, according to >>> , is "2.15.01". In the >>> RHEL build environments that matter to me, I can satisfy a NASM >>> dependency up to 2.15.03, at this time, but not beyond. And this matte= rs >>> because... >>> >> I understand CI environment tries to use the latest tool version for >> verification. >> >>> (3) ... arguably, the NASM requirement in >>> "BaseTools/Conf/tools_def.template" should be updated too, in the same >>> patch: >>> >>> # - NASM 2.10 or later for use with the GCC toolchain family >>> # - NASM 2.12.01 or later for use with all other toolchain families >>> >> This is edk2 build environment requirement. It will be updated when the >> source code change is added. >> >> Thanks >> Liming >>> Thanks >>> Laszlo >>> >>> >>> >>>=20 >>> >> >> >> >> >=20 ------=_NextPart_000_0075_01D7078A.8B1C06B0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

I suggest to send patch v2.

 

Tha= nks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71849+4905953+8761045@groups.io &l= t;bounce+27952+71849+4905953+8761045@groups.io> =E4=BB=A3=E8=A1=A8 Bret Barkelew
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8820=E6=97=A5 1:10
=E6= = =94=B6=E4=BB=B6=E4=BA=BA:= Laszlo Ersek <lersek@redhat.com>
=E6=8A=84=E9=80=81: gaoliming <gaoliming@byos= oft.com.cn>; devel@edk2.groups.io
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1]= BaseTools: Update the NASM dependency

 

Good note. Is there an easy way t= o resubmit? Just edit the patch as is, or does there need to be a v2?<= /o:p>

 

On Fri, Fe= b 19, 2021 at 6:30 AM Laszlo Ersek <lersek@redhat.com> wrote:

On 02/18/21 05:07, Bret Barkelew wrote:> I'm not opposed to moving to 2.15.03 for consistency, but we'll have= to
> publish a new package. This one is already pushed to Nuget.
=
Thanks for the answers. From Liming's answer, I understand we don't try=
to keep CI strictly in sync with edk2's (internal) BaseTools.

So= the patch should be fine; however, I think the subject line could be
cl= arified. "BaseTools: Update the NASM dependency" doesn't make it = clear
that the CI builds are targeted primarily.

Thanks
Laszlo=

>
> On Wed, Feb 17, 2021 at 7:39 PM gaoliming <gaoliming@byosoft.c= om.cn> wrote:
>
>> Laszlo:
>>
>>&g= t; -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----=
>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+71686+4905953+8761045@groups.io
>>&g= t; <bounce+27952+71686+4905953+8761045@groups.io> = =E4=BB=A3=E8=A1=A8 Laszlo Ersek
>>> <= /span>=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021= =E5=B9=B42=E6=9C=8816= =E6=97=A5 5:00
>>> =E6=94=B6=E4=BB= =B6=E4=BA=BA: devel@edk2.groups.io; bret@corthon.com
>>> =E4=B8=BB= = =E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: U= pdate the NASM
>>> dependency
>>>
>>> H= i Bret,
>>>
>>> On 02/12/21 21:49, Bret Barkelew wr= ote:
>>>> This is primarily used by CI builds, but may also = be used by platforms.
>>>>
>>>> Update NASM t= o support newer structures and features, as agreed in
>> recent>>>> community meetings:
>>>> https://edk2.grou= ps.io/g/devel/message/71289
>>>> ---
>>>>=   BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>>>>  1 f= ile changed, 1 insertion(+), 1 deletion(-)
>>>>
>>&= gt;> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
>>> b/Base= Tools/Bin/nasm_ext_dep.yaml
>>>> index 60b1f71b56aa..56703d4= c18e7 100644
>>>> --- a/BaseTools/Bin/nasm_ext_dep.yaml
&= gt;>>> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
>>>> @= @ -13,6 +13,6 @@
>>>>    "type": "n= uget",
>>>>    "name": "mu_nas= m",
>>>>    "source": "https://api.nug= et.org/v3/index.json",
>>>> -  "version&q= uot;: "2.14.02",
>>>> +  "version":= "2.15.5",
>>>>    "flags": [&= quot;set_path", "host_specific"]
>>>>  }=
>>>>
>>>
>>> (1) I'm confused by th= e "patchlevel" number being "5" and not "05",= in
>>> the "2.15.5" version. Per
>>> <= ;https://edk2.groups.io/g/devel/message/71045>, my understanding has=
>>> been that the latest release is "2.15.05".
&g= t;>>
>>> (2) The minimum required version, according to>>> <https://edk2.groups.io/g/devel/message/71070>, is= "2.15.01". In the
>>> RHEL build environments that m= atter to me, I can satisfy a NASM
>>> dependency up to 2.15.03,= at this time, but not beyond. And this matters
>>> because...<= br>>>>
>> I understand CI environment tries to use the la= test tool version for
>> verification.
>>
>>>= (3) ... arguably, the NASM requirement in
>>> "BaseTools/= Conf/tools_def.template" should be updated too, in the same
>>= ;> patch:
>>>
>>> #   - NASM 2.10 or l= ater for use with the GCC toolchain family
>>> #   - = NASM 2.12.01 or later for use with all other toolchain families
>>= >
>> This is edk2 build environment requirement. It will be upd= ated when the
>> source code change is added.
>>
>&= gt; Thanks
>> Liming
>>> Thanks
>>> Laszlo=
>>>
>>>
>>>
>>>
>&g= t;>
>>
>>
>>
>>
> <= /span>

------=_NextPart_000_0075_01D7078A.8B1C06B0--