From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.4939.1616043681706591224 for ; Wed, 17 Mar 2021 22:01:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 18 Mar 2021 13:01:17 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Liu, Zhiguang'" , "'Kun Qin'" , Cc: "'Chiu, Chasel'" , "'Desimone, Nathaniel L'" , "'Dong, Eric'" References: <20210316181038.1413-1-kuqin12@gmail.com> <20210316181038.1413-2-kuqin12@gmail.com> <2647f43c-b74c-d9b6-f446-2e75c0036130@gmail.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zXVtQQVRDSCB2MiAxLzVdIE1pblBsYXRmb3JtUGtnOiBDb3JlQ29tbW9uTGliOiBBZGRlZCBuZXcgbGlicmFyeSBmb3IgVmFyaWFibGVTbW1SdW50aW1lRHhl?= Date: Thu, 18 Mar 2021 13:01:19 +0800 Message-ID: <007601d71bb3$bbde4140$339ac3c0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQDuzoPGT8F9oClqJbDiuIQ52iPYPwJRlTv7Adx5J6MCyd4qqQEA84xrrBoB8ZA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Zhiguang: Yes. I can merge part of the patch set, because each patch is for the di= fferent platform.=20 I will wait for one more day for the patch review, and merge the patch t= omorrow for those passed code review.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Liu, Zhiguang > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B43=E6=9C=8817=E6=97=A5= 22:33 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Kun Qin ; devel@edk2.gro= ups.io; Liming Gao > > =E6=8A=84=E9=80=81: Chiu, Chasel ; Desimone, Nath= aniel L > ; Dong, Eric > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinP= latformPkg: > CoreCommonLib: Added new library for VariableSmmRuntimeDxe >=20 > Hi Liming, > Can you help merge the first two patches in this patch set? > If you need, I can provide the patch files. >=20 > Hi Kun, > Thanks. Let's see if Liming can help. >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: Kun Qin > > Sent: Wednesday, March 17, 2021 4:11 PM > > To: Liu, Zhiguang ; devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Liming Gao > > ; Dong, Eric > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPk= g: > > CoreCommonLib: Added new library for VariableSmmRuntimeDxe > > > > Hi Zhiguang, > > > > I do not mind check the reviewed patches (the first 3 changes, > > specifically) in first. I have not done this before. How you want to p= roceed in > > that case? > > > > Regards, > > Kun > > > > On 03/17/2021 00:52, Liu, Zhiguang wrote: > > > Reviewed-by: Zhiguang Liu > > > > > > Hi Kun, > > > Since the first two changes about MinPlatformPkg already got reviewe= d, > > can we first check them in? > > > > > > Thanks > > > Zhiguang > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io On Behalf Of Kun > > >> Qin > > >> Sent: Wednesday, March 17, 2021 2:11 AM > > >> To: devel@edk2.groups.io > > >> Cc: Chiu, Chasel ; Desimone, Nathaniel L > > >> ; Liming Gao > > >> ; Dong, Eric > > >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg= : > > >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe > > >> > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3250 > > >> > > >> This change added NULL MmUnblockMemoryLib instance in dsc files of > > >> CoreCommonLib to resolve newly introduced dependency. The library > > >> interface is consumed by VariableSmmRuntimeDxe to better support > > >> variable runtime cache feature. > > >> > > >> Cc: Chasel Chiu > > >> Cc: Nate DeSimone > > >> Cc: Liming Gao > > >> Cc: Eric Dong > > >> > > >> Signed-off-by: Kun Qin > > >> Reviewed-by: Liming Gao > > >> --- > > >> > > >> Notes: > > >> v2: > > >> - Added reviewed-by tag [Liming] > > >> > > >> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 > + > > >> 1 file changed, 1 insertion(+) > > >> > > >> diff --git > > >> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> index cb40e111b5dd..bcabb797e91a 100644 > > >> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> @@ -159,6 +159,7 @@ [LibraryClasses.common] > > >> > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > >> > > >> SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > >> + > > >> + > > >> > > > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo > > >> ckMemoryLi > > >> + bNull.inf > > >> > > >> > SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf > > >> > > >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePo= li > > >> VariablePolicyLib|cyLi > > >> b.inf > > >> -- > > >> 2.30.0.windows.1 > > >> > > >> > > >> > > >>=20 > > >> > > >