* [PATCHv3 0/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
@ 2022-07-01 14:11 Albecki, Mateusz
2022-07-01 14:11 ` [PATCHv3 1/1] " Albecki, Mateusz
0 siblings, 1 reply; 8+ messages in thread
From: Albecki, Mateusz @ 2022-07-01 14:11 UTC (permalink / raw)
To: devel; +Cc: Mateusz Albecki, Michael D Kinney, Liming Gao, Zhiguang Liu
This patch adds support for PEIMs in UefiDevicePathLib. Although this library and DEVICE_PATH_PROTOCOL
itself was initially intended for DXE the use case of unlocking opal-locked storage devices during S3
resume makes it useful in PEI.
As it is the change will break the users who will need to change the name of the infs. This can be avoided at the cost of
a dedicated inf file just for PEI or by keeping the name UefiDevicePathLibStandaloneMm without adding Pei phase indication.
This change is a preparation for a more robust support for PCIe enumeration in PEI. More details on DevicePath use cases in PEI can
be found in this discussion:
https://edk2.groups.io/g/rfc/topic/proposal_to_add_support_for/86658203?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,86658203,previd=1640220793375011242,nextid=1626916856753718458&previd=1640220793375011242&nextid=1626916856753718458
Tests:
- Change has been tested by building a PEI PciHostBridgeLib instance which uses AppendDevicePathNode function. That PciHostBridgeLib was
then used in PEIM that enumerates PCI devices and that PEIM was able to get the root bridge information along with the correct root
bridge device path.
Changes in v2:
- Reverted file name changes, PEIM is added to UefiDevicePathLibStandaloneMm.inf
Change in v3:
- Converted UefiDevicePathLibStandaloneMm.inf to UefiDevicePathLibBase.inf Base lib can be used in every environment but
but some functionalities in FileDevicePath will not work due to lack of access to EFI_HANDLE in SEC/PEI/SMM.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Mateusz Albecki (1):
MdePkg/UefiDevicePathLib: Add support for PEIMs
MdePkg/Library/UefiDevicePathLib/DevicePathUtilities.c | 6 ++++++
...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
MdePkg/MdePkg.dsc | 2 +-
4 files changed, 10 insertions(+), 4 deletions(-)
rename MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} (100%)
rename MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} (87%)
--
2.28.0.windows.1
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-01 14:11 [PATCHv3 0/1] MdePkg/UefiDevicePathLib: Add support for PEIMs Albecki, Mateusz
@ 2022-07-01 14:11 ` Albecki, Mateusz
2022-07-07 1:36 ` 回复: " gaoliming
0 siblings, 1 reply; 8+ messages in thread
From: Albecki, Mateusz @ 2022-07-01 14:11 UTC (permalink / raw)
To: devel; +Cc: Mateusz Albecki, Michael D Kinney, Liming Gao, Zhiguang Liu
DevicePathLib utilities are useful in PEI to locate the devices which need
an opal unlock on S3 resume. This commit reuses the implementation done
for standalone MM support and makes the StandaloneMm library Base.
Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
---
...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
MdePkg/MdePkg.dsc | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
rename MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} (100%)
rename MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} (87%)
diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
similarity index 100%
rename from MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
rename to MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
diff --git a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
similarity index 87%
rename from MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
rename to MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
index 23fedf38b7..323043033f 100644
--- a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
+++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
@@ -16,10 +16,10 @@
BASE_NAME = UefiDevicePathLib
MODULE_UNI_FILE = UefiDevicePathLib.uni
FILE_GUID = D8E58437-44D3-4154-B7A7-EB794923EF12
- MODULE_TYPE = MM_STANDALONE
+ MODULE_TYPE = BASE
PI_SPECIFICATION_VERSION = 0x00010032
VERSION_STRING = 1.0
- LIBRARY_CLASS = DevicePathLib | MM_STANDALONE MM_CORE_STANDALONE
+ LIBRARY_CLASS = DevicePathLib
#
@@ -28,7 +28,7 @@
[Sources]
DevicePathUtilities.c
- DevicePathUtilitiesStandaloneMm.c
+ DevicePathUtilitiesBase.c
DevicePathToText.c
DevicePathFromText.c
UefiDevicePathLib.c
diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
index 3d8874e647..9daee93523 100644
--- a/MdePkg/MdePkg.dsc
+++ b/MdePkg/MdePkg.dsc
@@ -111,7 +111,7 @@
MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortProtocol.inf
MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
+ MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathProtocol.inf
MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
--
2.28.0.windows.1
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
^ permalink raw reply related [flat|nested] 8+ messages in thread
* 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-01 14:11 ` [PATCHv3 1/1] " Albecki, Mateusz
@ 2022-07-07 1:36 ` gaoliming
2022-07-07 22:05 ` Michael D Kinney
0 siblings, 1 reply; 8+ messages in thread
From: gaoliming @ 2022-07-07 1:36 UTC (permalink / raw)
To: 'Mateusz Albecki', devel
Cc: 'Michael D Kinney', 'Zhiguang Liu'
Mateusz:
To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf for
PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf except for
module type and base name.
The source file rename is the compatible change. It can be made.
Thanks
Liming
> -----邮件原件-----
> 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> 发送时间: 2022年7月1日 22:12
> 收件人: devel@edk2.groups.io
> 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
>
> DevicePathLib utilities are useful in PEI to locate the devices which need
> an opal unlock on S3 resume. This commit reuses the implementation done
> for standalone MM support and makes the StandaloneMm library Base.
>
> Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> ---
> ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
> MdePkg/MdePkg.dsc |
> 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
> rename
> MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c =>
> DevicePathUtilitiesBase.c} (100%)
> rename
> MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf =>
> UefiDevicePathLibBase.inf} (87%)
>
> diff --git
> a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> similarity index 100%
> rename from
> MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> rename to MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> diff --git
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> similarity index 87%
> rename from
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> rename to MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> index 23fedf38b7..323043033f 100644
> ---
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> @@ -16,10 +16,10 @@
> BASE_NAME = UefiDevicePathLib
> MODULE_UNI_FILE = UefiDevicePathLib.uni
> FILE_GUID =
> D8E58437-44D3-4154-B7A7-EB794923EF12
> - MODULE_TYPE = MM_STANDALONE
> + MODULE_TYPE = BASE
> PI_SPECIFICATION_VERSION = 0x00010032
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = DevicePathLib |
> MM_STANDALONE MM_CORE_STANDALONE
> + LIBRARY_CLASS = DevicePathLib
>
>
> #
> @@ -28,7 +28,7 @@
>
> [Sources]
> DevicePathUtilities.c
> - DevicePathUtilitiesStandaloneMm.c
> + DevicePathUtilitiesBase.c
> DevicePathToText.c
> DevicePathFromText.c
> UefiDevicePathLib.c
> diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> index 3d8874e647..9daee93523 100644
> --- a/MdePkg/MdePkg.dsc
> +++ b/MdePkg/MdePkg.dsc
> @@ -111,7 +111,7 @@
>
> MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> tocol.inf
> MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> - MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
>
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPro
> tocol.inf
>
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> vicePathProtocol.inf
> MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> --
> 2.28.0.windows.1
>
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
> 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> adresata i moze zawierac informacje poufne. W razie przypadkowego
> otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> zabronione.
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). If you are not the intended
recipient,
> please contact the sender and delete all copies; any review or
distribution by
> others is strictly prohibited.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-07 1:36 ` 回复: " gaoliming
@ 2022-07-07 22:05 ` Michael D Kinney
2022-07-11 6:48 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 8+ messages in thread
From: Michael D Kinney @ 2022-07-07 22:05 UTC (permalink / raw)
To: Gao, Liming, Albecki, Mateusz, devel@edk2.groups.io,
Kinney, Michael D
Cc: Liu, Zhiguang
Hi Liming,
I think the current Mm specific INF is actually compatible with all module types.
Why not add a Base version that can be used by any module?
Using Peim in name implies it is only compatible with PEIMs which is not true.
For the compatibility question, I would like to see feedback from Mm maintainers
to see if they would accept a library name change to a more general purpose
Base INF.
Mike
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Wednesday, July 6, 2022 6:37 PM
> To: Albecki, Mateusz <mateusz.albecki@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
>
> Mateusz:
> To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf for
> PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf except for
> module type and base name.
>
> The source file rename is the compatible change. It can be made.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> > 发送时间: 2022年7月1日 22:12
> > 收件人: devel@edk2.groups.io
> > 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
> >
> > DevicePathLib utilities are useful in PEI to locate the devices which need
> > an opal unlock on S3 resume. This commit reuses the implementation done
> > for standalone MM support and makes the StandaloneMm library Base.
> >
> > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > ---
> > ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> > ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
> > MdePkg/MdePkg.dsc |
> > 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> > rename
> > MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c =>
> > DevicePathUtilitiesBase.c} (100%)
> > rename
> > MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf =>
> > UefiDevicePathLibBase.inf} (87%)
> >
> > diff --git
> > a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > similarity index 100%
> > rename from
> > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > rename to MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > diff --git
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > similarity index 87%
> > rename from
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > rename to MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > index 23fedf38b7..323043033f 100644
> > ---
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > @@ -16,10 +16,10 @@
> > BASE_NAME = UefiDevicePathLib
> > MODULE_UNI_FILE = UefiDevicePathLib.uni
> > FILE_GUID =
> > D8E58437-44D3-4154-B7A7-EB794923EF12
> > - MODULE_TYPE = MM_STANDALONE
> > + MODULE_TYPE = BASE
> > PI_SPECIFICATION_VERSION = 0x00010032
> > VERSION_STRING = 1.0
> > - LIBRARY_CLASS = DevicePathLib |
> > MM_STANDALONE MM_CORE_STANDALONE
> > + LIBRARY_CLASS = DevicePathLib
> >
> >
> > #
> > @@ -28,7 +28,7 @@
> >
> > [Sources]
> > DevicePathUtilities.c
> > - DevicePathUtilitiesStandaloneMm.c
> > + DevicePathUtilitiesBase.c
> > DevicePathToText.c
> > DevicePathFromText.c
> > UefiDevicePathLib.c
> > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> > index 3d8874e647..9daee93523 100644
> > --- a/MdePkg/MdePkg.dsc
> > +++ b/MdePkg/MdePkg.dsc
> > @@ -111,7 +111,7 @@
> >
> > MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > tocol.inf
> > MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > - MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> >
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPro
> > tocol.inf
> >
> > MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > vicePathProtocol.inf
> > MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > --
> > 2.28.0.windows.1
> >
> > ---------------------------------------------------------------------
> > Intel Technology Poland sp. z o.o.
> > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
> > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> > zabronione.
> > This e-mail and any attachments may contain confidential material for the
> > sole use of the intended recipient(s). If you are not the intended
> recipient,
> > please contact the sender and delete all copies; any review or
> distribution by
> > others is strictly prohibited.
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-07 22:05 ` Michael D Kinney
@ 2022-07-11 6:48 ` gaoliming
2022-07-11 21:30 ` Kun Qin
0 siblings, 1 reply; 8+ messages in thread
From: gaoliming @ 2022-07-11 6:48 UTC (permalink / raw)
To: devel, michael.d.kinney, 'Albecki, Mateusz'
Cc: 'Liu, Zhiguang', 'Kun Qin'
Mike:
Thanks for your suggestion. If there is no objection to change the file name, this patch will be better.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2022年7月8日 6:06
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; Albecki, Mateusz
> <mateusz.albecki@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
> support for PEIMs
>
> Hi Liming,
>
> I think the current Mm specific INF is actually compatible with all module
> types.
>
> Why not add a Base version that can be used by any module?
>
> Using Peim in name implies it is only compatible with PEIMs which is not true.
>
> For the compatibility question, I would like to see feedback from Mm
> maintainers
> to see if they would accept a library name change to a more general purpose
> Base INF.
>
> Mike
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Wednesday, July 6, 2022 6:37 PM
> > To: Albecki, Mateusz <mateusz.albecki@intel.com>; devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> > Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for
> PEIMs
> >
> > Mateusz:
> > To be compatible, I suggest to add one new UefiDevicePathLibPeim.inf
> for
> > PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf
> except for
> > module type and base name.
> >
> > The source file rename is the compatible change. It can be made.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> > > 发送时间: 2022年7月1日 22:12
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu@intel.com>
> > > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
> > >
> > > DevicePathLib utilities are useful in PEI to locate the devices which need
> > > an opal unlock on S3 resume. This commit reuses the implementation
> done
> > > for standalone MM support and makes the StandaloneMm library Base.
> > >
> > > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > ---
> > > ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> > > ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6 +++---
> > > MdePkg/MdePkg.dsc
> |
> > > 2 +-
> > > 3 files changed, 4 insertions(+), 4 deletions(-)
> > > rename
> > > MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.c
> =>
> > > DevicePathUtilitiesBase.c} (100%)
> > > rename
> > > MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.inf
> =>
> > > UefiDevicePathLibBase.inf} (87%)
> > >
> > > diff --git
> > >
> a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > similarity index 100%
> > > rename from
> > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > rename to MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > diff --git
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > similarity index 87%
> > > rename from
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > rename to MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > index 23fedf38b7..323043033f 100644
> > > ---
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > @@ -16,10 +16,10 @@
> > > BASE_NAME = UefiDevicePathLib
> > > MODULE_UNI_FILE = UefiDevicePathLib.uni
> > > FILE_GUID =
> > > D8E58437-44D3-4154-B7A7-EB794923EF12
> > > - MODULE_TYPE = MM_STANDALONE
> > > + MODULE_TYPE = BASE
> > > PI_SPECIFICATION_VERSION = 0x00010032
> > > VERSION_STRING = 1.0
> > > - LIBRARY_CLASS = DevicePathLib |
> > > MM_STANDALONE MM_CORE_STANDALONE
> > > + LIBRARY_CLASS = DevicePathLib
> > >
> > >
> > > #
> > > @@ -28,7 +28,7 @@
> > >
> > > [Sources]
> > > DevicePathUtilities.c
> > > - DevicePathUtilitiesStandaloneMm.c
> > > + DevicePathUtilitiesBase.c
> > > DevicePathToText.c
> > > DevicePathFromText.c
> > > UefiDevicePathLib.c
> > > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc
> > > index 3d8874e647..9daee93523 100644
> > > --- a/MdePkg/MdePkg.dsc
> > > +++ b/MdePkg/MdePkg.dsc
> > > @@ -111,7 +111,7 @@
> > >
> > >
> MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > > tocol.inf
> > > MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > -
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > >
> > >
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPro
> > > tocol.inf
> > >
> > >
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > > vicePathProtocol.inf
> > > MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > > --
> > > 2.28.0.windows.1
> > >
> > > ---------------------------------------------------------------------
> > > Intel Technology Poland sp. z o.o.
> > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> > > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
> > > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz
> trwale
> > > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> > > zabronione.
> > > This e-mail and any attachments may contain confidential material for the
> > > sole use of the intended recipient(s). If you are not the intended
> > recipient,
> > > please contact the sender and delete all copies; any review or
> > distribution by
> > > others is strictly prohibited.
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-11 6:48 ` 回复: [edk2-devel] " gaoliming
@ 2022-07-11 21:30 ` Kun Qin
2022-07-13 7:48 ` 回复: " gaoliming
[not found] ` <17015402B703B76A.13030@groups.io>
0 siblings, 2 replies; 8+ messages in thread
From: Kun Qin @ 2022-07-11 21:30 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io, Kinney, Michael D,
'Albecki, Mateusz'
Cc: 'Liu, Zhiguang'
Liming/Mike,
I think making MM instance to be a base version makes sense, too. Thanks for the suggestion.
Regards,
Kun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Sunday, July 10, 2022 11:49 PM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; 'Albecki, Mateusz' <mateusz.albecki@intel.com>
Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; Kun Qin <Kun.Qin@microsoft.com>
Subject: [EXTERNAL] 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
Mike:
Thanks for your suggestion. If there is no objection to change the file name, this patch will be better.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D Kinney
> 发送时间: 2022年7月8日 6:06
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; Albecki, Mateusz
> <mateusz.albecki@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
> support for PEIMs
>
> Hi Liming,
>
> I think the current Mm specific INF is actually compatible with all
> module types.
>
> Why not add a Base version that can be used by any module?
>
> Using Peim in name implies it is only compatible with PEIMs which is not true.
>
> For the compatibility question, I would like to see feedback from Mm
> maintainers to see if they would accept a library name change to a
> more general purpose Base INF.
>
> Mike
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Wednesday, July 6, 2022 6:37 PM
> > To: Albecki, Mateusz <mateusz.albecki@intel.com>;
> > devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> > Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for
> PEIMs
> >
> > Mateusz:
> > To be compatible, I suggest to add one new
> > UefiDevicePathLibPeim.inf
> for
> > PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf
> except for
> > module type and base name.
> >
> > The source file rename is the compatible change. It can be made.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> > > 发送时间: 2022年7月1日 22:12
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> > > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
> > >
> > > DevicePathLib utilities are useful in PEI to locate the devices
> > > which need an opal unlock on S3 resume. This commit reuses the
> > > implementation
> done
> > > for standalone MM support and makes the StandaloneMm library Base.
> > >
> > > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > ---
> > > ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> > > ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6
> > > +++--- MdePkg/MdePkg.dsc
> |
> > > 2 +-
> > > 3 files changed, 4 insertions(+), 4 deletions(-) rename
> > > MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.
> > > c
> =>
> > > DevicePathUtilitiesBase.c} (100%)
> > > rename
> > > MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.in
> > > f
> =>
> > > UefiDevicePathLibBase.inf} (87%)
> > >
> > > diff --git
> > >
> a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > similarity index 100%
> > > rename from
> > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > rename to
> > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > diff --git
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > similarity index 87%
> > > rename from
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > rename to
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > index 23fedf38b7..323043033f 100644
> > > ---
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > @@ -16,10 +16,10 @@
> > > BASE_NAME = UefiDevicePathLib
> > > MODULE_UNI_FILE = UefiDevicePathLib.uni
> > > FILE_GUID =
> > > D8E58437-44D3-4154-B7A7-EB794923EF12
> > > - MODULE_TYPE = MM_STANDALONE
> > > + MODULE_TYPE = BASE
> > > PI_SPECIFICATION_VERSION = 0x00010032
> > > VERSION_STRING = 1.0
> > > - LIBRARY_CLASS = DevicePathLib |
> > > MM_STANDALONE MM_CORE_STANDALONE
> > > + LIBRARY_CLASS = DevicePathLib
> > >
> > >
> > > #
> > > @@ -28,7 +28,7 @@
> > >
> > > [Sources]
> > > DevicePathUtilities.c
> > > - DevicePathUtilitiesStandaloneMm.c
> > > + DevicePathUtilitiesBase.c
> > > DevicePathToText.c
> > > DevicePathFromText.c
> > > UefiDevicePathLib.c
> > > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
> > > 3d8874e647..9daee93523 100644
> > > --- a/MdePkg/MdePkg.dsc
> > > +++ b/MdePkg/MdePkg.dsc
> > > @@ -111,7 +111,7 @@
> > >
> > >
> MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > > tocol.inf
> > > MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > -
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > >
> > >
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPr
> o
> > > tocol.inf
> > >
> > >
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > > vicePathProtocol.inf
> > > MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > > --
> > > 2.28.0.windows.1
> > >
> > > ------------------------------------------------------------------
> > > --- Intel Technology Poland sp. z o.o.
> > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc |
> > > VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 |
> > > NIP
> > > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz
> trwale
> > > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie
> > > jest zabronione.
> > > This e-mail and any attachments may contain confidential material
> > > for the sole use of the intended recipient(s). If you are not the
> > > intended
> > recipient,
> > > please contact the sender and delete all copies; any review or
> > distribution by
> > > others is strictly prohibited.
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
2022-07-11 21:30 ` Kun Qin
@ 2022-07-13 7:48 ` gaoliming
[not found] ` <17015402B703B76A.13030@groups.io>
1 sibling, 0 replies; 8+ messages in thread
From: gaoliming @ 2022-07-13 7:48 UTC (permalink / raw)
To: devel, Kun.Qin, 'Kinney, Michael D',
'Albecki, Mateusz'
Cc: 'Liu, Zhiguang'
That's great. I give my reviewed-by for this patch. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin via
> groups.io
> 发送时间: 2022年7月12日 5:30
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> Kinney, Michael D <michael.d.kinney@intel.com>; 'Albecki, Mateusz'
> <mateusz.albecki@intel.com>
> 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>
> 主题: Re: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
> support for PEIMs
>
> Liming/Mike,
>
> I think making MM instance to be a base version makes sense, too. Thanks for
> the suggestion.
>
> Regards,
> Kun
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Sunday, July 10, 2022 11:49 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> 'Albecki, Mateusz' <mateusz.albecki@intel.com>
> Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; Kun Qin
> <Kun.Qin@microsoft.com>
> Subject: [EXTERNAL] 回复: [edk2-devel] [PATCHv3 1/1]
> MdePkg/UefiDevicePathLib: Add support for PEIMs
>
> Mike:
> Thanks for your suggestion. If there is no objection to change the file name,
> this patch will be better.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> > 发送时间: 2022年7月8日 6:06
> > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; Albecki, Mateusz
> > <mateusz.albecki@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>
> > 主题: Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
> > support for PEIMs
> >
> > Hi Liming,
> >
> > I think the current Mm specific INF is actually compatible with all
> > module types.
> >
> > Why not add a Base version that can be used by any module?
> >
> > Using Peim in name implies it is only compatible with PEIMs which is not
> true.
> >
> > For the compatibility question, I would like to see feedback from Mm
> > maintainers to see if they would accept a library name change to a
> > more general purpose Base INF.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Wednesday, July 6, 2022 6:37 PM
> > > To: Albecki, Mateusz <mateusz.albecki@intel.com>;
> > > devel@edk2.groups.io
> > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > <zhiguang.liu@intel.com>
> > > Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support
> for
> > PEIMs
> > >
> > > Mateusz:
> > > To be compatible, I suggest to add one new
> > > UefiDevicePathLibPeim.inf
> > for
> > > PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf
> > except for
> > > module type and base name.
> > >
> > > The source file rename is the compatible change. It can be made.
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> > > > 发送时间: 2022年7月1日 22:12
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D Kinney
> > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> > > > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for
> PEIMs
> > > >
> > > > DevicePathLib utilities are useful in PEI to locate the devices
> > > > which need an opal unlock on S3 resume. This commit reuses the
> > > > implementation
> > done
> > > > for standalone MM support and makes the StandaloneMm library Base.
> > > >
> > > > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > > >
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > >
> > > > ---
> > > > ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> > > > ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6
> > > > +++--- MdePkg/MdePkg.dsc
> > |
> > > > 2 +-
> > > > 3 files changed, 4 insertions(+), 4 deletions(-) rename
> > > > MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.
> > > > c
> > =>
> > > > DevicePathUtilitiesBase.c} (100%)
> > > > rename
> > > >
> MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.in
> > > > f
> > =>
> > > > UefiDevicePathLibBase.inf} (87%)
> > > >
> > > > diff --git
> > > >
> > a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > > similarity index 100%
> > > > rename from
> > > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > > rename to
> > > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > > diff --git
> > > >
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > similarity index 87%
> > > > rename from
> > > >
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > rename to
> > > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > index 23fedf38b7..323043033f 100644
> > > > ---
> > > >
> > a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > @@ -16,10 +16,10 @@
> > > > BASE_NAME = UefiDevicePathLib
> > > > MODULE_UNI_FILE = UefiDevicePathLib.uni
> > > > FILE_GUID =
> > > > D8E58437-44D3-4154-B7A7-EB794923EF12
> > > > - MODULE_TYPE = MM_STANDALONE
> > > > + MODULE_TYPE = BASE
> > > > PI_SPECIFICATION_VERSION = 0x00010032
> > > > VERSION_STRING = 1.0
> > > > - LIBRARY_CLASS = DevicePathLib |
> > > > MM_STANDALONE MM_CORE_STANDALONE
> > > > + LIBRARY_CLASS = DevicePathLib
> > > >
> > > >
> > > > #
> > > > @@ -28,7 +28,7 @@
> > > >
> > > > [Sources]
> > > > DevicePathUtilities.c
> > > > - DevicePathUtilitiesStandaloneMm.c
> > > > + DevicePathUtilitiesBase.c
> > > > DevicePathToText.c
> > > > DevicePathFromText.c
> > > > UefiDevicePathLib.c
> > > > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
> > > > 3d8874e647..9daee93523 100644
> > > > --- a/MdePkg/MdePkg.dsc
> > > > +++ b/MdePkg/MdePkg.dsc
> > > > @@ -111,7 +111,7 @@
> > > >
> > > >
> >
> MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > > > tocol.inf
> > > > MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > > -
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > >
> > > >
> >
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPr
> > o
> > > > tocol.inf
> > > >
> > > >
> >
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > > > vicePathProtocol.inf
> > > > MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > > > --
> > > > 2.28.0.windows.1
> > > >
> > > > ------------------------------------------------------------------
> > > > --- Intel Technology Poland sp. z o.o.
> > > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc |
> > > > VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 |
> > > > NIP
> > > > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > > > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz
> > trwale
> > > > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie
> > > > jest zabronione.
> > > > This e-mail and any attachments may contain confidential material
> > > > for the sole use of the intended recipient(s). If you are not the
> > > > intended
> > > recipient,
> > > > please contact the sender and delete all copies; any review or
> > > distribution by
> > > > others is strictly prohibited.
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* 回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs
[not found] ` <17015402B703B76A.13030@groups.io>
@ 2022-07-25 4:27 ` gaoliming
0 siblings, 0 replies; 8+ messages in thread
From: gaoliming @ 2022-07-25 4:27 UTC (permalink / raw)
To: devel, gaoliming, Kun.Qin, 'Kinney, Michael D',
'Albecki, Mateusz'
Cc: 'Liu, Zhiguang'
This change has been merged in edk2 master.
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> groups.io
> 发送时间: 2022年7月13日 15:48
> 收件人: devel@edk2.groups.io; Kun.Qin@microsoft.com; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Albecki, Mateusz'
> <mateusz.albecki@intel.com>
> 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>
> 主题: 回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib:
> Add support for PEIMs
>
>
> That's great. I give my reviewed-by for this patch. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin via
> > groups.io
> > 发送时间: 2022年7月12日 5:30
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > Kinney, Michael D <michael.d.kinney@intel.com>; 'Albecki, Mateusz'
> > <mateusz.albecki@intel.com>
> > 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>
> > 主题: Re: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib:
> Add
> > support for PEIMs
> >
> > Liming/Mike,
> >
> > I think making MM instance to be a base version makes sense, too. Thanks
> for
> > the suggestion.
> >
> > Regards,
> > Kun
> >
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Sunday, July 10, 2022 11:49 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>;
> > 'Albecki, Mateusz' <mateusz.albecki@intel.com>
> > Cc: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; Kun Qin
> > <Kun.Qin@microsoft.com>
> > Subject: [EXTERNAL] 回复: [edk2-devel] [PATCHv3 1/1]
> > MdePkg/UefiDevicePathLib: Add support for PEIMs
> >
> > Mike:
> > Thanks for your suggestion. If there is no objection to change the file
> name,
> > this patch will be better.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
> D
> > Kinney
> > > 发送时间: 2022年7月8日 6:06
> > > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; Albecki, Mateusz
> > > <mateusz.albecki@intel.com>; devel@edk2.groups.io; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>
> > > 主题: Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
> > > support for PEIMs
> > >
> > > Hi Liming,
> > >
> > > I think the current Mm specific INF is actually compatible with all
> > > module types.
> > >
> > > Why not add a Base version that can be used by any module?
> > >
> > > Using Peim in name implies it is only compatible with PEIMs which is not
> > true.
> > >
> > > For the compatibility question, I would like to see feedback from Mm
> > > maintainers to see if they would accept a library name change to a
> > > more general purpose Base INF.
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > > Sent: Wednesday, July 6, 2022 6:37 PM
> > > > To: Albecki, Mateusz <mateusz.albecki@intel.com>;
> > > > devel@edk2.groups.io
> > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > <zhiguang.liu@intel.com>
> > > > Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support
> > for
> > > PEIMs
> > > >
> > > > Mateusz:
> > > > To be compatible, I suggest to add one new
> > > > UefiDevicePathLibPeim.inf
> > > for
> > > > PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf
> > > except for
> > > > module type and base name.
> > > >
> > > > The source file rename is the compatible change. It can be made.
> > > >
> > > > Thanks
> > > > Liming
> > > > > -----邮件原件-----
> > > > > 发件人: Mateusz Albecki <mateusz.albecki@intel.com>
> > > > > 发送时间: 2022年7月1日 22:12
> > > > > 收件人: devel@edk2.groups.io
> > > > > 抄送: Mateusz Albecki <mateusz.albecki@intel.com>; Michael D
> Kinney
> > > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > 主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for
> > PEIMs
> > > > >
> > > > > DevicePathLib utilities are useful in PEI to locate the devices
> > > > > which need an opal unlock on S3 resume. This commit reuses the
> > > > > implementation
> > > done
> > > > > for standalone MM support and makes the StandaloneMm library
> Base.
> > > > >
> > > > > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > > > >
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > >
> > > > > ---
> > > > > ...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
> > > > > ...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6
> > > > > +++--- MdePkg/MdePkg.dsc
> > > |
> > > > > 2 +-
> > > > > 3 files changed, 4 insertions(+), 4 deletions(-) rename
> > > > >
> MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.
> > > > > c
> > > =>
> > > > > DevicePathUtilitiesBase.c} (100%)
> > > > > rename
> > > > >
> > MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.in
> > > > > f
> > > =>
> > > > > UefiDevicePathLibBase.inf} (87%)
> > > > >
> > > > > diff --git
> > > > >
> > >
> a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > > > b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > > > similarity index 100%
> > > > > rename from
> > > > >
> MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
> > > > > rename to
> > > > > MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
> > > > > diff --git
> > > > >
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > > b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > > similarity index 87%
> > > > > rename from
> > > > >
> > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > > rename to
> > > > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > > index 23fedf38b7..323043033f 100644
> > > > > ---
> > > > >
> > >
> a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > > +++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > > @@ -16,10 +16,10 @@
> > > > > BASE_NAME = UefiDevicePathLib
> > > > > MODULE_UNI_FILE = UefiDevicePathLib.uni
> > > > > FILE_GUID =
> > > > > D8E58437-44D3-4154-B7A7-EB794923EF12
> > > > > - MODULE_TYPE = MM_STANDALONE
> > > > > + MODULE_TYPE = BASE
> > > > > PI_SPECIFICATION_VERSION = 0x00010032
> > > > > VERSION_STRING = 1.0
> > > > > - LIBRARY_CLASS = DevicePathLib |
> > > > > MM_STANDALONE MM_CORE_STANDALONE
> > > > > + LIBRARY_CLASS = DevicePathLib
> > > > >
> > > > >
> > > > > #
> > > > > @@ -28,7 +28,7 @@
> > > > >
> > > > > [Sources]
> > > > > DevicePathUtilities.c
> > > > > - DevicePathUtilitiesStandaloneMm.c
> > > > > + DevicePathUtilitiesBase.c
> > > > > DevicePathToText.c
> > > > > DevicePathFromText.c
> > > > > UefiDevicePathLib.c
> > > > > diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
> > > > > 3d8874e647..9daee93523 100644
> > > > > --- a/MdePkg/MdePkg.dsc
> > > > > +++ b/MdePkg/MdePkg.dsc
> > > > > @@ -111,7 +111,7 @@
> > > > >
> > > > >
> > >
> >
> MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
> > > > > tocol.inf
> > > > > MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > > > > -
> > > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
> > > > > + MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
> > > > >
> > > > >
> > >
> >
> MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPr
> > > o
> > > > > tocol.inf
> > > > >
> > > > >
> > >
> >
> MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
> > > > > vicePathProtocol.inf
> > > > > MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > > > > --
> > > > > 2.28.0.windows.1
> > > > >
> > > > > ------------------------------------------------------------------
> > > > > --- Intel Technology Poland sp. z o.o.
> > > > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc |
> > > > > VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 |
> > > > > NIP
> > > > > 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> > > > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > > > > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > > > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz
> > > trwale
> > > > > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie
> > > > > jest zabronione.
> > > > > This e-mail and any attachments may contain confidential material
> > > > > for the sole use of the intended recipient(s). If you are not the
> > > > > intended
> > > > recipient,
> > > > > please contact the sender and delete all copies; any review or
> > > > distribution by
> > > > > others is strictly prohibited.
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-25 4:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-01 14:11 [PATCHv3 0/1] MdePkg/UefiDevicePathLib: Add support for PEIMs Albecki, Mateusz
2022-07-01 14:11 ` [PATCHv3 1/1] " Albecki, Mateusz
2022-07-07 1:36 ` 回复: " gaoliming
2022-07-07 22:05 ` Michael D Kinney
2022-07-11 6:48 ` 回复: [edk2-devel] " gaoliming
2022-07-11 21:30 ` Kun Qin
2022-07-13 7:48 ` 回复: " gaoliming
[not found] ` <17015402B703B76A.13030@groups.io>
2022-07-25 4:27 ` gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox