* [PATCH] MdeModulePkg/UefiHiiLib: Fix typo
@ 2022-09-01 15:54 Konstantin Aladyshev
2022-09-21 1:00 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Aladyshev @ 2022-09-01 15:54 UTC (permalink / raw)
To: devel; +Cc: dandan.bi, eric.dong, Konstantin Aladyshev
Fix typo in the set default value action define name:
DEFAUTL -> DEFAULT
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
index 63a37ab59a..5821bd5488 100644
--- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
+++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
@@ -12,7 +12,7 @@
#define NAME_CONFIG_STRING_TYPE 0x01
#define PATH_CONFIG_STRING_TYPE 0x02
-#define ACTION_SET_DEFAUTL_VALUE 0x01
+#define ACTION_SET_DEFAULT_VALUE 0x01
#define ACTION_VALIDATE_SETTING 0x02
#define HII_LIB_DEFAULT_VARSTORE_SIZE 0x200
@@ -2350,7 +2350,7 @@ InternalHiiIfrValueAction (
//
// Only support set default and validate setting action.
//
- if ((ActionType != ACTION_SET_DEFAUTL_VALUE) && (ActionType != ACTION_VALIDATE_SETTING)) {
+ if ((ActionType != ACTION_SET_DEFAULT_VALUE) && (ActionType != ACTION_VALIDATE_SETTING)) {
return FALSE;
}
@@ -2511,7 +2511,7 @@ InternalHiiIfrValueAction (
VarGuid,
VarName,
DevicePath,
- (ActionType == ACTION_SET_DEFAUTL_VALUE) ? &DefaultId : NULL, // it can be NULL to get the current setting.
+ (ActionType == ACTION_SET_DEFAULT_VALUE) ? &DefaultId : NULL, // it can be NULL to get the current setting.
&ConfigResp
);
@@ -2534,7 +2534,7 @@ InternalHiiIfrValueAction (
// 4. Set the default configuration information or Validate current setting by parse IFR code.
// Current Setting is in ConfigResp, will be set into buffer, then check it again.
//
- if (ActionType == ACTION_SET_DEFAUTL_VALUE) {
+ if (ActionType == ACTION_SET_DEFAULT_VALUE) {
//
// Set the default configuration information.
//
@@ -2716,7 +2716,7 @@ HiiSetToDefaults (
IN UINT16 DefaultId
)
{
- return InternalHiiIfrValueAction (Request, DefaultId, ACTION_SET_DEFAUTL_VALUE);
+ return InternalHiiIfrValueAction (Request, DefaultId, ACTION_SET_DEFAULT_VALUE);
}
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo
2022-09-01 15:54 [PATCH] MdeModulePkg/UefiHiiLib: Fix typo Konstantin Aladyshev
@ 2022-09-21 1:00 ` gaoliming
0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2022-09-21 1:00 UTC (permalink / raw)
To: devel, aladyshev22; +Cc: dandan.bi, eric.dong
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Konstantin
> Aladyshev
> 发送时间: 2022年9月1日 23:54
> 收件人: devel@edk2.groups.io
> 抄送: dandan.bi@intel.com; eric.dong@intel.com; Konstantin Aladyshev
> <aladyshev22@gmail.com>
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiHiiLib: Fix typo
>
> Fix typo in the set default value action define name:
> DEFAUTL -> DEFAULT
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> index 63a37ab59a..5821bd5488 100644
> --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> @@ -12,7 +12,7 @@
> #define NAME_CONFIG_STRING_TYPE 0x01
>
> #define PATH_CONFIG_STRING_TYPE 0x02
>
>
>
> -#define ACTION_SET_DEFAUTL_VALUE 0x01
>
> +#define ACTION_SET_DEFAULT_VALUE 0x01
>
> #define ACTION_VALIDATE_SETTING 0x02
>
>
>
> #define HII_LIB_DEFAULT_VARSTORE_SIZE 0x200
>
> @@ -2350,7 +2350,7 @@ InternalHiiIfrValueAction (
> //
>
> // Only support set default and validate setting action.
>
> //
>
> - if ((ActionType != ACTION_SET_DEFAUTL_VALUE) && (ActionType !=
> ACTION_VALIDATE_SETTING)) {
>
> + if ((ActionType != ACTION_SET_DEFAULT_VALUE) && (ActionType !=
> ACTION_VALIDATE_SETTING)) {
>
> return FALSE;
>
> }
>
>
>
> @@ -2511,7 +2511,7 @@ InternalHiiIfrValueAction (
> VarGuid,
>
> VarName,
>
> DevicePath,
>
> - (ActionType ==
> ACTION_SET_DEFAUTL_VALUE) ? &DefaultId : NULL, // it can be NULL to
> get the current setting.
>
> + (ActionType ==
> ACTION_SET_DEFAULT_VALUE) ? &DefaultId : NULL, // it can be NULL to
> get the current setting.
>
> &ConfigResp
>
> );
>
>
>
> @@ -2534,7 +2534,7 @@ InternalHiiIfrValueAction (
> // 4. Set the default configuration information or Validate current
> setting by parse IFR code.
>
> // Current Setting is in ConfigResp, will be set into buffer, then
> check it again.
>
> //
>
> - if (ActionType == ACTION_SET_DEFAUTL_VALUE) {
>
> + if (ActionType == ACTION_SET_DEFAULT_VALUE) {
>
> //
>
> // Set the default configuration information.
>
> //
>
> @@ -2716,7 +2716,7 @@ HiiSetToDefaults (
> IN UINT16 DefaultId
>
> )
>
> {
>
> - return InternalHiiIfrValueAction (Request, DefaultId,
> ACTION_SET_DEFAUTL_VALUE);
>
> + return InternalHiiIfrValueAction (Request, DefaultId,
> ACTION_SET_DEFAULT_VALUE);
>
> }
>
>
>
> /**
>
> --
> 2.25.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93056): https://edk2.groups.io/g/devel/message/93056
> Mute This Topic: https://groups.io/mt/93398909/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-21 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 15:54 [PATCH] MdeModulePkg/UefiHiiLib: Fix typo Konstantin Aladyshev
2022-09-21 1:00 ` 回复: [edk2-devel] " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox