From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Chen, Christine'" <yuwei.chen@intel.com>,
<devel@edk2.groups.io>, "'Gerd Hoffmann'" <kraxel@redhat.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>,
"'Sean Brogan'" <sean.brogan@microsoft.com>,
"'Shi, Steven'" <steven.shi@intel.com>,
"'Feng, Bob C'" <bob.c.feng@intel.com>
Cc: "'Rebecca Cran'" <rebecca@bsdio.com>,
"'Pawel Polawski'" <ppolawsk@redhat.com>,
"'Oliver Steffen'" <osteffen@redhat.com>
Subject: 回复: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround
Date: Thu, 31 Mar 2022 13:33:20 +0800 [thread overview]
Message-ID: <007901d844c0$d50cdff0$7f269fd0$@byosoft.com.cn> (raw)
In-Reply-To: <MW5PR11MB59063D5150EF93B96FB576A796E19@MW5PR11MB5906.namprd11.prod.outlook.com>
Christine:
Can you try the option -Wno-unknown-warning to see whether it disables the
warning about an unrecognized command line option?
Thanks
Liming
> -----邮件原件-----
> 发件人: Chen, Christine <yuwei.chen@intel.com>
> 发送时间: 2022年3月31日 10:47
> 收件人: devel@edk2.groups.io; Chen, Christine <yuwei.chen@intel.com>;
> Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Shi, Steven
> <steven.shi@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Pawel Polawski
> <ppolawsk@redhat.com>; Oliver Steffen <osteffen@redhat.com>
> 主题: RE: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround
>
> Since the gcc12 has the incompatible change from GCC5.4, I'd also suggest
we
> could create a new TOOL CHAIN for gcc12.
> The error reports I collected show in gcc5.4 ,
"-Wno-error=stringop-overflow"
> is an unrecognized command line option which is available in gcc12.
>
> Thanks,
> Christine (Yuwei)
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
> > Chen
> > Sent: Thursday, March 31, 2022 8:51 AM
> > To: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Rebecca Cran
> > <rebecca@bsdio.com>; Pawel Polawski <ppolawsk@redhat.com>; Oliver
> > Steffen <osteffen@redhat.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> > Subject: Re: [edk2-devel] [PATCH v2 1/1] Basetools: fix gcc workaround
> >
> > Hi Hoffmann,
> >
> > I received some reports that some platforms are using gcc5.4. With this
> patch,
> > these platform builds are still broken.
> > Would you like to revert the original commits?
> >
> > Thanks,
> > Christine (Yuwei)
> >
> > > -----Original Message-----
> > > From: Gerd Hoffmann <kraxel@redhat.com>
> > > Sent: Tuesday, March 29, 2022 4:38 PM
> > > To: devel@edk2.groups.io
> > > Cc: Feng, Bob C <bob.c.feng@intel.com>; Rebecca Cran
> > > <rebecca@bsdio.com>; Pawel Polawski <ppolawsk@redhat.com>; Oliver
> > > Steffen <osteffen@redhat.com>; Chen, Christine
> > <yuwei.chen@intel.com>;
> > > Gao, Liming <gaoliming@byosoft.com.cn>; Gerd Hoffmann
> > > <kraxel@redhat.com>
> > > Subject: [PATCH v2 1/1] Basetools: fix gcc workaround
> > >
> > > Apply the workaround only in case the compiler is gcc.
> > > Fixes builds with clang.
> > >
> > > Fixes: 22130dcd98b4 ("Basetools: turn off gcc12 warning")
> > > Reported-by: Rebecca Cran <rebecca@bsdio.com>
> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > > ---
> > > BaseTools/Source/C/DevicePath/GNUmakefile | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile
> > > b/BaseTools/Source/C/DevicePath/GNUmakefile
> > > index b05d2bddfa68..6323e7355cc8 100644
> > > --- a/BaseTools/Source/C/DevicePath/GNUmakefile
> > > +++ b/BaseTools/Source/C/DevicePath/GNUmakefile
> > > @@ -13,8 +13,10 @@ OBJECTS = DevicePath.o UefiDevicePathLib.o
> > > DevicePathFromText.o DevicePathUtili
> > >
> > > include $(MAKEROOT)/Makefiles/app.makefile
> > >
> > > +ifneq ($(CXX), llvm)
> > > # gcc 12 trips over device path handling BUILD_CFLAGS += -Wno-
> > > error=stringop-overflow
> > > +endif
> > >
> > > LIBS = -lCommon
> > > ifeq ($(CYGWIN), CYGWIN)
> > > --
> > > 2.35.1
> >
> >
> >
> >
> >
next prev parent reply other threads:[~2022-03-31 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 8:37 [PATCH v2 1/1] Basetools: fix gcc workaround Gerd Hoffmann
2022-03-31 0:51 ` Yuwei Chen
[not found] ` <16E150E28AFDD2A7.22795@groups.io>
2022-03-31 2:46 ` [edk2-devel] " Yuwei Chen
2022-03-31 5:33 ` gaoliming [this message]
2022-04-02 5:56 ` Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007901d844c0$d50cdff0$7f269fd0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox