From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <abner.chang@hpe.com>, <hao.a.wu@intel.com>
Cc: "'Wang, Jian J'" <jian.j.wang@intel.com>,
"'Andrew Fish'" <afish@apple.com>,
"'Laszlo Ersek'" <lersek@redhat.com>,
"'Leif Lindholm'" <leif@nuviainc.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>,
"'Wang, Nickle \(HPS SW\)'" <nickle.wang@hpe.com>,
"'O'Hanley, Peter \(EXL\)'" <peter.ohanley@hpe.com>
Subject: 回复: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Date: Wed, 25 Nov 2020 11:19:46 +0800 [thread overview]
Message-ID: <007a01d6c2d9$d3888680$7a999380$@byosoft.com.cn> (raw)
In-Reply-To: <CS1PR8401MB11447767414AB344A4FB51D0FFFB0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>
Abner:
I agree JsonLib is the generic module. But now, we know its consumer is
only RedFish.
So, I suggest to place it into RedFishPkg. If there is more usage model,
we can consider to move it later.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67861+4905953+8761045@groups.io
> <bounce+27952+67861+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2020年11月24日 10:03
> 收件人: devel@edk2.groups.io; hao.a.wu@intel.com
> 抄送: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> 主题: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
>
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Tuesday, November 24, 2020 9:50 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> > Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> > <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> >
> > > -----Original Message-----
> > > From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> > > Sent: Tuesday, November 24, 2020 9:31 AM
> > > To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > <peter.ohanley@hpe.com>
> > > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Wu, Hao A
> > > > Sent: Tuesday, November 24, 2020 9:20 AM
> > > > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > > > devel@edk2.groups.io
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > > <peter.ohanley@hpe.com>
> > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > > >
> > > > > -----Original Message-----
> > > > > From: Abner Chang <abner.chang@hpe.com>
> > > > > Sent: Monday, November 23, 2020 9:47 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > > > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > > > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > > > > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > > > > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> > > > >
> > > > > This set of pactehs is sent for the comments on edk2 JSON library.
> > > > > edk2 JSON library is based on jansson open source
> > > > > (https://github.com/akheron/jansson) and wrapped as an edk2
library.
> > > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > > > contributed yet)
> > > >
> > > >
> > > > Hello,
> > > >
> > > > Sorry for possibly missing previous discussions on the Redfish
feature.
> > > > I am wondering is it more straight-forward to put the JsonLib
> > > > together with the Readfish codes under RedfishPkg?
> > > Hi Hao,
> > > The idea is JSON is not the representation of data payload for Redfish
> > > only and JsonLib could be not only for Redfish neither. Any
> > > applications which use JSON as data payload can leverage JsonLib.
> >
> >
> > Thanks,
> >
> > My concern is for the case of adding a common library/module,
> > MdeModulePkg usually seems to be the destination. But since
> > MdeModulePkg is already a huge and complex package, I am not sure if
this
> > is the right way to go.
> >
> > I would like to get the inputs on other reviewers for putting the
JsonLib
> > under MdeModulePkg.
> >
> > If this is the right direction, could you help to add an item in the
> > Maintainers.txt for the Json related stuff in MdeModulePkg and list you
(and
> > 1 more person will be appreciated) as the reviewer?
> That's no problem. We are pleased to be the reviewer of JSON lib.
>
> Yes, see others input for JsonLib location.
>
> Thanks
> Abner
> >
> > Thanks in advance.
> >
> > Best Regards,
> > Hao Wu
> >
> >
> > >
> > > Thanks
> > > Abner
> > > >
> > > > Best Regards,
> > > > Hao Wu
> > > >
> > > >
> > > > > and the edk2 port of libredfish library (not contributed yet)
> > > > > based on DMTF GitHub (https://github.com/DMTF/libredfish).
> > > > >
> > > > > You will encounterred the build error with the jansson library
> > > > > pointed in submoudle (v2.13.1) and the fix is already submitted to
> > > > > jansson open source (https://github.com/akheron/jansson/pull/558).
> > > > >
> > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > > >
> > > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > > Cc: Andrew Fish <afish@apple.com>
> > > > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > > > >
> > > > > Abner Chang (3):
> > > > > edk2: jansson submodule of JSON library
> > > > > MdeModulePkg/library: EDK2 port jansson library
> > > > > MdeModulePkg: Add EDK2 port jansson library
> > > > >
> > > > > .gitmodules | 3 +
> > > > > MdeModulePkg/Include/Library/JsonLib.h | 596
> +++++++++++++
> > > > > .../Library/JsonLib/JanssonCrtLibSupport.c | 705
> +++++++++++++++
> > > > > .../Library/JsonLib/JanssonCrtLibSupport.h | 198 +++++
> > > > > MdeModulePkg/Library/JsonLib/JsonLib.c | 805
> > > > ++++++++++++++++++
> > > > > MdeModulePkg/Library/JsonLib/JsonLib.inf | 81 ++
> > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.c | 417 +++++++++
> > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h | 69 ++
> > > > > MdeModulePkg/Library/JsonLib/assert.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/errno.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/jansson | 1 +
> > > > > MdeModulePkg/Library/JsonLib/jansson_config.h | 57
> > > > > ++ .../Library/JsonLib/jansson_private_config.h | 19 +
> > > > > MdeModulePkg/Library/JsonLib/limits.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/math.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/stdarg.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/stddef.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/stdio.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/stdlib.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/string.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/sys/time.h | 11 +
> > > > > MdeModulePkg/Library/JsonLib/sys/types.h | 10 +
> > > > > MdeModulePkg/Library/JsonLib/time.h | 11 +
> > > > > MdeModulePkg/MdeModulePkg.dec | 7 +-
> > > > > MdeModulePkg/MdeModulePkg.dsc | 4 +-
> > > > > ReadMe.rst | 1 +
> > > > > 26 files changed, 3092 insertions(+), 2 deletions(-) create mode
> > > > > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > > > > create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > > > > create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > > > > create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > > > > create mode 100644
> MdeModulePkg/Library/JsonLib/jansson_config.h
> > > > > create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > > > > create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> > > > >
> > > > > --
> > > > > 2.17.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
next prev parent reply other threads:[~2020-11-25 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:47 [PATCH 0/3] JsonLib: jansson edk2 port Abner Chang
2020-11-23 13:47 ` [PATCH 1/3] edk2: jansson submodule of JSON library Abner Chang
2020-11-23 23:32 ` Laszlo Ersek
2020-11-24 1:13 ` [edk2-devel] " Abner Chang
2020-11-23 13:47 ` [PATCH 2/3] MdeModulePkg/library: EDK2 port jansson library Abner Chang
2020-11-23 13:47 ` [PATCH 3/3] MdeModulePkg: Add " Abner Chang
2020-11-24 1:19 ` [PATCH 0/3] JsonLib: jansson edk2 port Wu, Hao A
2020-11-24 1:30 ` [edk2-devel] " Abner Chang
2020-11-24 1:50 ` Wu, Hao A
2020-11-24 2:02 ` Abner Chang
2020-11-25 3:19 ` gaoliming [this message]
2020-11-26 0:40 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007a01d6c2d9$d3888680$7a999380$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox