From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1916.1606274392046961127 for ; Tue, 24 Nov 2020 19:19:54 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 25 Nov 2020 11:19:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'Wang, Jian J'" , "'Andrew Fish'" , "'Laszlo Ersek'" , "'Leif Lindholm'" , "'Kinney, Michael D'" , "'Wang, Nickle \(HPS SW\)'" , "'O'Hanley, Peter \(EXL\)'" References: <20201123134722.15980-1-abner.chang@hpe.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDAvM10gSnNvbkxpYjogamFuc3NvbiBlZGsyIHBvcnQ=?= Date: Wed, 25 Nov 2020 11:19:46 +0800 Message-ID: <007a01d6c2d9$d3888680$7a999380$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFB+gUIve0Nqk/3GIbYuJI4j+7zMgKQfIn4AhYek1MCXHJJtAJjvBPxqraHT1A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Abner: I agree JsonLib is the generic module. But now, we know its consumer is only RedFish.=20 So, I suggest to place it into RedFishPkg. If there is more usage model, we can consider to move it later.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+67861+4905953+8761045@groups.io > =B4=FA=B1=ED Abner Chang > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C224=C8=D5 10:03 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; hao.a.wu@intel.com > =B3=AD=CB=CD: Wang, Jian J ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Tuesday, November 24, 2020 9:50 AM > > To: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io > > Cc: Wang, Jian J ; Andrew Fish ; > > Laszlo Ersek ; Leif Lindholm ; > > Kinney, Michael D ; Wang, Nickle (HPS SW) > > ; O'Hanley, Peter (EXL) > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > -----Original Message----- > > > From: Chang, Abner (HPS SW/FW Technologist) > > > Sent: Tuesday, November 24, 2020 9:31 AM > > > To: devel@edk2.groups.io; Wu, Hao A > > > Cc: Wang, Jian J ; Andrew Fish > > > ; Laszlo Ersek ; Leif Lindholm > > > ; Kinney, Michael D ; > > > Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > > > > > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > > Of Wu, Hao A > > > > Sent: Tuesday, November 24, 2020 9:20 AM > > > > To: Chang, Abner (HPS SW/FW Technologist) ; > > > > devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Andrew Fish > > > > ; Laszlo Ersek ; Leif Lindholm > > > > ; Kinney, Michael D ; > > > > Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > > > > > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > > > -----Original Message----- > > > > > From: Abner Chang > > > > > Sent: Monday, November 23, 2020 9:47 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Wang, Jian J ; Wu, Hao A > > > > > ; Andrew Fish ; Laszlo Erse= k > > > > > ; Leif Lindholm ; Kinney, > > > > > Michael D ; Nickle Wang > > > > > ; Peter O'Hanley > > > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > > > > This set of pactehs is sent for the comments on edk2 JSON librar= y. > > > > > edk2 JSON library is based on jansson open source > > > > > (https://github.com/akheron/jansson) and wrapped as an edk2 library. > > > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not > > > > > contributed yet) > > > > > > > > > > > > Hello, > > > > > > > > Sorry for possibly missing previous discussions on the Redfish feature. > > > > I am wondering is it more straight-forward to put the JsonLib > > > > together with the Readfish codes under RedfishPkg? > > > Hi Hao, > > > The idea is JSON is not the representation of data payload for Redfi= sh > > > only and JsonLib could be not only for Redfish neither. Any > > > applications which use JSON as data payload can leverage JsonLib. > > > > > > Thanks, > > > > My concern is for the case of adding a common library/module, > > MdeModulePkg usually seems to be the destination. But since > > MdeModulePkg is already a huge and complex package, I am not sure if this > > is the right way to go. > > > > I would like to get the inputs on other reviewers for putting the JsonLib > > under MdeModulePkg. > > > > If this is the right direction, could you help to add an item in the > > Maintainers.txt for the Json related stuff in MdeModulePkg and list yo= u (and > > 1 more person will be appreciated) as the reviewer? > That's no problem. We are pleased to be the reviewer of JSON lib. >=20 > Yes, see others input for JsonLib location. >=20 > Thanks > Abner > > > > Thanks in advance. > > > > Best Regards, > > Hao Wu > > > > > > > > > > Thanks > > > Abner > > > > > > > > Best Regards, > > > > Hao Wu > > > > > > > > > > > > > and the edk2 port of libredfish library (not contributed yet) > > > > > based on DMTF GitHub (https://github.com/DMTF/libredfish). > > > > > > > > > > You will encounterred the build error with the jansson library > > > > > pointed in submoudle (v2.13.1) and the fix is already submitted = to > > > > > jansson open source (https://github.com/akheron/jansson/pull/558= ). > > > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > > > Cc: Jian J Wang > > > > > Cc: Hao A Wu > > > > > Cc: Andrew Fish > > > > > Cc: Laszlo Ersek > > > > > Cc: Leif Lindholm > > > > > Cc: Michael D Kinney > > > > > Cc: Nickle Wang > > > > > Cc: Peter O'Hanley > > > > > > > > > > Abner Chang (3): > > > > > edk2: jansson submodule of JSON library > > > > > MdeModulePkg/library: EDK2 port jansson library > > > > > MdeModulePkg: Add EDK2 port jansson library > > > > > > > > > > .gitmodules | 3 + > > > > > MdeModulePkg/Include/Library/JsonLib.h | 596 > +++++++++++++ > > > > > .../Library/JsonLib/JanssonCrtLibSupport.c | 705 > +++++++++++++++ > > > > > .../Library/JsonLib/JanssonCrtLibSupport.h | 198 +++++ > > > > > MdeModulePkg/Library/JsonLib/JsonLib.c | 805 > > > > ++++++++++++++++++ > > > > > MdeModulePkg/Library/JsonLib/JsonLib.inf | 81 ++ > > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.c | 417 +++++++++ > > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h | 69 ++ > > > > > MdeModulePkg/Library/JsonLib/assert.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/errno.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/jansson | 1 + > > > > > MdeModulePkg/Library/JsonLib/jansson_config.h | 57 > > > > > ++ .../Library/JsonLib/jansson_private_config.h | 19 + > > > > > MdeModulePkg/Library/JsonLib/limits.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/math.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/stdarg.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/stddef.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/stdio.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/stdlib.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/string.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/sys/time.h | 11 + > > > > > MdeModulePkg/Library/JsonLib/sys/types.h | 10 + > > > > > MdeModulePkg/Library/JsonLib/time.h | 11 + > > > > > MdeModulePkg/MdeModulePkg.dec | 7 +- > > > > > MdeModulePkg/MdeModulePkg.dsc | 4 +- > > > > > ReadMe.rst | 1 + > > > > > 26 files changed, 3092 insertions(+), 2 deletions(-) create mo= de > > > > > 100644 MdeModulePkg/Include/Library/JsonLib.h > > > > > create mode 100644 > > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c > > > > > create mode 100644 > > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/assert.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/errno.h > > > > > create mode 160000 MdeModulePkg/Library/JsonLib/jansson > > > > > create mode 100644 > MdeModulePkg/Library/JsonLib/jansson_config.h > > > > > create mode 100644 > > > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/limits.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/math.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/string.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h > > > > > create mode 100644 MdeModulePkg/Library/JsonLib/time.h > > > > > > > > > > -- > > > > > 2.17.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20