From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Bret Barkelew'" <bret@corthon.com>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency
Date: Tue, 2 Mar 2021 09:05:59 +0800 [thread overview]
Message-ID: <007b01d70f00$356a3b10$a03eb130$@byosoft.com.cn> (raw)
In-Reply-To: <20210223175156.1572-1-bret.barkelew@microsoft.com>
Bret:
This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.
cn>
Besides, I think this patch is CI dependency update. It is not bug fix. It
can be merged after this stable tag.
Thanks
Liming
> -----邮件原件-----
> 发件人: Bret Barkelew <bret@corthon.com>
> 发送时间: 2021年2月24日 1:52
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency
>
> Update the external dependency (consumed by Edk2Tools) version for NASM,
> as agreed in recent community meetings:
> https://edk2.groups.io/g/devel/message/71289
> https://edk2.groups.io/g/devel/message/71070
>
> This is primarily used by CI builds, but may also be used by platforms.
>
> Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
> b/BaseTools/Bin/nasm_ext_dep.yaml
> index 60b1f71b56aa..56703d4c18e7 100644
> --- a/BaseTools/Bin/nasm_ext_dep.yaml
> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> @@ -13,6 +13,6 @@
> "type": "nuget",
> "name": "mu_nasm",
> "source": "https://api.nuget.org/v3/index.json",
> - "version": "2.14.02",
> + "version": "2.15.05",
> "flags": ["set_path", "host_specific"]
> }
> --
> 2.28.0.windows.1
next prev parent reply other threads:[~2021-03-02 1:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 17:51 [PATCH v3 1/1] BaseTools: Update the NASM CI dependency Bret Barkelew
2021-03-02 1:05 ` gaoliming [this message]
[not found] ` <1668610AF97AAB3B.600@groups.io>
2021-03-08 1:04 ` 回复: [edk2-devel] 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007b01d70f00$356a3b10$a03eb130$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox