[PATCH v3 1/1] BaseTools: Update the NASM CI dependency

[PATCH v3 1/1] BaseTools: Update the NASM CI dependency

[Bret Barkelew]

Update the external dependency (consumed by Edk2Tools) version for NASM,
as agreed in recent community meetings:
https://edk2.groups.io/g/devel/message/71289
https://edk2.groups.io/g/devel/message/71070

This is primarily used by CI builds, but may also be used by platforms.

Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Bin/nasm_ext_dep.yaml b/BaseTools/Bin/nasm_ext_dep.yaml
index 60b1f71b56aa..56703d4c18e7 100644
--- a/BaseTools/Bin/nasm_ext_dep.yaml
+++ b/BaseTools/Bin/nasm_ext_dep.yaml
@@ -13,6 +13,6 @@
   "type": "nuget",
   "name": "mu_nasm",
   "source": "https://api.nuget.org/v3/index.json",
-  "version": "2.14.02",
+  "version": "2.15.05",
   "flags": ["set_path", "host_specific"]
 }
-- 
2.28.0.windows.1

回复: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency

[gaoliming]

Bret:
  This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.
cn>

  Besides, I think this patch is CI dependency update. It is not bug fix. It
can be merged after this stable tag. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Bret Barkelew <bret@corthon.com>
> 发送时间: 2021年2月24日 1:52
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency
> 
> Update the external dependency (consumed by Edk2Tools) version for NASM,
> as agreed in recent community meetings:
> https://edk2.groups.io/g/devel/message/71289
> https://edk2.groups.io/g/devel/message/71070
> 
> This is primarily used by CI builds, but may also be used by platforms.
> 
> Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
>  BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
> b/BaseTools/Bin/nasm_ext_dep.yaml
> index 60b1f71b56aa..56703d4c18e7 100644
> --- a/BaseTools/Bin/nasm_ext_dep.yaml
> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> @@ -13,6 +13,6 @@
>    "type": "nuget",
>    "name": "mu_nasm",
>    "source": "https://api.nuget.org/v3/index.json",
> -  "version": "2.14.02",
> +  "version": "2.15.05",
>    "flags": ["set_path", "host_specific"]
>  }
> --
> 2.28.0.windows.1

回复: [edk2-devel] 回复: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency

[gaoliming]

Create PR https://github.com/tianocore/edk2/pull/1477 for this patch. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年3月2日 9:06
> 收件人: 'Bret Barkelew' <bret@corthon.com>; devel@edk2.groups.io
> 抄送: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] 回复: [PATCH v3 1/1] BaseTools: Update the NASM CI
> dependency
> 
> Bret:
>   This change is good to me. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.
> cn>
> 
>   Besides, I think this patch is CI dependency update. It is not bug fix.
It
> can be merged after this stable tag.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Bret Barkelew <bret@corthon.com>
> > 发送时间: 2021年2月24日 1:52
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> > 主题: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency
> >
> > Update the external dependency (consumed by Edk2Tools) version for
> NASM,
> > as agreed in recent community meetings:
> > https://edk2.groups.io/g/devel/message/71289
> > https://edk2.groups.io/g/devel/message/71070
> >
> > This is primarily used by CI builds, but may also be used by platforms.
> >
> > Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > ---
> >  BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
> > b/BaseTools/Bin/nasm_ext_dep.yaml
> > index 60b1f71b56aa..56703d4c18e7 100644
> > --- a/BaseTools/Bin/nasm_ext_dep.yaml
> > +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> > @@ -13,6 +13,6 @@
> >    "type": "nuget",
> >    "name": "mu_nasm",
> >    "source": "https://api.nuget.org/v3/index.json",
> > -  "version": "2.14.02",
> > +  "version": "2.15.05",
> >    "flags": ["set_path", "host_specific"]
> >  }
> > --
> > 2.28.0.windows.1
> 
> 
> 
> 
> 
> 
>