From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web12.2210.1614647164839921188
 for <devel@edk2.groups.io>;
 Mon, 01 Mar 2021 17:06:05 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Tue, 02 Mar 2021 09:05:58 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Bret Barkelew'" <bret@corthon.com>,
	<devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
References: <20210223175156.1572-1-bret.barkelew@microsoft.com>
In-Reply-To: <20210223175156.1572-1-bret.barkelew@microsoft.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjMgMS8xXSBCYXNlVG9vbHM6IFVwZGF0ZSB0aGUgTkFTTSBDSSBkZXBlbmRlbmN5?=
Date: Tue, 2 Mar 2021 09:05:59 +0800
Message-ID: <007b01d70f00$356a3b10$a03eb130$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQFRezjkMKLfLVSnvTzOac0GQpvOXKt7CZQQ
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Bret:
  This change is good to me. Reviewed-by: Liming Gao =
<gaoliming@byosoft.com.
cn>

  Besides, I think this patch is CI dependency update. It is not bug =
fix. It
can be merged after this stable tag.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Bret Barkelew <bret@corthon.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C224=C8=D5 1:52
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> =D6=F7=CC=E2: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency
>=20
> Update the external dependency (consumed by Edk2Tools) version for =
NASM,
> as agreed in recent community meetings:
> https://edk2.groups.io/g/devel/message/71289
> https://edk2.groups.io/g/devel/message/71070
>=20
> This is primarily used by CI builds, but may also be used by =
platforms.
>=20
> Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
>  BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml
> b/BaseTools/Bin/nasm_ext_dep.yaml
> index 60b1f71b56aa..56703d4c18e7 100644
> --- a/BaseTools/Bin/nasm_ext_dep.yaml
> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> @@ -13,6 +13,6 @@
>    "type": "nuget",
>    "name": "mu_nasm",
>    "source": "https://api.nuget.org/v3/index.json",
> -  "version": "2.14.02",
> +  "version": "2.15.05",
>    "flags": ["set_path", "host_specific"]
>  }
> --
> 2.28.0.windows.1