From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.2719.1607649022467983548 for ; Thu, 10 Dec 2020 17:10:25 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 11 Dec 2020 09:10:08 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Michael Kinney'" , "'Sean Brogan'" , "'Ard Biesheuvel \(ARM address\)'" , "'Leif Lindholm \(Nuvia address\)'" , "'Andrew Fish'" References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com> <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> <004801d6ce94$9afef490$d0fcddb0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IOWbnuWkjTogW2VkazItZGV2ZWxdIHBsZWFzZSBsZXQncyBkaXNhYmxlIHRoZSBFQ0MgcGx1Z2luIGluIENJLCBpbiBpdHMgY3VycmVudCBmb3Jt?= Date: Fri, 11 Dec 2020 09:10:12 +0800 Message-ID: <007d01d6cf5a$6059ea40$210dbec0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQMY4cZRsRTlP1zl8zhKzIXR47cOowL7Jsm0AawdKq0CA8mubwHa7hzqpyjALSA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Sean: Thanks for your information. I will evaluate current implementation and = give the detail proposal.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68630+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Sean > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=8810=E6=97= =A5 11:39 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com= .cn; > lersek@redhat.com; 'Michael Kinney' ; 'Sean > Brogan' ; 'Ard Biesheuvel (ARM address)' > ; 'Leif Lindholm (Nuvia address)' > ; 'Andrew Fish' > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [edk2-de= vel] please let's disable the ECC plugin in CI, > in its current form >=20 > I have been thinking about the idea of a CI plugin type that is provided > a file list and only operates on the supplied file list. >=20 > Then during CI execution if a file list was provided these plugins would > run and evaluate on that file list. In azure pipeline we already get > the diff between target branch and PR. We could then write that to file > and pass that file into the stuart_ci_build process. >=20 > Anyway if you have other ideas i'll leave it to you. Please let me know > if you are interested, want to discuss more, or go in this direction. >=20 > Thanks > Sean >=20 >=20 > On 12/9/2020 5:34 PM, gaoliming wrote: > > Sean: > > I will give the proposal to fix this issue > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2986. In fact, we can > enhance ECC to skip the folder or files. > > > > Thanks > > Liming > >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Sean Brogan > >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=889=E6=97= = =A5 2:37 > >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.= com.cn; > >> lersek@redhat.com; 'Michael Kinney' ; > 'Sean > >> Brogan' ; 'Ard Biesheuvel (ARM address)' > >> ; 'Leif Lindholm (Nuvia address)' > >> ; 'Andrew Fish' > >> =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] please let's= disable the ECC plugin in CI, in > its > >> current form > >> > >> Liming > >> > >> I agree it would be great to get to a place where a package maintaine= r > >> could turn this on but because of this bug > >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2986 I think this ne= eds > >> to be completely disabled until the above is resolved. > >> > >> Thanks > >> Sean > >> > >> > >> On 12/8/2020 7:38 AM, gaoliming wrote: > >>> Laszlo: > >>> ECC tool is not perfect. It is still helpful. I am OK to disable= ECC > plugin in > >> CI. But, I request to expose the option to enable it per package. If = the > >> package maintainer thinks ECC is valuable, he can enable ECC plugin i= n one > >> package. As MdePkg maintainer, I can help to resolve ECC issue in Mde= Pkg > >> patch. So, I would keep ECC plugin in MdePkg. > >>> > >>> Thanks > >>> Liming > >>>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >>>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68414+4905953+8761045@gro= ups.io > >>>> =E4=BB=A3=E8=A1=A8 L= aszlo > >> Ersek > >>>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=888=E6= =97=A5 10:05 > >>>> =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kinney ; Sean Brogan > >>>> ; Ard Biesheuvel (ARM address) > >>>> ; Leif Lindholm (Nuvia address) > >>>> ; Andrew Fish > >>>> =E6=8A=84=E9=80=81: edk2-devel-groups-io > >>>> =E4=B8=BB=E9=A2=98: [edk2-devel] please let's disable the ECC plugi= n in CI, in its > current > >> form > >>>> > >>>> Hi All, > >>>> > >>>> in my opinion, the ECC plugin in CI has not been productive or help= ful. > >>>> The errors it reports are not convincing, and exceptions are diffic= ult > >>>> to add, or even express. I request that we disable ECC globally for > >>>> edk2, or at least make it controllable through a github PR flag (no= t > >>>> through CI metafile changes in edk2). > >>>> > >>>> (Metafile changes could be an acceptable way of controlling ECC if = (a) > >>>> they didn't have to go through review, (b) if technically such chan= ges > >>>> would take effect in CI even if they were included in the patch ser= ies > >>>> subject to the CI run. Then a maintainer could evaluate and > >>>> *immediately* suppress such ECC issues by adding the exceptions as = a > >>>> prepended patch, and force-pushing the updated branch to the same > open > >>>> PR. But this would remain much inferior to simply disabling ECC, or > >>>> controlling it through a PR label.) > >>>> > >>>> Thanks > >>>> Laszlo > >>>> > >>>> > >>>> > >>>> > >>>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > > > > > > > > > > > > > > >=20 >=20 >=20 >=20