From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.17.1607649221635665499
 for <devel@edk2.groups.io>;
 Thu, 10 Dec 2020 17:13:42 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <afish@apple.com>; Fri, 11 Dec 2020 09:13:30 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Laszlo Ersek'" <lersek@redhat.com>,
	<devel@edk2.groups.io>,
	"'Michael Kinney'" <michael.d.kinney@intel.com>,
	"'Sean Brogan'" <sean.brogan@microsoft.com>,
	"'Ard Biesheuvel \(ARM address\)'" <ard.biesheuvel@arm.com>,
	"'Leif Lindholm \(Nuvia address\)'" <leif@nuviainc.com>,
	"'Andrew Fish'" <afish@apple.com>
References: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com> <000a01d6cd78$3a27e130$ae77a390$@byosoft.com.cn> <0542f7cd-0e0b-7324-018f-aa432019a1b5@redhat.com>
In-Reply-To: <0542f7cd-0e0b-7324-018f-aa432019a1b5@redhat.com>
Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBwbGVhc2UgbGV0J3MgZGlzYWJsZSB0aGUgRUNDIHBsdWdpbiBpbiBDSSwgaW4gaXRzIGN1cnJlbnQgZm9ybQ==?=
Date: Fri, 11 Dec 2020 09:13:34 +0800
Message-ID: <007e01d6cf5a$d8c56630$8a503290$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQMY4cZRsRTlP1zl8zhKzIXR47cOowL7Jsm0AjxonNSnQzT9MA==
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Laszlo:
  Yes. This is a clean way to skip ECC for package level. I will leave =
the choice to the package maintainer to disable or enable ECC checker. =
Meanwhile, I will continue to investigate how to improve ECC plugin.=20

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Laszlo Ersek <lersek@redhat.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: =
2020=E5=B9=B412=E6=9C=8810=E6=97=A5 16:52
> =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming <gaoliming@byosoft.com.cn>; =
devel@edk2.groups.io;
> 'Michael Kinney' <michael.d.kinney@intel.com>; 'Sean Brogan'
> <sean.brogan@microsoft.com>; 'Ard Biesheuvel (ARM address)'
> <ard.biesheuvel@arm.com>; 'Leif Lindholm (Nuvia address)'
> <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>
> =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] please let's =
disable the ECC plugin in CI, in its
> current form
>=20
> Hi Liming,
>=20
> On 12/08/20 16:38, gaoliming wrote:
> > Laszlo:
> >   ECC tool is not perfect. It is still helpful. I am OK to disable =
ECC plugin in
> CI. But, I request to expose the option to enable it per package. If =
the
> package maintainer thinks ECC is valuable, he can enable ECC plugin in =
one
> package. As MdePkg maintainer, I can help to resolve ECC issue in =
MdePkg
> patch. So, I would keep ECC plugin in MdePkg.
>=20
> the "skip trick" in Sean's patch at
> <https://github.com/tianocore/edk2/pull/1201/commits/3a6b58f06cc33e78b
> a66b297013dd3d5bfb5f962>:
>=20
>     "EccCheck": {
>         ## Exception sample looks like below:
>         ## "ExceptionList": [
>         ##     "<ErrorID>", "<KeyWord>"
>         ## ]
>         "ExceptionList": [
>         ],
>         ## Both file path and directory path are accepted.
>         "IgnoreFiles": [
>         ],
>         "skip": True <------ this
>     },
>=20
> looks nice. While it is not as dynamic as a PR label, it is
> package-level, and it needs no change when we add a new directory =
under
> the package directory (because, the exception list would need a new
> entry then).
>=20
> Thanks
> Laszlo