public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'PierreGondois'" <pierre.gondois@arm.com>, <devel@edk2.groups.io>
Subject: 回复: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first include guard
Date: Mon, 15 Mar 2021 09:39:40 +0800	[thread overview]
Message-ID: <007f01d7193c$1160fce0$3422f6a0$@byosoft.com.cn> (raw)
In-Reply-To: <6476.1615454755583866377@groups.io>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Pierre:

 I see. This change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

Thanks

Liming

发件人: PierreGondois <pierre.gondois@arm.com> 
发送时间: 2021年3月11日 17:26
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first include guard

 

Hello Liming,
Yes this check is only done for '.h' files. Cf the bit of code from the same file:

if os.path.splitext(F)[1] in ('.h'):
  self.NamingConventionCheckIfndefStatement(FileTable)

I think this is normal, the format of the initial 'ifndef' needs to be formatted as 'Name_', but not necessarilly all the other 'ifndef' in the file.
I added the arm copyright two times, I will submit a v2 if the patch goes forward.

Regards,
Pierre 


[-- Attachment #2: Type: text/html, Size: 3863 bytes --]

  reply	other threads:[~2021-03-15  1:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:17 [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first include guard PierreGondois
2021-03-11  1:26 ` 回复: [edk2-devel] " gaoliming
2021-03-11  9:25   ` [edk2-devel] " PierreGondois
2021-03-15  1:39     ` gaoliming [this message]
2021-03-15  2:27 ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007f01d7193c$1160fce0$3422f6a0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox