From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.3166.1615772386425193776 for ; Sun, 14 Mar 2021 18:39:47 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 15 Mar 2021 09:39:41 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'PierreGondois'" , References: <00d001d71615$7e9ad6c0$7bd08440$@byosoft.com.cn> <6476.1615454755583866377@groups.io> In-Reply-To: <6476.1615454755583866377@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gQmFzZVRvb2xzL0VjYzogTWFrZSBFY2Mgb25seSBjaGVjayBmaXJzdCBpbmNsdWRlIGd1YXJk?= Date: Mon, 15 Mar 2021 09:39:40 +0800 Message-ID: <007f01d7193c$1160fce0$3422f6a0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFlE6U5BDDqbRWqerZu8pcHtLKU3gFu8R8Aq1zYpjA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0080_01D7197F.1F848B00" Content-Language: zh-cn ------=_NextPart_000_0080_01D7197F.1F848B00 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Pierre: I see. This change is good to me. Reviewed-by: Liming Gao = =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: PierreGondois =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B43=E6=9C=8811=E6=97=A5 = 17:26 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; = devel@edk2.groups.io =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2-devel] = [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first include guard =20 Hello Liming, Yes this check is only done for '.h' files. Cf the bit of code from the = same file: if os.path.splitext(F)[1] in ('.h'): self.NamingConventionCheckIfndefStatement(FileTable) I think this is normal, the format of the initial 'ifndef' needs to be = formatted as 'Name_', but not necessarilly all the other 'ifndef' in the = file. I added the arm copyright two times, I will submit a v2 if the patch = goes forward. Regards, Pierre=20 ------=_NextPart_000_0080_01D7197F.1F848B00 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Pierre:

=C2=A0I see. = This change is good to me. Reviewed-by: Liming Gao = <gaoliming@byosoft.com.cn>

Thanks

Liming

=E5=8F=91=E4=BB= =B6=E4=BA=BA: PierreGondois = <pierre.gondois@arm.com>
=E5=8F=91=E9=80= =81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B43=E6=9C=8811=E6=97=A5 17:26
=E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming = <gaoliming@byosoft.com.cn>; = devel@edk2.groups.io
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] = =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 = 1/1] BaseTools/Ecc: Make Ecc only check first include = guard

Hello Liming,
Yes this check is only done for '.h' = files. Cf the bit of code from the same file:

if = os.path.splitext(F)[1] in ('.h'):
= self.NamingConventionCheckIfndefStatement(FileTable)

I think this = is normal, the format of the initial 'ifndef' needs to be formatted as = 'Name_', but not necessarilly all the other 'ifndef' in the file.
I = added the arm copyright two times, I will submit a v2 if the patch goes = forward.

Regards,
Pierre =

------=_NextPart_000_0080_01D7197F.1F848B00--