public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Rebecca Cran'" <rebecca@nuviainc.com>, <devel@edk2.groups.io>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Ray Ni'" <ray.ni@intel.com>
Subject: 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h
Date: Tue, 8 Dec 2020 13:38:04 +0800	[thread overview]
Message-ID: <008301d6cd24$4cfe4fa0$e6faeee0$@byosoft.com.cn> (raw)
In-Reply-To: <20201204051127.27588-1-rebecca@nuviainc.com>

Rebecca:
  Thanks for your updating to make edk2 pass build with this change. 

  Can you also provide the patch to edk2-platforms if the change is small?

Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年12月4日 13:11
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>
> 主题: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in
> IndustryStandard/SmBios.h
> 
> Fix typos in MdePkg/Include/IndustryStandard/SmBios.h and make
> corresponding changes to the ShellPkg smbiosview command.
> 
> Testing:
> 
> Built OvmfPkgX64, OvmfPkgIa32, OvmfPkgIa32X64 for DEBUG, RELEASE,
> NOOPT
> Built edk2-platforms RPi4, SbsaQemu for DEBUG, RELEASE, NOOPT
> Built edk2-platforms Armada80x0McBin for RELEASE
> Built edk2-platforms Intel UpXtreme, GalagoPro3, KabylakeRvp3
> 
> Ran stuart_ci_build with X64,AARCH64,RISCV64,IA32 for
> NO-TARGET,NOOPT,RELEASE,DEBUG
> 
> Ran OVMF X64 and verified smbiosview runs correctly.
> 
> Ran Gitlab CI: https://github.com/tianocore/edk2/pull/1178
> 
> Changes from v1:
> 
> Added updates to fix the smbiosview shell command.
> 
> Rebecca Cran (3):
>   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
>   MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
>     ProcessorManufacturer
>   MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion
> 
>  MdePkg/Include/IndustryStandard/SmBios.h
> | 26 ++++++++++----------
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c |
> 4 +--
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> --
> 2.26.2




  parent reply	other threads:[~2020-12-08  5:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  5:11 [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h Rebecca Cran
2020-12-04  5:11 ` [PATCH v2 1/3] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct Rebecca Cran
2020-12-04  5:11 ` [PATCH v2 2/3] MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field ProcessorManufacturer Rebecca Cran
2020-12-04  5:11 ` [PATCH v2 3/3] MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion Rebecca Cran
2020-12-08  5:38 ` gaoliming [this message]
2020-12-08  5:52   ` [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h Rebecca Cran
2020-12-08  6:03     ` 回复: " gaoliming
     [not found]     ` <164EA88AA2B05CA4.9298@groups.io>
2020-12-10  1:53       ` gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='008301d6cd24$4cfe4fa0$e6faeee0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox