* [edk2-devel] [PATCH 0/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions @ 2023-11-30 11:09 PierreGondois 2023-11-30 11:09 ` [edk2-devel] [PATCH 1/1] " PierreGondois 0 siblings, 1 reply; 7+ messages in thread From: PierreGondois @ 2023-11-30 11:09 UTC (permalink / raw) To: devel Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Sami Mujawar, Leif Lindholm The patch-set at [1] aims to generate _CPC/_PSD information by querying the SCP through the SCMI protocol. Some _CPC/_PSD information is missing in the IndustryStandard folder. Extract the patch [2] from the patch-serie to avoid potentially re-submitting the whole patch-set and in case a new versions of this patch is required. [1] https://edk2.groups.io/g/devel/message/111567 [2] https://edk2.groups.io/g/devel/message/111570 Pierre Gondois (1): MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++ MdePkg/Include/IndustryStandard/Acpi40.h | 5 +++++ MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++ 10 files changed, 99 insertions(+) -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111900): https://edk2.groups.io/g/devel/message/111900 Mute This Topic: https://groups.io/mt/102891568/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-11-30 11:09 [edk2-devel] [PATCH 0/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions PierreGondois @ 2023-11-30 11:09 ` PierreGondois 2023-12-01 10:22 ` Ni, Ray 2023-12-22 15:29 ` Sami Mujawar 0 siblings, 2 replies; 7+ messages in thread From: PierreGondois @ 2023-11-30 11:09 UTC (permalink / raw) To: devel Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Sami Mujawar, Leif Lindholm Add definitions for: - _PSD version: added in ACPI 3.0 - C-state Coordination Types: added in ACPI 3.0 - _CPC version: added in ACPI 5.0 Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> --- MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++ MdePkg/Include/IndustryStandard/Acpi40.h | 5 +++++ MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++ MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++ 10 files changed, 99 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h index 29f0d5535593..cb50b1d8f71a 100644 --- a/MdePkg/Include/IndustryStandard/Acpi30.h +++ b/MdePkg/Include/IndustryStandard/Acpi30.h @@ -17,6 +17,20 @@ #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR 0x8B +/// +/// C-state Coordination Types +/// See s8.4.2.2 _CSD (C-State Dependency) +/// +#define ACPI_AML_COORD_TYPE_SW_ALL 0xFC +#define ACPI_AML_COORD_TYPE_SW_ANY 0xFD +#define ACPI_AML_COORD_TYPE_HW_ALL 0xFE + +/// +/// _PSD Revision for ACPI 3.0 +// See s8.4.4.5 _PSD (P-State Dependency) +/// +#define EFI_ACPI_3_0_AML_PSD_REVISION 0 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h index a2da09346f1c..0e30f4f8417d 100644 --- a/MdePkg/Include/IndustryStandard/Acpi40.h +++ b/MdePkg/Include/IndustryStandard/Acpi40.h @@ -10,6 +10,11 @@ #include <IndustryStandard/Acpi30.h> +/// +/// _PSD Revision for ACPI 4.0 +/// +#define EFI_ACPI_4_0_AML_PSD_REVISION 0 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h index 76706aa640f8..a00b8259b8f7 100644 --- a/MdePkg/Include/IndustryStandard/Acpi50.h +++ b/MdePkg/Include/IndustryStandard/Acpi50.h @@ -23,6 +23,16 @@ #define ACPI_GPIO_CONNECTION_DESCRIPTOR 0x8C #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR 0x8E +/// +/// _PSD Revision for ACPI 5.0 +/// +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 5.0 +/// +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 + #pragma pack(1) /// diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h index 01ef544c3a29..19dd7b4f864c 100644 --- a/MdePkg/Include/IndustryStandard/Acpi51.h +++ b/MdePkg/Include/IndustryStandard/Acpi51.h @@ -13,6 +13,16 @@ #include <IndustryStandard/Acpi50.h> +/// +/// _PSD Revision for ACPI 5.1 +/// +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 5.1 +/// +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h index 5ac3be6ad71c..3757d3f82792 100644 --- a/MdePkg/Include/IndustryStandard/Acpi60.h +++ b/MdePkg/Include/IndustryStandard/Acpi60.h @@ -12,6 +12,16 @@ #include <IndustryStandard/Acpi51.h> +/// +/// _PSD Revision for ACPI 6.0 +/// +#define EFI_ACPI_6_0_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.0 +/// +#define EFI_ACPI_6_0_AML_CPC_REVISION 2 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h index 7af67d832bb2..c3facc6e376e 100644 --- a/MdePkg/Include/IndustryStandard/Acpi61.h +++ b/MdePkg/Include/IndustryStandard/Acpi61.h @@ -12,6 +12,16 @@ #include <IndustryStandard/Acpi60.h> +/// +/// _PSD Revision for ACPI 6.1 +/// +#define EFI_ACPI_6_1_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.1 +/// +#define EFI_ACPI_6_1_AML_CPC_REVISION 2 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h index e27775a85ade..4dd3e21c2325 100644 --- a/MdePkg/Include/IndustryStandard/Acpi62.h +++ b/MdePkg/Include/IndustryStandard/Acpi62.h @@ -29,6 +29,16 @@ #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR 0x91 #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR 0x92 +/// +/// _PSD Revision for ACPI 6.2 +/// +#define EFI_ACPI_6_2_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.2 +/// +#define EFI_ACPI_6_2_AML_CPC_REVISION 3 + #pragma pack(1) /// diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h index 10bdf5fe5a57..7582dccf649b 100644 --- a/MdePkg/Include/IndustryStandard/Acpi63.h +++ b/MdePkg/Include/IndustryStandard/Acpi63.h @@ -12,6 +12,16 @@ #include <IndustryStandard/Acpi62.h> +/// +/// _PSD Revision for ACPI 6.3 +/// +#define EFI_ACPI_6_3_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.3 +/// +#define EFI_ACPI_6_3_AML_CPC_REVISION 3 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index 575ca0430c13..faf069a0454e 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -12,6 +12,16 @@ #include <IndustryStandard/Acpi63.h> +/// +/// _PSD Revision for ACPI 6.4 +/// +#define EFI_ACPI_6_4_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.4 +/// +#define EFI_ACPI_6_4_AML_CPC_REVISION 3 + // // Ensure proper structure formats // diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65.h index d79d0b2b5f9c..b9616a3e29c2 100644 --- a/MdePkg/Include/IndustryStandard/Acpi65.h +++ b/MdePkg/Include/IndustryStandard/Acpi65.h @@ -18,6 +18,16 @@ // #pragma pack(1) +/// +/// _PSD Revision for ACPI 6.5 +/// +#define EFI_ACPI_6_5_AML_PSD_REVISION 0 + +/// +/// _CPC Revision for ACPI 6.5 +/// +#define EFI_ACPI_6_5_AML_CPC_REVISION 3 + /// /// ACPI 6.5 Generic Address Space definition /// -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111901): https://edk2.groups.io/g/devel/message/111901 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-11-30 11:09 ` [edk2-devel] [PATCH 1/1] " PierreGondois @ 2023-12-01 10:22 ` Ni, Ray 2023-12-01 12:26 ` PierreGondois 2023-12-22 15:29 ` Sami Mujawar 1 sibling, 1 reply; 7+ messages in thread From: Ni, Ray @ 2023-12-01 10:22 UTC (permalink / raw) To: Pierre Gondois, devel@edk2.groups.io Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang, Sami Mujawar, Leif Lindholm > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 > +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and EFI_ACPI_AML_CPC_REVISION in Acpi50.h? So that Acpi51.h doesn't have to redefine a different macro to the same value? > > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h > b/MdePkg/Include/IndustryStandard/Acpi51.h > index 01ef544c3a29..19dd7b4f864c 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 > +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111980): https://edk2.groups.io/g/devel/message/111980 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-12-01 10:22 ` Ni, Ray @ 2023-12-01 12:26 ` PierreGondois 2023-12-06 9:42 ` PierreGondois 0 siblings, 1 reply; 7+ messages in thread From: PierreGondois @ 2023-12-01 12:26 UTC (permalink / raw) To: Ni, Ray, devel@edk2.groups.io Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang, Sami Mujawar, Leif Lindholm Hi Ray, I followed the way revisions are defined for ACPI tables revisions, like for the MADT: EFI_ACPI_x_x_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION definition For each ACPI spec. revision, there is a matching MADT revision number. Sometimes the table has changed and the revision is upgraded, sometimes not and the revision stays the same. This also means having a macro definition for each ACPI spec. header file. I think it should be ok do to the same thing for _PSD/_CPC revisions, Regards, Pierre On 12/1/23 11:22, Ni, Ray wrote: >> --- a/MdePkg/Include/IndustryStandard/Acpi50.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > >> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 >> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 > > > Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and > EFI_ACPI_AML_CPC_REVISION in Acpi50.h? > > So that Acpi51.h doesn't have to redefine a different macro to > the same value? > >> >> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h >> b/MdePkg/Include/IndustryStandard/Acpi51.h >> index 01ef544c3a29..19dd7b4f864c 100644 >> --- a/MdePkg/Include/IndustryStandard/Acpi51.h >> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > >> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 >> +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111982): https://edk2.groups.io/g/devel/message/111982 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-12-01 12:26 ` PierreGondois @ 2023-12-06 9:42 ` PierreGondois 2023-12-12 0:36 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 7+ messages in thread From: PierreGondois @ 2023-12-06 9:42 UTC (permalink / raw) To: Ni, Ray, devel@edk2.groups.io Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang, Sami Mujawar, Leif Lindholm Hello Ray and the MdePkg maintainers, Does this patch looks fine ? When/if this patch is accepted, I will send the other patches relying on this present patch, cf. https://edk2.groups.io/g/devel/message/111900 Regards, Pierre On 12/1/23 13:26, Pierre Gondois wrote: > Hi Ray, > I followed the way revisions are defined for ACPI tables revisions, > like for the MADT: > EFI_ACPI_x_x_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION definition > > For each ACPI spec. revision, there is a matching MADT revision number. > Sometimes the table has changed and the revision is upgraded, sometimes > not and the revision stays the same. > This also means having a macro definition for each ACPI spec. header > file. I think it should be ok do to the same thing for _PSD/_CPC > revisions, > > Regards, > Pierre > > On 12/1/23 11:22, Ni, Ray wrote: >>> --- a/MdePkg/Include/IndustryStandard/Acpi50.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h >> >>> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 >>> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 >> >> >> Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and >> EFI_ACPI_AML_CPC_REVISION in Acpi50.h? >> >> So that Acpi51.h doesn't have to redefine a different macro to >> the same value? >> >>> >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h >>> b/MdePkg/Include/IndustryStandard/Acpi51.h >>> index 01ef544c3a29..19dd7b4f864c 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi51.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h >> >>> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 >>> +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112105): https://edk2.groups.io/g/devel/message/112105 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-12-06 9:42 ` PierreGondois @ 2023-12-12 0:36 ` gaoliming via groups.io 0 siblings, 0 replies; 7+ messages in thread From: gaoliming via groups.io @ 2023-12-12 0:36 UTC (permalink / raw) To: devel, pierre.gondois, 'Ni, Ray' Cc: 'Kinney, Michael D', 'Liu, Zhiguang', 'Sami Mujawar', 'Leif Lindholm' The change is good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 > PierreGondois > 发送时间: 2023年12月6日 17:43 > 收件人: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io > 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Sami > Mujawar <sami.mujawar@arm.com>; Leif Lindholm > <quic_llindhol@quicinc.com> > 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add > _PSD/_CPC/Coord types definitions > > Hello Ray and the MdePkg maintainers, > > Does this patch looks fine ? When/if this patch is accepted, > I will send the other patches relying on this present patch, > cf. https://edk2.groups.io/g/devel/message/111900 > > Regards, > Pierre > > On 12/1/23 13:26, Pierre Gondois wrote: > > Hi Ray, > > I followed the way revisions are defined for ACPI tables revisions, > > like for the MADT: > > EFI_ACPI_x_x_MULTIPLE_APIC_DESCRIPTION_TABLE_REVISION definition > > > > For each ACPI spec. revision, there is a matching MADT revision number. > > Sometimes the table has changed and the revision is upgraded, sometimes > > not and the revision stays the same. > > This also means having a macro definition for each ACPI spec. header > > file. I think it should be ok do to the same thing for _PSD/_CPC > > revisions, > > > > Regards, > > Pierre > > > > On 12/1/23 11:22, Ni, Ray wrote: > >>> --- a/MdePkg/Include/IndustryStandard/Acpi50.h > >>> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > >> > >>> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 > >>> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 > >> > >> > >> Do you think it's better to define EFI_ACPI_AML_PSD_REVISION and > >> EFI_ACPI_AML_CPC_REVISION in Acpi50.h? > >> > >> So that Acpi51.h doesn't have to redefine a different macro to > >> the same value? > >> > >>> > >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h > >>> b/MdePkg/Include/IndustryStandard/Acpi51.h > >>> index 01ef544c3a29..19dd7b4f864c 100644 > >>> --- a/MdePkg/Include/IndustryStandard/Acpi51.h > >>> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > >> > >>> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 > >>> +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112348): https://edk2.groups.io/g/devel/message/112348 Mute This Topic: https://groups.io/mt/103121407/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions 2023-11-30 11:09 ` [edk2-devel] [PATCH 1/1] " PierreGondois 2023-12-01 10:22 ` Ni, Ray @ 2023-12-22 15:29 ` Sami Mujawar 1 sibling, 0 replies; 7+ messages in thread From: Sami Mujawar @ 2023-12-22 15:29 UTC (permalink / raw) To: Pierre Gondois, devel Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Leif Lindholm, nd@arm.com Hi Pierre, Thank you for this patch. I just have one comment marked inline as [SAMI]. Otherwise this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 30/11/2023 11:09 am, Pierre Gondois wrote: > Add definitions for: > - _PSD version: added in ACPI 3.0 > - C-state Coordination Types: added in ACPI 3.0 > - _CPC version: added in ACPI 5.0 > > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> > --- > MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++ > MdePkg/Include/IndustryStandard/Acpi40.h | 5 +++++ > MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++ > MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++ > 10 files changed, 99 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h > index 29f0d5535593..cb50b1d8f71a 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi30.h > +++ b/MdePkg/Include/IndustryStandard/Acpi30.h > @@ -17,6 +17,20 @@ > > > #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR 0x8B > > > > +/// > > +/// C-state Coordination Types > > +/// See s8.4.2.2 _CSD (C-State Dependency) > > +/// > > +#define ACPI_AML_COORD_TYPE_SW_ALL 0xFC > > +#define ACPI_AML_COORD_TYPE_SW_ANY 0xFD > > +#define ACPI_AML_COORD_TYPE_HW_ALL 0xFE > > + > > +/// > > +/// _PSD Revision for ACPI 3.0 > > +// See s8.4.4.5 _PSD (P-State Dependency) > > +/// > > +#define EFI_ACPI_3_0_AML_PSD_REVISION 0 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h > index a2da09346f1c..0e30f4f8417d 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi40.h > +++ b/MdePkg/Include/IndustryStandard/Acpi40.h > @@ -10,6 +10,11 @@ > > > #include <IndustryStandard/Acpi30.h> > > > > +/// > > +/// _PSD Revision for ACPI 4.0 > > +/// > > +#define EFI_ACPI_4_0_AML_PSD_REVISION 0 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h > index 76706aa640f8..a00b8259b8f7 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > @@ -23,6 +23,16 @@ > #define ACPI_GPIO_CONNECTION_DESCRIPTOR 0x8C > > #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR 0x8E > > > > +/// > > +/// _PSD Revision for ACPI 5.0 > > +/// > > +#define EFI_ACPI_5_0_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 5.0 > > +/// > > +#define EFI_ACPI_5_0_AML_CPC_REVISION 1 > > + > > #pragma pack(1) > > > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h > index 01ef544c3a29..19dd7b4f864c 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > @@ -13,6 +13,16 @@ > > > #include <IndustryStandard/Acpi50.h> > > > > +/// > > +/// _PSD Revision for ACPI 5.1 > > +/// > > +#define EFI_ACPI_5_1_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 5.1 > > +/// > > +#define EFI_ACPI_5_1_AML_CPC_REVISION 1 [SAMI] I believe the CPC revision value is 2 in this revision of the specification. See Table 8-228 in https://uefi.org/sites/default/files/resources/ACPI_5_1_Errata_B.PDF > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h > index 5ac3be6ad71c..3757d3f82792 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -12,6 +12,16 @@ > > > #include <IndustryStandard/Acpi51.h> > > > > +/// > > +/// _PSD Revision for ACPI 6.0 > > +/// > > +#define EFI_ACPI_6_0_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.0 > > +/// > > +#define EFI_ACPI_6_0_AML_CPC_REVISION 2 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h > index 7af67d832bb2..c3facc6e376e 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -12,6 +12,16 @@ > > > #include <IndustryStandard/Acpi60.h> > > > > +/// > > +/// _PSD Revision for ACPI 6.1 > > +/// > > +#define EFI_ACPI_6_1_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.1 > > +/// > > +#define EFI_ACPI_6_1_AML_CPC_REVISION 2 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h > index e27775a85ade..4dd3e21c2325 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -29,6 +29,16 @@ > #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR 0x91 > > #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR 0x92 > > > > +/// > > +/// _PSD Revision for ACPI 6.2 > > +/// > > +#define EFI_ACPI_6_2_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.2 > > +/// > > +#define EFI_ACPI_6_2_AML_CPC_REVISION 3 > > + > > #pragma pack(1) > > > > /// > > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h > index 10bdf5fe5a57..7582dccf649b 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > @@ -12,6 +12,16 @@ > > > #include <IndustryStandard/Acpi62.h> > > > > +/// > > +/// _PSD Revision for ACPI 6.3 > > +/// > > +#define EFI_ACPI_6_3_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.3 > > +/// > > +#define EFI_ACPI_6_3_AML_CPC_REVISION 3 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h > index 575ca0430c13..faf069a0454e 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -12,6 +12,16 @@ > > > #include <IndustryStandard/Acpi63.h> > > > > +/// > > +/// _PSD Revision for ACPI 6.4 > > +/// > > +#define EFI_ACPI_6_4_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.4 > > +/// > > +#define EFI_ACPI_6_4_AML_CPC_REVISION 3 > > + > > // > > // Ensure proper structure formats > > // > > diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65.h > index d79d0b2b5f9c..b9616a3e29c2 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi65.h > +++ b/MdePkg/Include/IndustryStandard/Acpi65.h > @@ -18,6 +18,16 @@ > // > > #pragma pack(1) > > > > +/// > > +/// _PSD Revision for ACPI 6.5 > > +/// > > +#define EFI_ACPI_6_5_AML_PSD_REVISION 0 > > + > > +/// > > +/// _CPC Revision for ACPI 6.5 > > +/// > > +#define EFI_ACPI_6_5_AML_CPC_REVISION 3 > > + > > /// > > /// ACPI 6.5 Generic Address Space definition > > /// > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112847): https://edk2.groups.io/g/devel/message/112847 Mute This Topic: https://groups.io/mt/102891569/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-12-22 15:30 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-11-30 11:09 [edk2-devel] [PATCH 0/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions PierreGondois 2023-11-30 11:09 ` [edk2-devel] [PATCH 1/1] " PierreGondois 2023-12-01 10:22 ` Ni, Ray 2023-12-01 12:26 ` PierreGondois 2023-12-06 9:42 ` PierreGondois 2023-12-12 0:36 ` 回复: " gaoliming via groups.io 2023-12-22 15:29 ` Sami Mujawar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox