From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B68E0D80FCA for ; Wed, 2 Aug 2023 09:15:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=absWHDUW8eZ4QVqiQBOzw6reyk4rsgo0WgcZ/EQvp/o=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1690967752; v=1; b=oDXATcFD2e+gsKdvUYRgQfGrMOeuqKKagv8VvNF502bJHOErO0X5V6rhvfc5k2OpEzg390fY +/gtoKhwyCxynvxLatM7HwFlMK1lowXqzz1+pW5ysVRdxiKz72IbD8NIYeiXHaAvmdSgYsrbPk5 avDUsrkZlzHOqB/jYVpctz40= X-Received: by 127.0.0.2 with SMTP id wPf1YY7687511x0aIiYVLrUL; Wed, 02 Aug 2023 02:15:52 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.10102.1690967748553767557 for ; Wed, 02 Aug 2023 02:15:51 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 3606CDDAA61 for ; Wed, 2 Aug 2023 17:12:23 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 313DEDDA978 for ; Wed, 2 Aug 2023 17:12:23 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 5DE8DDDAA81 for ; Wed, 2 Aug 2023 17:12:20 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 02 Aug 2023 17:12:17 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Sheng, W'" , Cc: "'Yao, Jiewen'" , "'Wang, Jian J'" , "'Xu, Min M'" , "'Chen, Zeyi'" , "'Wang, Fiona'" , "'Lu, Xiaoyu1'" , "'Jiang, Guomin'" , "'Kinney, Michael D'" References: <20230727063513.437-1-w.sheng@intel.com> <1775A5F91CFEF78E.27447@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFY1IDEvM10gTWRlUGtnL0luY2x1ZGU6IEFkZCBHVUlEIGZvciBDRVJUX1JTQTMwNzIgYW5kIENFUlRfUlNBNDA5Ng==?= Date: Wed, 2 Aug 2023 17:12:18 +0800 Message-ID: <008501d9c521$6fb2ed10$4f18c730$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJ8KOzg9zidmi7o43gkkAAaOpB3hwIohAElAomhkQMCYQHTDQFRRfL0rk7M9nA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2DqJXZX3sRgor4xfq7vF53mLx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oDXATcFD; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Sheng Wei: I gave my comments for the patch 1/3 on this morning. Have you got my response?=20 I just want to confirm whether these two new GUID are in the public UEFI spec or not. Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Sheng, W > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA8=D4=C22=C8=D5 16:04 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Gao, Liming > =B3=AD=CB=CD: Yao, Jiewen ; Wang, Jian J > ; Xu, Min M ; Chen, Zeyi > ; Wang, Fiona ; Lu, Xiaoyu1 > ; Jiang, Guomin ; Kinney, > Michael D > =D6=F7=CC=E2: RE: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID fo= r > CERT_RSA3072 and CERT_RSA4096 >=20 > Hi Gao, Liming, > For this patch group, we have got review-by from Yao, Jiewen on patch > 2/3(CryptoPkg) and patch 3/3(SecurityPkg). > Do you any comments on the patch 1/3 (MdePkg) ? > Patch 1/3 is only to add 2 new GUIDs. > Could you help to merge it ? >=20 > Thank you. > BR > Sheng Wei >=20 > > -----Original Message----- > > From: Sheng, W > > Sent: 2023=C4=EA7=D4=C231=C8=D5 10:02 > > To: 'devel@edk2.groups.io' ; Gao, Liming > > > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Xu, Min M ; Chen, Zeyi > > ; Wang, Fiona ; Lu, Xiaoyu1 > > ; Jiang, Guomin ; Kinney, > > Michael D > > Subject: RE: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for > > CERT_RSA3072 and CERT_RSA4096 > > > > Hi Gao, Liming, > > Could you help to review and merge this patch to MdePkg? > > This patch is only to add 2 new GUIDs. > > These 2 GUIDs will be used for adding RSA3072/RSA4096 cert support for > > secure boot feature. > > Thank you. > > BR > > Sheng Wei > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > > Sheng > > > > Wei > > > > Sent: 2023=C4=EA7=D4=C227=C8=D5 14:35 > > > > To: devel@edk2.groups.io > > > > Cc: Yao, Jiewen ; Wang, Jian J > > > > ; Xu, Min M ; Chen, Zeyi > > > > ; Wang, Fiona ; Lu, > > > > Xiaoyu1 ; Jiang, Guomin > > > > ; Kinney, Michael D > > > > ; Gao, Liming > > > > > Subject: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for > > > > CERT_RSA3072 and CERT_RSA4096 > > > > > > > > Add gEfiCertRsa3072Guid and gEfiCertRsa4096Guid > > > > > > > > Cc: Jiewen Yao > > > > Cc: Jian J Wang > > > > Cc: Min Xu > > > > Cc: Zeyi Chen > > > > Cc: Fiona Wang > > > > Cc: Xiaoyu Lu > > > > Cc: Guomin Jiang > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Signed-off-by: Sheng Wei > > > > --- > > > > MdePkg/Include/Guid/ImageAuthentication.h | 26 > > > > +++++++++++++++++++++++ > > > > MdePkg/MdePkg.dec | 2 ++ > > > > 2 files changed, 28 insertions(+) > > > > > > > > diff --git a/MdePkg/Include/Guid/ImageAuthentication.h > > > > b/MdePkg/Include/Guid/ImageAuthentication.h > > > > index fe83596571..c8ea2c14fb 100644 > > > > --- a/MdePkg/Include/Guid/ImageAuthentication.h > > > > +++ b/MdePkg/Include/Guid/ImageAuthentication.h > > > > @@ -144,6 +144,30 @@ typedef struct { > > > > 0x3c5766e8, 0x269c, 0x4e34, {0xaa, 0x14, 0xed, 0x77, 0x6e, 0x85, > 0xb3, > > > > 0xb6} \ } +///+/// This identifies a signature containing an RSA-3072 > key. > > > The > > > > key (only the modulus+/// since the public key exponent is known to > > > > be > > > > 0x10001) shall be stored in big-endian+/// order.+/// The > > > > SignatureHeader size shall always be 0. The SignatureSize shall > > > > always be 16 (size+/// of SignatureOwner component) + 384 > > bytes.+///+#define > > > > EFI_CERT_RSA3072_GUID \+ { \+ 0xedd320c2, 0xb057, 0x4b8e, > {0xad, > > > 0x46, > > > > 0x2c, 0x9b, 0x85, 0x89, 0xee, 0x92 } \+ }++///+/// This identifies > > > > a signature containing an RSA-4096 key. The key (only the > > > > modulus+/// since the public key exponent is known to be 0x10001) > > > > shall be stored in big-endian+/// order.+/// The SignatureHeader > > > > size shall always be 0. The SignatureSize shall always be 16 > > > > (size+/// of SignatureOwner > > > component) + 512 > > > > bytes.+///+#define EFI_CERT_RSA4096_GUID \+ { \+ > 0xb23e89a6, > > 0x8c8b, > > > > 0x4412, {0x85, 0x73, 0x15, 0x4e, 0x8d, 0x00, 0x98, 0x2c } \+ }+ //= / > > > > /// This identifies a signature containing a RSA-2048 signature of = a > > > > SHA-256 hash. The /// SignatureHeader size shall always be 0. The > > > > SignatureSize shall always be > > > > 16 (size of@@ -330,6 +354,8 @@ typedef struct { extern EFI_GUID > > > > gEfiImageSecurityDatabaseGuid; extern EFI_GUID gEfiCertSha256Guid; > > > > extern EFI_GUID gEfiCertRsa2048Guid;+extern EFI_GUID > > > > gEfiCertRsa3072Guid;+extern EFI_GUID gEfiCertRsa4096Guid; extern > > > > EFI_GUID gEfiCertRsa2048Sha256Guid; extern EFI_GUID > > > > gEfiCertSha1Guid; extern EFI_GUID gEfiCertRsa2048Sha1Guid;diff > > > > --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > > > b85614992b..24e4779d33 100644 > > > > --- a/MdePkg/MdePkg.dec > > > > +++ b/MdePkg/MdePkg.dec > > > > @@ -581,6 +581,8 @@ > > > > gEfiImageSecurityDatabaseGuid =3D { 0xd719b2cb, 0x3d3a, 0x4596, > {0xa3, > > > > 0xbc, 0xda, 0xd0, 0xe, 0x67, 0x65, 0x6f }} gEfiCertSha256Guid > =3D > > > > { 0xc1c41626, 0x504c, 0x4092, {0xac, 0xa9, 0x41, 0xf9, 0x36, 0x93, > > > > 0x43, > > > 0x28 }} > > > > gEfiCertRsa2048Guid =3D { 0x3c5766e8, 0x269c, 0x4e34, > {0xaa, 0x14, > > > 0xed, > > > > 0x77, 0x6e, 0x85, 0xb3, 0xb6 }}+ gEfiCertRsa3072Guid = =3D > > { 0xedd320c2, > > > > 0xb057, 0x4b8e, {0xad, 0x46, 0x2c, 0x9b, 0x85, 0x89, 0xee, 0x92 }}+ > > > > gEfiCertRsa4096Guid =3D { 0xb23e89a6, 0x8c8b, 0x4412, > {0x85, 0x73, > > > 0x15, > > > > 0x4e, 0x8d, 0x00, 0x98, 0x2c }} gEfiCertRsa2048Sha256Guid = =3D > > > { 0xe2b36190, > > > > 0x879b, 0x4a3d, {0xad, 0x8d, 0xf2, 0xe7, 0xbb, 0xa3, 0x27, 0x84 }} > > > > gEfiCertSha1Guid =3D { 0x826ca512, 0xcf10, 0x4ac9, > {0xb1, 0x87, 0xbe, > > > > 0x1, 0x49, 0x66, 0x31, 0xbd }} gEfiCertRsa2048Sha1Guid =3D > > { 0x67f8444f, > > > > 0x8743, 0x48f1, {0xa3, 0x28, 0x1e, 0xaa, 0xb8, 0x73, 0x60, 0x80 }}-= - > > > > 2.26.2.windows.1 > > > > > > > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#107294): > > > > https://edk2.groups.io/g/devel/message/107294 > > > > Mute This Topic: https://groups.io/mt/100385942/2558558 > > > > Group Owner: devel+owner@edk2.groups.io > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > > > [w.sheng@intel.com] > > > > - =3D-=3D-=3D-=3D-=3D-=3D > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107455): https://edk2.groups.io/g/devel/message/107455 Mute This Topic: https://groups.io/mt/100501594/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-