From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web08.7848.1636005581010840202
 for <devel@edk2.groups.io>;
 Wed, 03 Nov 2021 22:59:41 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Thu, 04 Nov 2021 13:59:36 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <mikuback@linux.microsoft.com>,
	<devel@edk2.groups.io>
Cc: "'Jian J Wang'" <jian.j.wang@intel.com>,
	"'Hao A Wu'" <hao.a.wu@intel.com>,
	"'Ray Ni'" <ray.ni@intel.com>
References: <20211103151625.2992-1-mikuback@linux.microsoft.com>
In-Reply-To: <20211103151625.2992-1-mikuback@linux.microsoft.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjEgMS8xXSBNZGVNb2R1bGVQa2cvWGhjaVNjaGVkOiBGaXggbWlzc2luZyBERUJVRyBhcmd1bWVudHM=?=
Date: Thu, 4 Nov 2021 13:59:39 +0800
Message-ID: <008801d7d141$27b51fe0$771f5fa0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQE5BJ40pxt4ubMUJXkI0q4UX6DAV60weRHw
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: mikuback@linux.microsoft.com =
<mikuback@linux.microsoft.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C23=C8=D5 23:16
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Hao A Wu <hao.a.wu@intel.com>; Ray Ni
> <ray.ni@intel.com>
> =D6=F7=CC=E2: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG
> arguments
>=20
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>=20
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3662
>=20
> Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument
> that should be passed for the print specifier.
>=20
> In addition, this change updates the print level to "DEBUG_ERROR"
> and prints the status as well.
>=20
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index 7cbc9a8502ea..6fcd2be6277c 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot (
>      DEBUG ((EFI_D_INFO, "    Address %d assigned successfully\n",
> DeviceAddress));
>      Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress;
>    } else {
> -    DEBUG ((DEBUG_INFO, "    Address %d assigned unsuccessfully\n"));
> +    DEBUG ((DEBUG_ERROR, "    Slot %d address not assigned
> successfully. Status =3D %r\n", SlotId, Status));
>      XhcDisableSlotCmd (Xhc, SlotId);
>    }
>=20
> @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 (
>      DEBUG ((EFI_D_INFO, "    Address %d assigned successfully\n",
> DeviceAddress));
>      Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress;
>    } else {
> -    DEBUG ((DEBUG_INFO, "    Address %d assigned unsuccessfully\n"));
> +    DEBUG ((DEBUG_ERROR, "    Slot %d address not assigned
> successfully. Status =3D %r\n", SlotId, Status));
>      XhcDisableSlotCmd64 (Xhc, SlotId);
>    }
>=20
> --
> 2.28.0.windows.1