From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.8048.1636005988285120119 for ; Wed, 03 Nov 2021 23:06:29 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 04 Nov 2021 14:06:17 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Christopher Jones'" , Cc: , , , , "'Alexei Fedorov'" , "'Sami Mujawar'" , "'nd'" References: <20211018151046.31232-1-christopher.jones@arm.com> <003201d7cf88$48890480$d99b0d80$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDAvN10gU3VwcG9ydCBBQ1BJIDYuNCBQUFRUIGNoYW5nZXM=?= Date: Thu, 4 Nov 2021 14:06:20 +0800 Message-ID: <008901d7d142$16c20620$44461260$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHVDG7DSKVFbPFvNIaAJ0iVaBCYwgM6hvYaAj6REoqrzKJ98A== Content-Type: multipart/alternative; boundary="----=_NextPart_000_008A_01D7D185.24E6CCC0" Content-Language: zh-cn ------=_NextPart_000_008A_01D7D185.24E6CCC0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Sure. Liming.=20 =20 =B7=A2=BC=FE=C8=CB: Christopher Jones =20 =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C24=C8=D5 0:20 =CA=D5=BC=FE=C8=CB: gaoliming ; devel@edk2.groups= .io =B3=AD=CB=CD: michael.d.kinney@intel.com; zhiguang.liu@intel.com; ray.ni@in= tel.com; zhichao.gao@intel.com; Alexei Fedorov ; Sami Mujawa= r ; nd =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes =20 Thank you for the review, Liming. =20 Since uploading the original patch series I noticed some issues myself and have sent a v2 for the patch series (https://edk2.groups.io/g/devel/message/83272). I have not made any MdePkg changes, so I assume your review carries over to the new series? =20 =20 Thanks, Chris _____ =20 From: gaoliming > Sent: Tuesday, November 2, 2021 1:23 AM To: devel@edk2.groups.io >; Christopher Jones > Cc: michael.d.kinney@intel.com >; zhiguang= . liu@intel.com >; ray.ni@intel.com >; zhichao.gao@intel.com >; Alexei Fedorov >; Sami Mujawar >; nd > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT ch= anges=20 =20 For the changes in MdePkg, Reviewed-by: Liming Gao > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io > =B4=FA=B1=ED Chris Jo= nes > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C218=C8=D5 23:11 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io =20 > =B3=AD=CB=CD: michael.d.kinney@intel.com ; gaoliming@byosoft.com.cn ; > zhiguang.liu@intel.com ; ray.ni@intel.com ; zhichao.gao@intel.com ; > Alexei.Fedorov@arm.com ; Sami.Mujawar@arm= . com ; nd@arm.com =20 > =D6=F7=CC=E2: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes >=20 > Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3697) >=20 > This patch series updates the Acpiview PPTT parser and DynamicTablesPkg > PPTT generator to support ACPI 6.4. This consists of two main changes: > - The addition of the 'Cache ID' field. > - The removal of the PPTT ID (type 2) structure. >=20 > In addition add two 'Cache ID' defines and remove the type 2 PPTT > structure from Acpi64.h as these changes were missing when Acpi64.h was > introduced. >=20 > The changes can be seen at: > https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_cache_id_v1 >=20 > Chris Jones (7): > MdePkg: Add missing Cache ID (in)valid define > MdePkg: Remove PPTT ID type structure > ShellPkg: Update Acpiview PPTT parser to ACPI 6.4 > ShellPkg: Add Cache ID to PPTT parser > DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator > DynamicTablesPkg: Update PPTT generator to ACPI 6.4 > DynamicTablesPkg: Add CacheId to PPTT generator >=20 > .../Include/ArmNameSpaceObjects.h | 27 +- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 297 +++++++----------- > .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 4 - > MdePkg/Include/IndustryStandard/Acpi64.h | 18 +- > .../Parsers/Pptt/PpttParser.c | 179 ++++++++--- > .../UefiShellAcpiViewCommandLib.c | 2 +- > 6 files changed, 249 insertions(+), 278 deletions(-) >=20 > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >=20 >=20 >=20 >=20 >=20 ------=_NextPart_000_008A_01D7D185.24E6CCC0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Sure. Liming.

 =

=B7=A2=BC=FE=C8=CB: Christopher Jones <Christopher.Jones@arm.com>= ;
= =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C24=C8=D5 0:20=
=CA=D5=BC=FE=C8=CB: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io<= br>=B3=AD=CB=CD:= michael.d.kinney@intel.com; zhiguang.liu@intel.com; ray.ni@intel.com; zhic= hao.gao@intel.com; Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Muja= war <Sami.Mujawar@arm.com>; nd <nd@arm.com>
=D6=F7= =CC=E2: Re: [edk2-devel] [= PATCH v1 0/7] Support ACPI 6.4 PPTT changes

 

Thank you for the rev= iew, Liming.

 

Since uploading the original patch series I not= iced some issues myself and have sent a v2 for the patch series (https://edk2.groups.io/g/dev= el/message/83272). I have not made any MdePkg changes, so I assume your= review carries over to the new series?

 

 

Thanks,

Chris

<= span lang=3DEN-US style=3D'font-size:11.0pt;font-family:"Calibri",sans-seri= f;color:black'>From: gaoliming <gaoliming@byosoft.com.cn>
Sent:= Tuesday, November 2, 2021 1:23 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Christopher Jones <Christopher.Jones@arm.com>
C= c: michael.d.kinney@intel= .com <michael.d.kinney= @intel.com>; zhiguang.liu@= intel.com <zhiguang.liu@in= tel.com>; ray.ni@intel.com &= lt;ray.ni@intel.com>; zhichao.gao@intel.com <zhichao.gao@intel.com>; Alexei Fedorov &l= t;Alexei.Fedorov@arm.com>;= Sami Mujawar <Sami.Mujawar@arm.= com>; nd <nd@arm.com>
= Subject: =BB=D8=B8= =B4: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PP= TT changes

 

<= div>

For the changes in MdePkg, Reviewed-by: Liming G= ao
<gaoliming@byosoft.com= .cn>

> -----=D3=CA= =BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8= =CB: devel@edk2.= groups.io <devel@edk2.groups= .io> =B4=FA=B1=ED Chris Jones
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C218=C8=D5 23:11
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD= =CB=CD: mi= chael.d.kinney@intel.com; g= aoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; ray.ni@= intel.com; zhichao.gao@intel.c= om;
> Alexei.Fedorov@ar= m.com; Sami.Mujawar@arm.com= ; nd@arm.com
> =D6=F7=CC=E2<= span lang=3DEN-US>: [edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT chang= es
>
> Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id= =3D3697)
>
> This patch series updates the Acpiview PPTT p= arser and DynamicTablesPkg
> PPTT generator to support ACPI 6.4. This= consists of two main changes:
>  - The addition of the 'Cache I= D' field.
>  - The removal of the PPTT ID (type 2) structure.>
> In addition add two 'Cache ID' defines and remove the type 2= PPTT
> structure from Acpi64.h as these changes were missing when Ac= pi64.h was
> introduced.
>
> The changes can be seen at:=
> https://github.com/chris-jones-arm/edk2/tree/1632_64_acpi_c= ache_id_v1
>
> Chris Jones (7):
>   MdePkg= : Add missing Cache ID (in)valid define
>   MdePkg: Remove = PPTT ID type structure
>   ShellPkg: Update Acpiview PPTT p= arser to ACPI 6.4
>   ShellPkg: Add Cache ID to PPTT parser=
>   DynamicTablesPkg: Remove PPTT ID structure from ACPI 6= .4 generator
>   DynamicTablesPkg: Update PPTT generator to= ACPI 6.4
>   DynamicTablesPkg: Add CacheId to PPTT generat= or
>
>  .../Include/ArmNameSpaceObjects.h  &nbs= p;          |  27 +-
&= gt;  .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c   | 297 +++= ++++-----------
>  .../Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h&n= bsp;  |   4 -
>  MdePkg/Include/IndustryStandard/= Acpi64.h      |  18 +-
>  .../Pars= ers/Pptt/PpttParser.c         =         | 179 ++++++++---
>  = .../UefiShellAcpiViewCommandLib.c       =       |   2 +-
>  6 files cha= nged, 249 insertions(+), 278 deletions(-)
>
> --
> Guid(= "CE165669-3EF3-493F-B85D-6190EE5B9759")
>
>
>=
>
>


------=_NextPart_000_008A_01D7D185.24E6CCC0--