From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.8142.1636006674396149393
 for <devel@edk2.groups.io>;
 Wed, 03 Nov 2021 23:17:55 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <ardb+tianocore@kernel.org>; Thu, 04 Nov 2021 14:17:50 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<michael.d.kinney@intel.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>,
	"'Leif Lindholm'" <leif@nuviainc.com>,
	"'Ard Biesheuvel'" <ardb+tianocore@kernel.org>
References: <20211103225954.1680-1-michael.d.kinney@intel.com> <20211103225954.1680-8-michael.d.kinney@intel.com>
In-Reply-To: <20211103225954.1680-8-michael.d.kinney@intel.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIFYyIDcvN10gQmFzZVRvb2xzL0NvbmY6IEZpeCBMaW51eCBHQ0MgQVJNIGJ1aWxkIGlzc3VlcyB3aXRoIEhJSQ==?=
Date: Thu, 4 Nov 2021 14:17:53 +0800
Message-ID: <009001d7d143$b3669ee0$1a33dca0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQIyhvDji+j9QUmFB3Lb6c+pQsBb9QIgqQ6Gqyxzt4A=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Mike:=20

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=B1=
=ED Michael D
> Kinney
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C24=C8=D5 7:00
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>; Leif
> Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>
> =D6=F7=CC=E2: [edk2-devel] [Patch V2 7/7] BaseTools/Conf: Fix Linux GCC A=
RM build
> issues with HII
>=20
> Update builds_rules.template to add $(SLINK) to the GCC
> steps for processing HII resources to produce a static
> library instead of an object file.  This improves linker
> compatibility and specifically fixes a link failure seen
> on Linux GCC ARM builds of the MdeModulePkg due to
> mismatched ABI types between the HII resource section
> and the rest of the libraries.
>=20
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  BaseTools/Conf/build_rule.template | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/BaseTools/Conf/build_rule.template
> b/BaseTools/Conf/build_rule.template
> index 3add1029f276..5f59044da36d 100755
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -668,6 +668,8 @@
>=20
>      <Command.GCC>
>          "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g
> $(MODULE_GUID) --hiibinpackage $(HII_BINARY_PACKAGES)
> $(GENFW_FLAGS)
> -        "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc
> ${dst}
> +        "$(RC)" $(RC_FLAGS) $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc
> $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc.obj
> +        "$(SLINK)" cr  ${dst}
> $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc.obj
> +

Here=A3=ACcr is the fixed command. Do you think to add SLINK_FLAGS macro fo=
r
this option?

Thanks
Liming
>      <Command.XCODE, Command.RVCT, Command.CLANGGCC>
>          "$(GENFW)" -o $(OUTPUT_DIR)(+)$(MODULE_NAME)hii.rc -g
> $(MODULE_GUID) --hiibinpackage $(HII_BINARY_PACKAGES)
> $(GENFW_FLAGS)
> --
> 2.32.0.windows.1
>=20
>=20
>=20
>=20
>=20