From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Rebecca Cran'" <rebecca@nuviainc.com>, <devel@edk2.groups.io>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
"'Ray Ni'" <ray.ni@intel.com>,
"'Zhichao Gao'" <zhichao.gao@intel.com>
Subject: 回复: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
Date: Thu, 22 Oct 2020 09:46:55 +0800 [thread overview]
Message-ID: <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> (raw)
In-Reply-To: <20201021184115.25712-1-rebecca@nuviainc.com>
Rebecca:
They are the good change. But for patch 4/6, it changes the structure
field name. It may bring the impact to the platform code. I don't suggest to
do the renaming field only for typo purpose. Other changes are good to me.
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年10月22日 2:41
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao
> Gao <zhichao.gao@intel.com>
> 主题: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64
> SoC ID definition
>
> Fix some typos in smbiosview and SmBios.h.
>
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and smbiosview.
>
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>
> Pull request: https://github.com/tianocore/edk2/pull/1038
> Also built OVMF X64 and verified smbiosview still runs.
>
> Rebecca Cran (6):
> ShellPkg: Fix a couple of typos in smbiosview
> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
> MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS
> ShellPkg: Fix smbiosview string definition name for "boot from CD"
>
> MdePkg/Include/IndustryStandard/SmBios.h | 21
> ++++++++++---------
> .../SmbiosView/PrintInfo.c | 2 +-
> .../SmbiosView/QueryTable.c | 4 ++++
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 4 files changed, 18 insertions(+), 13 deletions(-)
>
> --
> 2.26.2
next prev parent reply other threads:[~2020-10-22 1:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 18:41 [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-21 18:41 ` [PATCH 1/6] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-21 18:41 ` [PATCH 2/6] ShellPkg: Add ARM64 SoC ID to Processor Characteristics " Rebecca Cran
2020-10-21 18:41 ` [PATCH 3/6] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
2020-10-21 18:41 ` [PATCH 4/6] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct Rebecca Cran
2020-10-21 18:41 ` [PATCH 5/6] MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS Rebecca Cran
2020-10-21 18:41 ` [PATCH 6/6] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
2020-10-22 1:46 ` gaoliming [this message]
2020-10-22 2:21 ` [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-23 6:49 ` Gao, Zhichao
2020-10-26 1:24 ` 回复: " gaoliming
2020-10-26 17:47 ` 回复: " Leif Lindholm
2020-10-27 6:32 ` 回复: " gaoliming
2020-10-27 7:40 ` Gao, Zhichao
2020-10-27 14:33 ` 回复: " Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox