From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.3872.1603331218030971570
 for <devel@edk2.groups.io>;
 Wed, 21 Oct 2020 18:46:59 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Thu, 22 Oct 2020 09:46:53 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Rebecca Cran'" <rebecca@nuviainc.com>,
	<devel@edk2.groups.io>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Ray Ni'" <ray.ni@intel.com>,
	"'Zhichao Gao'" <zhichao.gao@intel.com>
References: <20201021184115.25712-1-rebecca@nuviainc.com>
In-Reply-To: <20201021184115.25712-1-rebecca@nuviainc.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMC82XSBzbWJpb3N2aWV3IGFuZCBTbUJpb3MuaCBmaXhlcywgYWRkIFNNQklPUyAzLjQuMCBBUk02NCBTb0MgSUQgZGVmaW5pdGlvbg==?=
Date: Thu, 22 Oct 2020 09:46:55 +0800
Message-ID: <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQLu67P94R99nj5uRei9iJPsNG9Q26dyUF6g
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Rebecca:
  They are the good change. But for patch 4/6, it changes the structure
field name. It may bring the impact to the platform code. I don't =
suggest to
do the renaming field only for typo purpose. Other changes are good to =
me.
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Rebecca Cran <rebecca@nuviainc.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA10=D4=C222=C8=D5 2:41
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; =
Zhichao
> Gao <zhichao.gao@intel.com>
> =D6=F7=CC=E2: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS =
3.4.0 ARM64
> SoC ID definition
>=20
> Fix some typos in smbiosview and SmBios.h.
>=20
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and smbiosview.
>=20
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>=20
> Pull request: https://github.com/tianocore/edk2/pull/1038
> Also built OVMF X64 and verified smbiosview still runs.
>=20
> Rebecca Cran (6):
>   ShellPkg: Fix a couple of typos in smbiosview
>   ShellPkg: Add ARM64 SoC ID to Processor Characteristics in =
smbiosview
>   MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
>   MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS
>   ShellPkg: Fix smbiosview string definition name for "boot from CD"
>=20
>  MdePkg/Include/IndustryStandard/SmBios.h      | 21
> ++++++++++---------
>  .../SmbiosView/PrintInfo.c                    |  2 +-
>  .../SmbiosView/QueryTable.c                   |  4 ++++
>  .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>  4 files changed, 18 insertions(+), 13 deletions(-)
>=20
> --
> 2.26.2