From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF52A740046 for ; Fri, 2 Feb 2024 14:20:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bSB1565RI6e/nzsuF/dADdGLSpwImSKHTAr8jDDARwY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706883652; v=1; b=d3BV3JWEsnyC27GbmccSObGeEfEueieSw/GlHBbYNWaVNmbMtCrEHD+JHyGf8NhTPDQg0jWr SKcIbjRMXKw3qyE1Hbimo23RIeOq62G340cGDFgOk2/X/JMhpc9jrYQBxHXJ4+BLmnYq2b0O7mk uyPHjdhnFT3RIXvU0uBXaI6w= X-Received: by 127.0.0.2 with SMTP id zRPjYY7687511xnaBRoG87fG; Fri, 02 Feb 2024 06:20:52 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.23650.1706883651716282707 for ; Fri, 02 Feb 2024 06:20:51 -0800 X-Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 412BQbL0006730; Fri, 2 Feb 2024 14:20:51 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w0ptv1k7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Feb 2024 14:20:51 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 412EKoJU021048 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 2 Feb 2024 14:20:50 GMT X-Received: from [10.111.142.180] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 2 Feb 2024 06:20:49 -0800 Message-ID: <00919211-b211-42b7-9af2-f49b6839f013@quicinc.com> Date: Fri, 2 Feb 2024 14:20:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH V3 4/5] ArmPlatformPkg: Align PL031 library function headers with return values To: Suqiang Ren , CC: Ard Biesheuvel References: From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: 5X9hWz8vydVkd-mpPpuH3J03xvwzhizo X-Proofpoint-GUID: 5X9hWz8vydVkd-mpPpuH3J03xvwzhizo X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 412BQbL0006730 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gCBRelwa0YWoyb15kYNFSjXrx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=d3BV3JWE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-02-02 08:20, Suqiang Ren wrote: > RealTimeClockLib is used to back the runtime services time functions, so > align the description of the function return values with the defined valu= es > for these services as described in UEFI Spec 2.10. >=20 > REF: UEFI spec 2.10 section 8 Services =E2=80=94 Runtime Services >=20 > Signed-off-by: Suqiang Ren > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm / Leif > --- > .../PL031RealTimeClockLib.c | 22 +++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeCl= ockLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockL= ib.c > index 1896f9d16d3b..6ab3e9948335 100644 > --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.= c > +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.= c > @@ -111,7 +111,9 @@ EXIT: > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The time could not be retrieved due to= hardware error. > - @retval EFI_SECURITY_VIOLATION The time could not be retrieved due to = an authentication failure. > + @retval EFI_UNSUPPORTED This call is not supported by this plat= form at the time the call is made. > + The platform should describe this runti= me service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configur= ation table. > =20 > **/ > EFI_STATUS > @@ -172,6 +174,9 @@ LibGetTime ( > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER A time field is out of range. > @retval EFI_DEVICE_ERROR The time could not be set due to hardwa= re error. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS > @@ -224,8 +229,13 @@ LibSetTime ( > @param Time The current alarm setting. > =20 > @retval EFI_SUCCESS The alarm settings were returned. > - @retval EFI_INVALID_PARAMETER Any parameter is NULL. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved = due to a hardware error. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS > @@ -248,9 +258,13 @@ LibGetWakeupTime ( > =20 > @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alar= m was enabled. If > Enable is FALSE, then the wakeup alarm = was disabled. > - @retval EFI_INVALID_PARAMETER A time field is out of range. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be set due to= a hardware error. > - @retval EFI_UNSUPPORTED A wakeup timer is not supported on this = platform. > + @retval EFI_UNSUPPORTED This call is not supported by this platf= orm at the time the call is made. > + The platform should describe this runtim= e service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configura= tion table. > =20 > **/ > EFI_STATUS -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115049): https://edk2.groups.io/g/devel/message/115049 Mute This Topic: https://groups.io/mt/104115880/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-