From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.21987.1604972413717536925
 for <devel@edk2.groups.io>;
 Mon, 09 Nov 2020 17:40:14 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <dandan.bi@intel.com>; Tue, 10 Nov 2020 09:40:11 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<gechao@greatwall.com.cn>
Cc: <dandan.bi@intel.com>,
	<eric.dong@intel.com>
References: <e0e609fcc2dddcd9f45f9fc2e11bfba030717e76.1604316574.git.gechao@greatwall.com.cn>
In-Reply-To: <e0e609fcc2dddcd9f45f9fc2e11bfba030717e76.1604316574.git.gechao@greatwall.com.cn>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2c6IENvcnJlY3QgdGhlIHZhcmlhYmxlIG5hbWUu?=
Date: Tue, 10 Nov 2020 09:40:11 +0800
Message-ID: <009701d6b702$6dce9100$496bb300$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQIqy+ipvO2L/68ARO0xwokzeetm9akYbLKg
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Chao:
  Please update the commit message title as MdeModulePkg =
DisplayEngineDxe:
Correct the local variable name
 =20
  With this change, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+66921+4905953+8761045@groups.io
> <bounce+27952+66921+4905953+8761045@groups.io> =B4=FA=B1=ED
> gechao@greatwall.com.cn
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C23=C8=D5 10:01
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: dandan.bi@intel.com; eric.dong@intel.com; gechao
> <gechao@greatwall.com.cn>
> =D6=F7=CC=E2: [edk2-devel] [PATCH] MdeModulePkg: Correct the variable =
name.
>=20
> From: gechao <gechao@greatwall.com.cn>
>=20
> Signed-off-by: gechao <gechao@greatwall.com.cn>
> ---
>  .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 =
++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>=20
> diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> index 3b034a1c82..a3898dc2ec 100644
> --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> @@ -372,7 +372,7 @@ GetWidth (
>  {
>=20
>    CHAR16                        *String;
>=20
>    UINTN                         Size;
>=20
> -  EFI_IFR_TEXT                  *TestOp;
>=20
> +  EFI_IFR_TEXT                  *TextOp;
>=20
>    UINT16                        ReturnWidth;
>=20
>    FORM_DISPLAY_ENGINE_STATEMENT *Statement;
>=20
>=20
>=20
> @@ -394,9 +394,9 @@ GetWidth (
>    // See if the second text parameter is really NULL
>=20
>    //
>=20
>    if (Statement->OpCode->OpCode =3D=3D EFI_IFR_TEXT_OP) {
>=20
> -    TestOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
>=20
> -    if (TestOp->TextTwo !=3D 0) {
>=20
> -      String =3D GetToken (TestOp->TextTwo, gFormData->HiiHandle);
>=20
> +    TextOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
>=20
> +    if (TextOp->TextTwo !=3D 0) {
>=20
> +      String =3D GetToken (TextOp->TextTwo, gFormData->HiiHandle);
>=20
>        Size   =3D StrLen (String);
>=20
>        FreePool (String);
>=20
>      }
>=20
> @@ -2166,7 +2166,7 @@ HasOptionString (
>    FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
>=20
>    CHAR16                          *String;
>=20
>    UINTN                           Size;
>=20
> -  EFI_IFR_TEXT                    *TestOp;
>=20
> +  EFI_IFR_TEXT                    *TextOp;
>=20
>=20
>=20
>    Size =3D 0;
>=20
>    Statement =3D MenuOption->ThisTag;
>=20
> @@ -2175,9 +2175,9 @@ HasOptionString (
>    // See if the second text parameter is really NULL
>=20
>    //
>=20
>    if (Statement->OpCode->OpCode =3D=3D EFI_IFR_TEXT_OP) {
>=20
> -    TestOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
>=20
> -    if (TestOp->TextTwo !=3D 0) {
>=20
> -      String =3D GetToken (TestOp->TextTwo, gFormData->HiiHandle);
>=20
> +    TextOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
>=20
> +    if (TextOp->TextTwo !=3D 0) {
>=20
> +      String =3D GetToken (TextOp->TextTwo, gFormData->HiiHandle);
>=20
>        Size   =3D StrLen (String);
>=20
>        FreePool (String);
>=20
>      }
>=20
> --
> 2.25.1
>=20
>=20
>=20
> -=3D-=3D-=3D-=3D-=3D-=3D
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#66921): =
https://edk2.groups.io/g/devel/message/66921
> Mute This Topic: https://groups.io/mt/78003643/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D
>=20