From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Leif Lindholm'" <leif@nuviainc.com>, <devel@edk2.groups.io>
Cc: <rebecca@nuviainc.com>,
"'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
"'Laszlo Ersek'" <lersek@redhat.com>
Subject: 回复: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
Date: Fri, 4 Dec 2020 09:24:16 +0800 [thread overview]
Message-ID: <009701d6c9dc$2ea03e10$8be0ba30$@byosoft.com.cn> (raw)
In-Reply-To: <20201203112408.GP1664@vanye>
Leif:
I don't mean to object the incompatible change. I understand that the field name is changed for the readable source code. So, I propose to add comments for it to achieve the same goal.
Thanks
Liming
> -----邮件原件-----
> 发件人: Leif Lindholm <leif@nuviainc.com>
> 发送时间: 2020年12月3日 19:24
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: rebecca@nuviainc.com; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>;
> 'Laszlo Ersek' <lersek@redhat.com>
> 主题: Re: 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
>
> Liming,
>
> These aren't randomly named fields, they are incorrect representations
> of an industry standard.
>
> We are now in the period just after stable tag, breaking platforms is
> perfectly acceptable.
>
> Also, we just happily broke all known platforms during soft freeze by
> merging the VariablePolicy set.
>
> /
> Leif
>
> On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote:
> > Rebecca:
> > I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in
> edk2-platforms.
> > There are many platform SmbiosDxe driver to depend on them.
> > So, this change impacts widely. This change is just to rename field name.
> > There is no real functionality change. I suggest to add comments for those
> > typo fields instead of changing them.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+68193+4905953+8761045@groups.io
> > > <bounce+27952+68193+4905953+8761045@groups.io> 代表 Rebecca
> Cran
> > > 发送时间: 2020年12月3日 3:03
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Zhiguang Liu <zhiguang.liu@intel.com>
> > > 主题: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h
> > >
> > > Since the edk2-stable202011 tag has been created, I'm resubmitting the
> > > SmBios.h typo fixes.
> > >
> > > Rebecca Cran (3):
> > > MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> > > struct
> > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field
> > > ProcessorManufacturer
> > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field
> > > FirmwareVersion
> > >
> > > MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++----------
> > > 1 file changed, 13 insertions(+), 13 deletions(-)
> > >
> > > --
> > > 2.26.2
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
> >
next prev parent reply other threads:[~2020-12-04 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 19:03 [PATCH 0/3] MdePkg: fix typos in SmBios.h Rebecca Cran
2020-12-02 19:03 ` [PATCH 1/3] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct Rebecca Cran
2020-12-02 19:03 ` [PATCH 2/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field ProcessorManufacturer Rebecca Cran
2020-12-02 19:03 ` [PATCH 3/3] MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field FirmwareVersion Rebecca Cran
2020-12-03 1:18 ` 回复: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in SmBios.h gaoliming
2020-12-03 1:29 ` Rebecca Cran
2020-12-03 11:24 ` Leif Lindholm
2020-12-04 1:24 ` gaoliming [this message]
2020-12-04 3:03 ` Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009701d6c9dc$2ea03e10$8be0ba30$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox