From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.7773.1607045058254577948 for ; Thu, 03 Dec 2020 17:24:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 04 Dec 2020 09:24:15 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Leif Lindholm'" , Cc: , "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Laszlo Ersek'" References: <20201202190325.20310-1-rebecca@nuviainc.com> <005b01d6c912$2d94d050$88be70f0$@byosoft.com.cn> <20201203112408.GP1664@vanye> In-Reply-To: <20201203112408.GP1664@vanye> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggMC8zXSBNZGVQa2c6IGZpeCB0eXBvcyBpbiBTbUJpb3MuaA==?= Date: Fri, 4 Dec 2020 09:24:16 +0800 Message-ID: <009701d6c9dc$2ea03e10$8be0ba30$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEuNt8h2YSciZHwBWYxD3M6d6HYFAG4tn5zAfjzA8arGbnvcA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Leif: I don't mean to object the incompatible change. I understand that the fi= eld name is changed for the readable source code. So, I propose to add comm= ents for it to achieve the same goal. Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Leif Lindholm > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=883=E6=97=A5= 19:24 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com= .cn > =E6=8A=84=E9=80=81: rebecca@nuviainc.com; 'Michael D Kinney' > ; 'Zhiguang Liu' ; > 'Laszlo Ersek' > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH 0/3] Mde= Pkg: fix typos in SmBios.h >=20 > Liming, >=20 > These aren't randomly named fields, they are incorrect representations > of an industry standard. >=20 > We are now in the period just after stable tag, breaking platforms is > perfectly acceptable. >=20 > Also, we just happily broke all known platforms during soft freeze by > merging the VariablePolicy set. >=20 > / > Leif >=20 > On Thu, Dec 03, 2020 at 09:18:16 +0800, gaoliming wrote: > > Rebecca: > > I search SMBIOS_TABLE_TYPE4 and SMBIOS_TABLE_TYPE17 in > edk2-platforms. > > There are many platform SmbiosDxe driver to depend on them. > > So, this change impacts widely. This change is just to rename field = name. > > There is no real functionality change. I suggest to add comments for t= hose > > typo fields instead of changing them. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+68193+4905953+8761045@grou= ps.io > > > =E4=BB=A3=E8=A1=A8 Re= becca > Cran > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B412=E6=9C=883=E6= =97=A5 3:03 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: Rebecca Cran ; Michael D K= inney > > > ; Liming Gao ; > > > Zhiguang Liu > > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 0/3] MdePkg: fix typos in Sm= Bios.h > > > > > > Since the edk2-stable202011 tag has been created, I'm resubmitting t= he > > > SmBios.h typo fixes. > > > > > > Rebecca Cran (3): > > > MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS > > > struct > > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE4 field > > > ProcessorManufacturer > > > MdePkg: Fix typo in SmBios.h SMBIOS_TABLE_TYPE17 field > > > FirmwareVersion > > > > > > MdePkg/Include/IndustryStandard/SmBios.h | 26 ++++++++++---------- > > > 1 file changed, 13 insertions(+), 13 deletions(-) > > > > > > -- > > > 2.26.2 > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > >