From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.404.1616117367244385081 for ; Thu, 18 Mar 2021 18:29:27 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 19 Mar 2021 09:29:24 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Ard Biesheuvel'" Cc: "'Ard Biesheuvel'" , "'Leif Lindholm'" References: <20210316181038.1413-1-kuqin12@gmail.com> <166CE5173C17A517.7039@groups.io> <95dbf461-6f84-b3f5-3a49-31bf3d0d6dad@gmail.com> In-Reply-To: <95dbf461-6f84-b3f5-3a49-31bf3d0d6dad@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zXVtQQVRDSCB2MiA1LzVdIFNvY2lvbmV4dDogRGV2ZWxvcGVyQm94IERTQyBGaWxlOiBBZGRlZCBsaWJyYXJ5IGZvciBWYXJpYWJsZVNtbVJ1bnRpbWVEeGU=?= Date: Fri, 19 Mar 2021 09:29:25 +0800 Message-ID: <009701d71c5f$4c8d52c0$e5a7f840$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQDuzoPGT8F9oClqJbDiuIQ52iPYPwEpUmLcAhkBXYwCXe/NwQFfC0oCrCMlz8A= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Kun: Acked-by: means the maintainer agrees this change, but no time for detai= l code review. Based on current develop process, with Acked-by, the patch c= an also be merged.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Kun Qin > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B43=E6=9C=8819=E6=97=A5= 2:26 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Ard Biesheuvel > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel ; > Leif Lindholm > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Soci= onext: > DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe >=20 > Hi Ard, >=20 > Thanks for providing the tag. For my own learning purpose, could you > please let me know how I can get a "reviewed-by" tag for this change? > Should I add more reviewers than package maintainers listed on > "Maintainers.txt"? >=20 > Thanks for the help. >=20 > Regards, > Kun >=20 > On 03/18/2021 11:14, Ard Biesheuvel wrote: > > On Thu, 18 Mar 2021 at 19:07, Kun Qin wrote: > >> > >> Hi Ard/Leif, > >> > >> Could you please review the change and let me know if you have any > >> feedback when there is chance? I can drop the patch if this package i= s > >> not supported/maintained any more. Please let me know how you would > like > >> to proceed. > >> > >> Thanks in advance. > >> > >> Regards, > >> Kun > >> > >> On 03/16/2021 11:10, Kun Qin via groups.io wrote: > >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3250 > >>> > >>> This change added NULL MmUnblockMemoryLib instance in > DeveloperBox.dsc to > >>> resolve new dependency by VariableSmmRuntimeDxe. The library > interface > >>> is consumed by variable module to better support variable runtime ca= che > >>> feature. > >>> > >>> Cc: Ard Biesheuvel > >>> Cc: Leif Lindholm > >>> > >>> Signed-off-by: Kun Qin > > > > Acked-by: Ard Biesheuvel > > > >>> --- > >>> > >>> Notes: > >>> v2: > >>> - No review, no change. > >>> > >>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> index 0a11b796cca5..acaa4cd90fc5 100644 > >>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > >>> @@ -49,6 +49,8 @@ [LibraryClasses] > >>> > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tpm > MeasurementLibNull.inf > >>> !endif > >>> > >>> + > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc > kMemoryLibNull.inf > >>> + > >>> [LibraryClasses.common.SEC] > >>> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > >>> > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > >>> >=20 >=20 >=20 >=20