[edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib

[edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib

[Kun Qin]

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/72645

v2 patches mainly focus on feedback for reviewed commits in v1 patches,
including:
a. Adding "Reviewed-by" tags for applicable patch;
b. Updating cc list include critical reviewers;

Patch v2 branch: https://github.com/kuqin12/edk2-platforms/tree/unblock_dependency_v2

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>

Kun Qin (5):
  MinPlatformPkg: CoreCommonLib: Added new library for
    VariableSmmRuntimeDxe
  MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
    separation
  QuarkPlatformPkg: Quark DSC File: Added new library for
    VariableSmmRuntimeDxe
  Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
    VariableSmmRuntimeDxe
  Socionext: DeveloperBox DSC File: Added library for
    VariableSmmRuntimeDxe

 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc           | 1 +
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
 Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3 ++-
 Platform/Intel/QuarkPlatformPkg/Quark.dsc                             | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                  | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                   | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                      | 2 ++
 7 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.30.0.windows.1

[edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in dsc files of
CoreCommonLib to resolve newly introduced dependency. The library
interface is consumed by VariableSmmRuntimeDxe to better support variable
runtime cache feature.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---

Notes:
    v2:
    - Added reviewed-by tag [Liming]

 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index cb40e111b5dd..bcabb797e91a 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -159,6 +159,7 @@ [LibraryClasses.common]
   LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
 
   SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
   SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
-- 
2.30.0.windows.1

[edk2-platforms][PATCH v2 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3251

This change follows the commit that separates the original Tcg2Smm driver
into Tcg2Acpi and Tcg2 MM based on functionality in DXE and MM. The new
Tcg2Acpi driver now will be responsible for patching and publishing ACPI
table from DXE, and Tcg2 MM driver will be handling runtime MMI requests
from ACPI calls.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---

Notes:
    v2:
    - Added reviewed-by tag [Liming]

 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc          | 1 +
 Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
index a76a9bf5fdf9..c2ade240f314 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
@@ -155,6 +155,7 @@
       NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf
   }
   SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+  SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
   SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
 !endif
 
diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
index 45dda7ea0a91..3edc878e173b 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf
@@ -14,6 +14,7 @@
 !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable == TRUE
 INF  SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.inf
 INF  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf
-INF  RuleOverride = DRIVER_ACPITABLE SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+INF  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
+INF  RuleOverride = DRIVER_ACPITABLE SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf
 INF  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf
 !endif
-- 
2.30.0.windows.1

[edk2-platforms][PATCH v2 3/5] QuarkPlatformPkg: Quark DSC File: Added new library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in Quark.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Kelly Steele <kelly.steele@intel.com>
---

Notes:
    v2:
    - Added reviewed-by tag [Kelly]

 Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
index e29c7465b1e4..c58da58348e3 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
@@ -146,6 +146,7 @@ [LibraryClasses]
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
   ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
-- 
2.30.0.windows.1

[edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
file to resolve new dependency by VariableSmmRuntimeDxe. The library
interface is consumed by variable module to better support variable
runtime cache feature.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - Added Michael K. to cc list [Zailiang]

 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 409f31c982d7..33e93b74800c 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -311,6 +311,7 @@ [LibraryClasses.IA32]
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
   EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
   HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
 [LibraryClasses.IA32.DXE_DRIVER]
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 38bd825c8bdc..f7a876353649 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -313,6 +313,7 @@ [LibraryClasses.X64]
   LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
   EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
   HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
 
 [LibraryClasses.X64.DXE_DRIVER]
   DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
-- 
2.30.0.windows.1

[edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
---

Notes:
    v2:
    - No review, no change.

 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 0a11b796cca5..acaa4cd90fc5 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -49,6 +49,8 @@ [LibraryClasses]
   TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
 !endif
 
+  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
+
 [LibraryClasses.common.SEC]
   PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
-- 
2.30.0.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

Hi Kun,
Since the first two changes about MinPlatformPkg already got reviewed, can we first check them in?

Thanks
Zhiguang

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> Sent: Wednesday, March 17, 2021 2:11 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in dsc files of
> CoreCommonLib to resolve newly introduced dependency. The library
> interface is consumed by VariableSmmRuntimeDxe to better support
> variable runtime cache feature.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> 
> Notes:
>     v2:
>     - Added reviewed-by tag [Liming]
> 
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index cb40e111b5dd..bcabb797e91a 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -159,6 +159,7 @@ [LibraryClasses.common]
>    LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> 
>    SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> +
> +
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> ckMemoryLi
> + bNull.inf
> 
>    SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
> 
> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi
> b.inf
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Zhiguang,

I do not mind check the reviewed patches (the first 3 changes, 
specifically) in first. I have not done this before. How you want to 
proceed in that case?

Regards,
Kun

On 03/17/2021 00:52, Liu, Zhiguang wrote:
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> Hi Kun,
> Since the first two changes about MinPlatformPkg already got reviewed, can we first check them in?
> 
> Thanks
> Zhiguang
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
>> Sent: Wednesday, March 17, 2021 2:11 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
>> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>
>> This change added NULL MmUnblockMemoryLib instance in dsc files of
>> CoreCommonLib to resolve newly introduced dependency. The library
>> interface is consumed by VariableSmmRuntimeDxe to better support
>> variable runtime cache feature.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>> ---
>>
>> Notes:
>>      v2:
>>      - Added reviewed-by tag [Liming]
>>
>>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> index cb40e111b5dd..bcabb797e91a 100644
>> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> @@ -159,6 +159,7 @@ [LibraryClasses.common]
>>     LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
>>
>>     SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
>> +
>> +
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
>> ckMemoryLi
>> + bNull.inf
>>
>>     SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi
>> b.inf
>> --
>> 2.30.0.windows.1
>>
>>
>>
>> 
>>
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Zhiguang Liu]

Hi Liming, 
Can you help merge the first two patches in this patch set?
If you need, I can provide the patch files.

Hi Kun,
Thanks. Let's see if Liming can help.

Thanks
Zhiguang

> -----Original Message-----
> From: Kun Qin <kuqin12@gmail.com>
> Sent: Wednesday, March 17, 2021 4:11 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> 
> Hi Zhiguang,
> 
> I do not mind check the reviewed patches (the first 3 changes,
> specifically) in first. I have not done this before. How you want to proceed in
> that case?
> 
> Regards,
> Kun
> 
> On 03/17/2021 00:52, Liu, Zhiguang wrote:
> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > Hi Kun,
> > Since the first two changes about MinPlatformPkg already got reviewed,
> can we first check them in?
> >
> > Thanks
> > Zhiguang
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun
> >> Qin
> >> Sent: Wednesday, March 17, 2021 2:11 AM
> >> To: devel@edk2.groups.io
> >> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> >> <nathaniel.l.desimone@intel.com>; Liming Gao
> >> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> >>
> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> >>
> >> This change added NULL MmUnblockMemoryLib instance in dsc files of
> >> CoreCommonLib to resolve newly introduced dependency. The library
> >> interface is consumed by VariableSmmRuntimeDxe to better support
> >> variable runtime cache feature.
> >>
> >> Cc: Chasel Chiu <chasel.chiu@intel.com>
> >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Cc: Eric Dong <eric.dong@intel.com>
> >>
> >> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> >> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >> ---
> >>
> >> Notes:
> >>      v2:
> >>      - Added reviewed-by tag [Liming]
> >>
> >>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git
> >> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> >> index cb40e111b5dd..bcabb797e91a 100644
> >> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> >> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> >> @@ -159,6 +159,7 @@ [LibraryClasses.common]
> >>     LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> >>
> >>     SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> >> +
> >> +
> >>
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> >> ckMemoryLi
> >> + bNull.inf
> >>
> >>     SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
> >>
> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePoli
> >> VariablePolicyLib|cyLi
> >> b.inf
> >> --
> >> 2.30.0.windows.1
> >>
> >>
> >>
> >> 
> >>
> >

回复: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[gaoliming]

Zhiguang:
  Yes. I can merge part of the patch set, because each patch is for the different platform. 

  I will wait for one more day for the patch review, and merge the patch tomorrow for those passed code review. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Liu, Zhiguang <zhiguang.liu@intel.com>
> 发送时间: 2021年3月17日 22:33
> 收件人: Kun Qin <kuqin12@gmail.com>; devel@edk2.groups.io; Liming Gao
> <gaoliming@byosoft.com.cn>
> 抄送: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com>
> 主题: RE: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> 
> Hi Liming,
> Can you help merge the first two patches in this patch set?
> If you need, I can provide the patch files.
> 
> Hi Kun,
> Thanks. Let's see if Liming can help.
> 
> Thanks
> Zhiguang
> 
> > -----Original Message-----
> > From: Kun Qin <kuqin12@gmail.com>
> > Sent: Wednesday, March 17, 2021 4:11 PM
> > To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> > CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> >
> > Hi Zhiguang,
> >
> > I do not mind check the reviewed patches (the first 3 changes,
> > specifically) in first. I have not done this before. How you want to proceed in
> > that case?
> >
> > Regards,
> > Kun
> >
> > On 03/17/2021 00:52, Liu, Zhiguang wrote:
> > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > Hi Kun,
> > > Since the first two changes about MinPlatformPkg already got reviewed,
> > can we first check them in?
> > >
> > > Thanks
> > > Zhiguang
> > >
> > >> -----Original Message-----
> > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun
> > >> Qin
> > >> Sent: Wednesday, March 17, 2021 2:11 AM
> > >> To: devel@edk2.groups.io
> > >> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > >> <nathaniel.l.desimone@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> > >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> > >>
> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> > >>
> > >> This change added NULL MmUnblockMemoryLib instance in dsc files of
> > >> CoreCommonLib to resolve newly introduced dependency. The library
> > >> interface is consumed by VariableSmmRuntimeDxe to better support
> > >> variable runtime cache feature.
> > >>
> > >> Cc: Chasel Chiu <chasel.chiu@intel.com>
> > >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >> Cc: Eric Dong <eric.dong@intel.com>
> > >>
> > >> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> > >> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > >> ---
> > >>
> > >> Notes:
> > >>      v2:
> > >>      - Added reviewed-by tag [Liming]
> > >>
> > >>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1
> +
> > >>   1 file changed, 1 insertion(+)
> > >>
> > >> diff --git
> > >> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > >> index cb40e111b5dd..bcabb797e91a 100644
> > >> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > >> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > >> @@ -159,6 +159,7 @@ [LibraryClasses.common]
> > >>
> LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> > >>
> > >>     SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> > >> +
> > >> +
> > >>
> >
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> > >> ckMemoryLi
> > >> + bNull.inf
> > >>
> > >>
> SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
> > >>
> > >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePoli
> > >> VariablePolicyLib|cyLi
> > >> b.inf
> > >> --
> > >> 2.30.0.windows.1
> > >>
> > >>
> > >>
> > >> 
> > >>
> > >

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

[Zhiguang Liu]

Thanks Liming. This helps a lot

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Thursday, March 18, 2021 1:01 PM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; 'Kun Qin' <kuqin12@gmail.com>;
> devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: 回复: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> 
> Zhiguang:
>   Yes. I can merge part of the patch set, because each patch is for the
> different platform.
> 
>   I will wait for one more day for the patch review, and merge the patch
> tomorrow for those passed code review.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Liu, Zhiguang <zhiguang.liu@intel.com>
> > 发送时间: 2021年3月17日 22:33
> > 收件人: Kun Qin <kuqin12@gmail.com>; devel@edk2.groups.io; Liming
> Gao
> > <gaoliming@byosoft.com.cn>
> > 抄送: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Dong, Eric <eric.dong@intel.com>
> > 主题: RE: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg:
> > CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> >
> > Hi Liming,
> > Can you help merge the first two patches in this patch set?
> > If you need, I can provide the patch files.
> >
> > Hi Kun,
> > Thanks. Let's see if Liming can help.
> >
> > Thanks
> > Zhiguang
> >
> > > -----Original Message-----
> > > From: Kun Qin <kuqin12@gmail.com>
> > > Sent: Wednesday, March 17, 2021 4:11 PM
> > > To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
> > > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > > <nathaniel.l.desimone@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5]
> MinPlatformPkg:
> > > CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> > >
> > > Hi Zhiguang,
> > >
> > > I do not mind check the reviewed patches (the first 3 changes,
> > > specifically) in first. I have not done this before. How you want to
> > > proceed in that case?
> > >
> > > Regards,
> > > Kun
> > >
> > > On 03/17/2021 00:52, Liu, Zhiguang wrote:
> > > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > >
> > > > Hi Kun,
> > > > Since the first two changes about MinPlatformPkg already got
> > > > reviewed,
> > > can we first check them in?
> > > >
> > > > Thanks
> > > > Zhiguang
> > > >
> > > >> -----Original Message-----
> > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > >> Kun Qin
> > > >> Sent: Wednesday, March 17, 2021 2:11 AM
> > > >> To: devel@edk2.groups.io
> > > >> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > > >> <nathaniel.l.desimone@intel.com>; Liming Gao
> > > >> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> > > >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5]
> MinPlatformPkg:
> > > >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe
> > > >>
> > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> > > >>
> > > >> This change added NULL MmUnblockMemoryLib instance in dsc files
> > > >> of CoreCommonLib to resolve newly introduced dependency. The
> > > >> library interface is consumed by VariableSmmRuntimeDxe to better
> > > >> support variable runtime cache feature.
> > > >>
> > > >> Cc: Chasel Chiu <chasel.chiu@intel.com>
> > > >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > >> Cc: Eric Dong <eric.dong@intel.com>
> > > >>
> > > >> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> > > >> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > > >> ---
> > > >>
> > > >> Notes:
> > > >>      v2:
> > > >>      - Added reviewed-by tag [Liming]
> > > >>
> > > >>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1
> > +
> > > >>   1 file changed, 1 insertion(+)
> > > >>
> > > >> diff --git
> > > >> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > > >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > > >> index cb40e111b5dd..bcabb797e91a 100644
> > > >> ---
> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > > >> +++
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > > >> @@ -159,6 +159,7 @@ [LibraryClasses.common]
> > > >>
> > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf
> > > >>
> > > >>     SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> > > >> +
> > > >> +
> > > >>
> > >
> >
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> > > >> ckMemoryLi
> > > >> + bNull.inf
> > > >>
> > > >>
> > SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
> > > >>
> > > >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/Variable
> > > >> VariablePolicyLib|Poli
> > > >> VariablePolicyLib|cyLi
> > > >> b.inf
> > > >> --
> > > >> 2.30.0.windows.1
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Michael,

Could you please review this change and provide feedback? Zailing would 
prefer to have your vote before finalizing the change.

Any input is appreciated.

Regards,
Kun

On 03/16/2021 11:10, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> interface is consumed by variable module to better support variable
> runtime cache feature.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
> 
> Notes:
>      v2:
>      - Added Michael K. to cc list [Zailiang]
> 
>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 409f31c982d7..33e93b74800c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>   
>   [LibraryClasses.IA32.DXE_DRIVER]
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 38bd825c8bdc..f7a876353649 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>   
>   [LibraryClasses.X64.DXE_DRIVER]
>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Ard/Leif,

Could you please review the change and let me know if you have any 
feedback when there is chance? I can drop the patch if this package is 
not supported/maintained any more. Please let me know how you would like 
to proceed.

Thanks in advance.

Regards,
Kun

On 03/16/2021 11:10, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
> resolve new dependency by VariableSmmRuntimeDxe. The library interface
> is consumed by variable module to better support variable runtime cache
> feature.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
> 
> Notes:
>      v2:
>      - No review, no change.
> 
>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 0a11b796cca5..acaa4cd90fc5 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -49,6 +49,8 @@ [LibraryClasses]
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>   !endif
>   
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> +
>   [LibraryClasses.common.SEC]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Ard Biesheuvel]

On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqin12@gmail.com> wrote:
>
> Hi Ard/Leif,
>
> Could you please review the change and let me know if you have any
> feedback when there is chance? I can drop the patch if this package is
> not supported/maintained any more. Please let me know how you would like
> to proceed.
>
> Thanks in advance.
>
> Regards,
> Kun
>
> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> >
> > This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
> > resolve new dependency by VariableSmmRuntimeDxe. The library interface
> > is consumed by variable module to better support variable runtime cache
> > feature.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> >
> > Signed-off-by: Kun Qin <kuqin12@gmail.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> > ---
> >
> > Notes:
> >      v2:
> >      - No review, no change.
> >
> >   Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > index 0a11b796cca5..acaa4cd90fc5 100644
> > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> > @@ -49,6 +49,8 @@ [LibraryClasses]
> >     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> >   !endif
> >
> > +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> > +
> >   [LibraryClasses.common.SEC]
> >     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >     BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> >

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Ard,

Thanks for providing the tag. For my own learning purpose, could you 
please let me know how I can get a "reviewed-by" tag for this change? 
Should I add more reviewers than package maintainers listed on 
"Maintainers.txt"?

Thanks for the help.

Regards,
Kun

On 03/18/2021 11:14, Ard Biesheuvel wrote:
> On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqin12@gmail.com> wrote:
>>
>> Hi Ard/Leif,
>>
>> Could you please review the change and let me know if you have any
>> feedback when there is chance? I can drop the patch if this package is
>> not supported/maintained any more. Please let me know how you would like
>> to proceed.
>>
>> Thanks in advance.
>>
>> Regards,
>> Kun
>>
>> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>>
>>> This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
>>> resolve new dependency by VariableSmmRuntimeDxe. The library interface
>>> is consumed by variable module to better support variable runtime cache
>>> feature.
>>>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>
>>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> 
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> 
>>> ---
>>>
>>> Notes:
>>>       v2:
>>>       - No review, no change.
>>>
>>>    Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>> index 0a11b796cca5..acaa4cd90fc5 100644
>>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>> @@ -49,6 +49,8 @@ [LibraryClasses]
>>>      TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>>    !endif
>>>
>>> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>>> +
>>>    [LibraryClasses.common.SEC]
>>>      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>      BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>>>

回复: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[gaoliming]

Kun:
  Acked-by: means the maintainer agrees this change, but no time for detail code review. Based on current develop process, with Acked-by, the patch can also be merged. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
> 发送时间: 2021年3月19日 2:26
> 收件人: Ard Biesheuvel <ardb@kernel.org>
> 抄送: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Leif Lindholm <leif@nuviainc.com>
> 主题: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext:
> DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe
> 
> Hi Ard,
> 
> Thanks for providing the tag. For my own learning purpose, could you
> please let me know how I can get a "reviewed-by" tag for this change?
> Should I add more reviewers than package maintainers listed on
> "Maintainers.txt"?
> 
> Thanks for the help.
> 
> Regards,
> Kun
> 
> On 03/18/2021 11:14, Ard Biesheuvel wrote:
> > On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqin12@gmail.com> wrote:
> >>
> >> Hi Ard/Leif,
> >>
> >> Could you please review the change and let me know if you have any
> >> feedback when there is chance? I can drop the patch if this package is
> >> not supported/maintained any more. Please let me know how you would
> like
> >> to proceed.
> >>
> >> Thanks in advance.
> >>
> >> Regards,
> >> Kun
> >>
> >> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> >>>
> >>> This change added NULL MmUnblockMemoryLib instance in
> DeveloperBox.dsc to
> >>> resolve new dependency by VariableSmmRuntimeDxe. The library
> interface
> >>> is consumed by variable module to better support variable runtime cache
> >>> feature.
> >>>
> >>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> >>> Cc: Leif Lindholm <leif@nuviainc.com>
> >>>
> >>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> >
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> >
> >>> ---
> >>>
> >>> Notes:
> >>>       v2:
> >>>       - No review, no change.
> >>>
> >>>    Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
> >>>    1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> >>> index 0a11b796cca5..acaa4cd90fc5 100644
> >>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> >>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> >>> @@ -49,6 +49,8 @@ [LibraryClasses]
> >>>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tpm
> MeasurementLibNull.inf
> >>>    !endif
> >>>
> >>> +
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc
> kMemoryLibNull.inf
> >>> +
> >>>    [LibraryClasses.common.SEC]
> >>>      PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >>>
> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> >>>
> 
> 
> 
> 

Re: 回复: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Liming,

Thanks for explanation.

Regards,
Kun

On 03/18/2021 18:29, gaoliming wrote:
> Kun:
>    Acked-by: means the maintainer agrees this change, but no time for detail code review. Based on current develop process, with Acked-by, the patch can also be merged.
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
>> 发送时间: 2021年3月19日 2:26
>> 收件人: Ard Biesheuvel <ardb@kernel.org>
>> 抄送: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
>> Leif Lindholm <leif@nuviainc.com>
>> 主题: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext:
>> DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe
>>
>> Hi Ard,
>>
>> Thanks for providing the tag. For my own learning purpose, could you
>> please let me know how I can get a "reviewed-by" tag for this change?
>> Should I add more reviewers than package maintainers listed on
>> "Maintainers.txt"?
>>
>> Thanks for the help.
>>
>> Regards,
>> Kun
>>
>> On 03/18/2021 11:14, Ard Biesheuvel wrote:
>>> On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqin12@gmail.com> wrote:
>>>>
>>>> Hi Ard/Leif,
>>>>
>>>> Could you please review the change and let me know if you have any
>>>> feedback when there is chance? I can drop the patch if this package is
>>>> not supported/maintained any more. Please let me know how you would
>> like
>>>> to proceed.
>>>>
>>>> Thanks in advance.
>>>>
>>>> Regards,
>>>> Kun
>>>>
>>>> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
>>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>>>>
>>>>> This change added NULL MmUnblockMemoryLib instance in
>> DeveloperBox.dsc to
>>>>> resolve new dependency by VariableSmmRuntimeDxe. The library
>> interface
>>>>> is consumed by variable module to better support variable runtime cache
>>>>> feature.
>>>>>
>>>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>>>
>>>>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>>>
>>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>>>
>>>>> ---
>>>>>
>>>>> Notes:
>>>>>        v2:
>>>>>        - No review, no change.
>>>>>
>>>>>     Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
>>>>>     1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>> b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>>>> index 0a11b796cca5..acaa4cd90fc5 100644
>>>>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>>>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>>>>> @@ -49,6 +49,8 @@ [LibraryClasses]
>>>>>
>> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tpm
>> MeasurementLibNull.inf
>>>>>     !endif
>>>>>
>>>>> +
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnbloc
>> kMemoryLibNull.inf
>>>>> +
>>>>>     [LibraryClasses.common.SEC]
>>>>>       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>>>
>> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
>>>>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 
> 
> 

回复: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib

[gaoliming]

Hi, all
  I push the patch 1, 2, 3, and 5 on
2620e05c6fade20ef5e1ba69280d09f9e2b3eff6..
aa3f6fd542e99dde4206537b095f1a2201275e75

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
> 发送时间: 2021年3月17日 2:11
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Kelly Steele <kelly.steele@intel.com>;
> Zailiang Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>
> 主题: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from
> MmUnblockMemoryLib
> 
> This patch series is a follow up of previous submission:
> https://edk2.groups.io/g/devel/message/72645
> 
> v2 patches mainly focus on feedback for reviewed commits in v1 patches,
> including:
> a. Adding "Reviewed-by" tags for applicable patch;
> b. Updating cc list include critical reviewers;
> 
> Patch v2 branch:
> https://github.com/kuqin12/edk2-platforms/tree/unblock_dependency_v2
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Kun Qin (5):
>   MinPlatformPkg: CoreCommonLib: Added new library for
>     VariableSmmRuntimeDxe
>   MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
>     separation
>   QuarkPlatformPkg: Quark DSC File: Added new library for
>     VariableSmmRuntimeDxe
>   Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
>     VariableSmmRuntimeDxe
>   Socionext: DeveloperBox DSC File: Added library for
>     VariableSmmRuntimeDxe
> 
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
> | 1 +
>  Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3
> ++-
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc
> | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> | 2 ++
>  7 files changed, 9 insertions(+), 1 deletion(-)
> 
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 

Re: 回复: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib

[Kun Qin]

Thanks a lot for the help, Liming!

Regards,
Kun

On 03/18/2021 18:44, gaoliming wrote:
> Hi, all
>    I push the patch 1, 2, 3, and 5 on
> 2620e05c6fade20ef5e1ba69280d09f9e2b3eff6..
> aa3f6fd542e99dde4206537b095f1a2201275e75
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
>> 发送时间: 2021年3月17日 2:11
>> 收件人: devel@edk2.groups.io
>> 抄送: Chasel Chiu <chasel.chiu@intel.com>; Nate DeSimone
>> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Eric Dong <eric.dong@intel.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Kelly Steele <kelly.steele@intel.com>;
>> Zailiang Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Ard
>> Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>
>> 主题: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from
>> MmUnblockMemoryLib
>>
>> This patch series is a follow up of previous submission:
>> https://edk2.groups.io/g/devel/message/72645
>>
>> v2 patches mainly focus on feedback for reviewed commits in v1 patches,
>> including:
>> a. Adding "Reviewed-by" tags for applicable patch;
>> b. Updating cc list include critical reviewers;
>>
>> Patch v2 branch:
>> https://github.com/kuqin12/edk2-platforms/tree/unblock_dependency_v2
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>>
>> Kun Qin (5):
>>    MinPlatformPkg: CoreCommonLib: Added new library for
>>      VariableSmmRuntimeDxe
>>    MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after
>>      separation
>>    QuarkPlatformPkg: Quark DSC File: Added new library for
>>      VariableSmmRuntimeDxe
>>    Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
>>      VariableSmmRuntimeDxe
>>    Socionext: DeveloperBox DSC File: Added library for
>>      VariableSmmRuntimeDxe
>>
>>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
>> | 1 +
>>   Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeInclude.dsc
>> | 1 +
>>   Platform/Intel/MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf | 3
>> ++-
>>   Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> | 1 +
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> | 1 +
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> | 1 +
>>   Platform/Socionext/DeveloperBox/DeveloperBox.dsc
>> | 2 ++
>>   7 files changed, 9 insertions(+), 1 deletion(-)
>>
>> --
>> 2.30.0.windows.1
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Hi Michael/Yi/Zailiang,

Would you kindly review the patch below? We can also ignore this one if 
the package is no longer maintained. Please let me know how you would 
like to proceed.

Thanks in advance.

Regards,
Kun

On 03/18/2021 10:51, Kun Qin via groups.io wrote:
> Hi Michael,
> 
> Could you please review this change and provide feedback? Zailing would 
> prefer to have your vote before finalizing the change.
> 
> Any input is appreciated.
> 
> Regards,
> Kun
> 
> On 03/16/2021 11:10, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>
>> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
>> file to resolve new dependency by VariableSmmRuntimeDxe. The library
>> interface is consumed by variable module to better support variable
>> runtime cache feature.
>>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> ---
>>
>> Notes:
>>      v2:
>>      - Added Michael K. to cc list [Zailiang]
>>
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc 
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 409f31c982d7..33e93b74800c 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     
>> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf 
>>
>>     
>> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf 
>>
>> +  
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf 
>>
>>   [LibraryClasses.IA32.DXE_DRIVER]
>>     
>> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc 
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 38bd825c8bdc..f7a876353649 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     
>> EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf 
>>
>>     
>> HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf 
>>
>> +  
>> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf 
>>
>>   [LibraryClasses.X64.DXE_DRIVER]
>>     
>> DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>>
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> Sent: Tuesday, March 16, 2021 11:11 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> VariableSmmRuntimeDxe
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> 
> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> interface is consumed by variable module to better support variable
> runtime cache feature.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
> 
> Notes:
>     v2:
>     - Added Michael K. to cc list [Zailiang]
> 
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 409f31c982d7..33e93b74800c 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>    HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>  [LibraryClasses.IA32.DXE_DRIVER]
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 38bd825c8bdc..f7a876353649 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>    LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>    EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>    HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> 
>  [LibraryClasses.X64.DXE_DRIVER]
>    DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> --
> 2.30.0.windows.1
> 
> 
> 
> 
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Kun Qin]

Thanks for your review, Michael.

Could any maintainer please help merging this specific patch? All other 
patches in this series are already merged into mainline by Liming here 
(https://edk2.groups.io/g/devel/message/73035).

Please let me know if it is preferable for me to send this single patch 
in a v3 after rewriting the commit message with reviewed-by tag.

Thanks in advance!

Regards,
Kun

On 03/30/2021 19:06, Kinney, Michael D wrote:
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Mike
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
>> Sent: Tuesday, March 16, 2021 11:11 AM
>> To: devel@edk2.groups.io
>> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
>> VariableSmmRuntimeDxe
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
>>
>> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
>> file to resolve new dependency by VariableSmmRuntimeDxe. The library
>> interface is consumed by variable module to better support variable
>> runtime cache feature.
>>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>>
>> Signed-off-by: Kun Qin <kuqin12@gmail.com>
>> ---
>>
>> Notes:
>>      v2:
>>      - Added Michael K. to cc list [Zailiang]
>>
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 409f31c982d7..33e93b74800c 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
>> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>>
>>   [LibraryClasses.IA32.DXE_DRIVER]
>>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 38bd825c8bdc..f7a876353649 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
>>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
>>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
>>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
>> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>>
>>   [LibraryClasses.X64.DXE_DRIVER]
>>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
>> --
>> 2.30.0.windows.1
>>
>>
>>
>> 
>>
> 

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

[Michael D Kinney]

Hi Kun,

I will take care of this. 

Thanks,

Mike

> -----Original Message-----
> From: Kun Qin <kuqin12@gmail.com>
> Sent: Thursday, April 1, 2021 1:26 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> VariableSmmRuntimeDxe
> 
> Thanks for your review, Michael.
> 
> Could any maintainer please help merging this specific patch? All other
> patches in this series are already merged into mainline by Liming here
> (https://edk2.groups.io/g/devel/message/73035).
> 
> Please let me know if it is preferable for me to send this single patch
> in a v3 after rewriting the commit message with reviewed-by tag.
> 
> Thanks in advance!
> 
> Regards,
> Kun
> 
> On 03/30/2021 19:06, Kinney, Michael D wrote:
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Mike
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin
> >> Sent: Tuesday, March 16, 2021 11:11 AM
> >> To: devel@edk2.groups.io
> >> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for
> >> VariableSmmRuntimeDxe
> >>
> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250
> >>
> >> This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc
> >> file to resolve new dependency by VariableSmmRuntimeDxe. The library
> >> interface is consumed by variable module to better support variable
> >> runtime cache feature.
> >>
> >> Cc: Zailiang Sun <zailiang.sun@intel.com>
> >> Cc: Yi Qian <yi.qian@intel.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>>
> >> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> >> ---
> >>
> >> Notes:
> >>      v2:
> >>      - Added Michael K. to cc list [Zailiang]
> >>
> >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> >>   Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc  | 1 +
> >>   2 files changed, 2 insertions(+)
> >>
> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> index 409f31c982d7..33e93b74800c 100644
> >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> >> @@ -311,6 +311,7 @@ [LibraryClasses.IA32]
> >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> >>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
> >>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> >>
> >>   [LibraryClasses.IA32.DXE_DRIVER]
> >>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> >> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> index 38bd825c8bdc..f7a876353649 100644
> >> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> >> @@ -313,6 +313,7 @@ [LibraryClasses.X64]
> >>     LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxDxeLib.inf
> >>     EfiRegTableLib|Vlv2TbltDevicePkg/Library/EfiRegTableLib/EfiRegTableLib.inf
> >>     HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
> >> +  MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
> >>
> >>   [LibraryClasses.X64.DXE_DRIVER]
> >>     DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
> >> --
> >> 2.30.0.windows.1
> >>
> >>
> >>
> >> 
> >>
> >