From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Manickavasakam Karpagavinayagam'" <manickavasakamk@ami.com>,
<devel@edk2.groups.io>
Cc: <isaac.w.oram@intel.com>, <nathaniel.l.desimone@intel.com>,
"'Felix Polyudov'" <Felixp@ami.com>,
"'Harikrishna Doppalapudi'" <Harikrishnad@ami.com>,
"'Manish Jha'" <manishj@ami.com>,
"'Zachary Bobroff'" <zacharyb@ami.com>
Subject: 回复: [EXTERNAL] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error
Date: Fri, 18 Jun 2021 09:05:39 +0800 [thread overview]
Message-ID: <009c01d763de$0e343130$2a9c9390$@byosoft.com.cn> (raw)
In-Reply-To: <PH0PR10MB4408E0EE16233A3FC9F0D233BB0E9@PH0PR10MB4408.namprd10.prod.outlook.com>
Manic:
The patch content is good. But, the commit message misses Signed-off-by: Contributor Name <contributor@email.server>
And, please run BaseTools\Scripts\PatchCheck.py to check the commit message format.
Thanks
Liming
> -----邮件原件-----
> 发件人: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
> 发送时间: 2021年6月18日 1:42
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felix
> Polyudov <Felixp@ami.com>; Harikrishna Doppalapudi
> <Harikrishnad@ami.com>; Manish Jha <manishj@ami.com>; Zachary Bobroff
> <zacharyb@ami.com>
> 主题: RE: [EXTERNAL] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro
> and Structure Defintions to resolve the IPMI build error
>
> Liming :
>
> Thank you for the review comments. Created [edk2] [PATCH V2] MdePkg :
> Add IPMI Macro and Structure Defintions to resolve build errors and sent for
> review.
>
> -Manic
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Wednesday, June 16, 2021 10:51 PM
> To: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>;
> devel@edk2.groups.io
> Cc: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felix Polyudov
> <Felixp@ami.com>; Harikrishna Doppalapudi <Harikrishnad@ami.com>;
> Manish Jha <manishj@ami.com>; Zachary Bobroff <zacharyb@ami.com>
> Subject: [EXTERNAL] 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and
> Structure Defintions to resolve the IPMI build error
>
>
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
>
> Manickavasakam:
> Please update this patch. It also includes
> 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch.
>
> The patch should only include the code changes in MdePkg.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: gaoliming <gaoliming@byosoft.com.cn>
> > 发送时间: 2021年6月17日 10:50
> > 收件人: 'manickavasakam karpagavinayagam'
> > <manickavasakamk@ami.com>; 'devel@edk2.groups.io'
> > <devel@edk2.groups.io>
> > 抄送: 'isaac.w.oram@intel.com' <isaac.w.oram@intel.com>;
> > 'nathaniel.l.desimone@intel.com' <nathaniel.l.desimone@intel.com>;
> > 'Felixp@ami.com' <Felixp@ami.com>; 'Harikrishnad@ami.com'
> > <Harikrishnad@ami.com>; 'manishj@ami.com' <manishj@ami.com>;
> > 'zacharyb@ami.com' <zacharyb@ami.com>
> > 主题: 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure
> > Defintions to resolve the IPMI build error
> >
> >
> >
> > > -----邮件原件-----
> > > 发件人: manickavasakam karpagavinayagam
> > <manickavasakamk@ami.com>
> > > 发送时间: 2021年6月12日 5:50
> > > 收件人: devel@edk2.groups.io
> > > 抄送: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com;
> > > Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com;
> > > zacharyb@ami.com; manickavasakamk@ami.com;
> gaoliming@byosoft.com.cn
> > > 主题: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure
> > Defintions
> > > to resolve the IPMI build error
> > >
> > > Build error reported for missing structures
> > > IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
> > > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> > >
> >
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> > > D_UPDATE_MODE
> > > when using
> > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> > >
> > > MdePkg : Rename IPMI Macro and Structure Defintions
> > >
> > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> > >
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> > > IPMI_BMC_IN_FORCED_UPDATE_MODE
> > > ---
> > >
> > > Notes:
> > > V1 :
> > > - Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> > > - EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> > >
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> > > - IPMI_BMC_IN_FORCED_UPDATE_MODE
> > >
> > > 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch |
> > > 61
> > > ++++++++++++++++++++
> > > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> |
> > > 4 ++
> > > MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > |
> > > 18 ++++++
> > > 3 files changed, 83 insertions(+)
> > >
> > > diff --git
> > > a/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
> > > b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
> > > new file mode 100644
> > > index 0000000000..16d149e2d8
> > > --- /dev/null
> > > +++
> b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patc
> > > +++ h
> > > @@ -0,0 +1,61 @@
> > > +From c5e221cfe5d815883f39b71667b6e8f644a27390 Mon Sep 17
> > 00:00:00
> > > 2001
> > > +From: manickavasakam karpagavinayagam
> > <manickavasakamk@ami.com>
> > > +Date: Thu, 10 Jun 2021 14:59:22 -0400
> > > +Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure
> > > +Defintions
> > > to resolve
> > > + the IPMI build error
> > > +
> > > +Build error reported for missing structures
> > > IPMI_SET_BOOT_OPTIONS_RESPONSE,
> > > +EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros
> > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> > >
> >
> +EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORC
> > > ED_UPDATE_MODE
> > > +when using
> > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> > > +---
> > > + MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++
> > > +MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19
> > > +++++++++++++++++++
> > > + 2 files changed, 23 insertions(+)
> > > +
> > > +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > +index 79db55523d..d7cdd3a865 100644
> > > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > +@@ -186,6 +186,10 @@ typedef struct {
> > > + UINT8 ParameterData[0];
> > > + } IPMI_SET_BOOT_OPTIONS_REQUEST;
> > > +
> > > ++typedef struct {
> > > ++ UINT8 CompletionCode:8;
> > > ++} IPMI_SET_BOOT_OPTIONS_RESPONSE;
> > > ++
> > > + //
> > > + // Definitions for Get System Boot options command // diff --git
> > > +a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > +index 2d892dbd5a..1c692cc792 100644
> > > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > +@@ -17,4 +17,23 @@
> > > + // All Firmware commands and their structure definitions to follow
> here
> > > + //
> > > +
> > >
> >
> ++/*--------------------------------------------------------------------
> ++----
> ---------------
> > > -
> > > ++ Definitions for Get BMC Execution Context
> > >
> >
> ++----------------------------------------------------------------------
> ++----
> --------------*
> > > /
> > > ++#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23
> > > ++
> > > ++//
> > > ++// Constants and Structure definitions for "Get Device ID"
> > > ++command to
> > > follow here
> > > ++//
> > > ++typedef struct {
> > > ++ UINT8 CurrentExecutionContext;
> > > ++ UINT8 PartitionPointer;
> > > ++} EFI_IPMI_MSG_GET_BMC_EXEC_RSP;
> > > ++
> > > ++//
> > > ++// Current Execution Context responses //
> > > ++#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10
> > > ++#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11
> > > ++
> > > + #endif
> > > +--
> > > +2.25.0.windows.1
> > > +
> > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > index 79db55523d..d7cdd3a865 100644
> > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> > > @@ -186,6 +186,10 @@ typedef struct {
> > > UINT8 ParameterData[0];
> > >
> > > } IPMI_SET_BOOT_OPTIONS_REQUEST;
> > >
> > >
> > >
> > > +typedef struct {
> > >
> > > + UINT8 CompletionCode:8;
> > >
> > > +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
> > >
> > > +
> > >
> > > //
> > >
> > > // Definitions for Get System Boot options command
> > >
> > > //
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > index 2d892dbd5a..c4cbe2349b 100644
> > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> > > @@ -17,4 +17,22 @@
> > > // All Firmware commands and their structure definitions to follow
> > > here
> > >
> > > //
> > >
> > >
> > >
> > > +//
> >
> ----------------------------------------------------------------------------
> ------------
> > >
> > > +// Definitions for Get BMC Execution Context
> > >
> > > +//
> >
> ----------------------------------------------------------------------------
> ------------
> > >
> > > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23
> > >
> > > +
> > >
> > > +//
> > >
> > > +// Constants and Structure definitions for "Get Device ID" command
> > > +to
> > > follow here
> > >
> > > +//
> > >
> > > +typedef struct {
> > >
> > > + UINT8 CurrentExecutionContext;
> > >
> > > + UINT8 PartitionPointer;
> > >
> > > +} IPMI_MSG_GET_BMC_EXEC_RSP;
> > >
> > > +
> > >
> > > +//
> > >
> > > +// Current Execution Context responses
> > >
> > > +//
> > >
> > > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11
> > >
> > > +
> > >
> > > #endif
> > >
> > > --
> > > 2.25.0.windows.1
> > >
> > >
> > > Please consider the environment before printing this email.
> > >
> > > The information contained in this message may be confidential and
> > > proprietary to American Megatrends (AMI). This communication is
> > intended
> > > to be read only by the individual or entity to whom it is addressed
> > > or
> by their
> > > designee. If the reader of this message is not the intended
> > > recipient,
> you are
> > > on notice that any distribution of this message, in any form, is
> strictly
> > > prohibited. Please promptly notify the sender by reply e-mail or by
> > > telephone at 770-246-8600, and then delete or destroy all copies of
> > > the transmission.
>
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
next prev parent reply other threads:[~2021-06-18 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210611215004.8873-1-manickavasakamk@ami.com>
2021-06-11 22:15 ` [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Oram, Isaac W
2021-06-17 2:50 ` 回复: " gaoliming
2021-06-17 2:51 ` gaoliming
2021-06-17 17:42 ` [EXTERNAL] " manickavasakam karpagavinayagam
2021-06-18 1:05 ` gaoliming [this message]
2021-06-18 15:39 ` manickavasakam karpagavinayagam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009c01d763de$0e343130$2a9c9390$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox