From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1949.1623978358147563200 for ; Thu, 17 Jun 2021 18:05:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 18 Jun 2021 09:05:39 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Manickavasakam Karpagavinayagam'" , Cc: , , "'Felix Polyudov'" , "'Harikrishna Doppalapudi'" , "'Manish Jha'" , "'Zachary Bobroff'" References: <20210611215004.8873-1-manickavasakamk@ami.com> <005f01d76323$a5338060$ef9a8120$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbRVhURVJOQUxdIOWbnuWkjTogW2VkazJdW1BBVENIIFYxXSBNZGVQa2cgOiBBZGQgSVBNSSBNYWNybyBhbmQgU3RydWN0dXJlIERlZmludGlvbnMgdG8gcmVzb2x2ZSB0aGUgSVBNSSBidWlsZCBlcnJvcg==?= Date: Fri, 18 Jun 2021 09:05:39 +0800 Message-ID: <009c01d763de$0e343130$2a9c9390$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQK59nhV0Ohq4KM3aYmee3SBoO4P/gHTNsGbAaetLsmpN/W6wA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Manic: The patch content is good. But, the commit message misses = Signed-off-by: Contributor Name And, please run BaseTools\Scripts\PatchCheck.py to check the commit = message format. Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Manickavasakam Karpagavinayagam = > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B46=E6=9C=8818=E6=97=A5 1:42 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; = devel@edk2.groups.io > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com; = nathaniel.l.desimone@intel.com; Felix > Polyudov ; Harikrishna Doppalapudi > ; Manish Jha ; Zachary Bobroff > > =E4=B8=BB=E9=A2=98: RE: [EXTERNAL] =E5=9B=9E=E5=A4=8D: [edk2][PATCH = V1] MdePkg : Add IPMI Macro > and Structure Defintions to resolve the IPMI build error >=20 > Liming : >=20 > Thank you for the review comments. Created [edk2] [PATCH V2] MdePkg : > Add IPMI Macro and Structure Defintions to resolve build errors and = sent for > review. >=20 > -Manic >=20 > -----Original Message----- > From: gaoliming > Sent: Wednesday, June 16, 2021 10:51 PM > To: Manickavasakam Karpagavinayagam ; > devel@edk2.groups.io > Cc: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felix = Polyudov > ; Harikrishna Doppalapudi ; > Manish Jha ; Zachary Bobroff > Subject: [EXTERNAL] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V1] MdePkg : Add = IPMI Macro and > Structure Defintions to resolve the IPMI build error >=20 >=20 > **CAUTION: The e-mail below is from an external source. Please = exercise > caution before opening attachments, clicking links, or following = guidance.** >=20 > Manickavasakam: > Please update this patch. It also includes > 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch. >=20 > The patch should only include the code changes in MdePkg. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: gaoliming > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B46=E6=9C=8817=E6=97=A5 10:50 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: 'manickavasakam karpagavinayagam' > > ; 'devel@edk2.groups.io' > > > > =E6=8A=84=E9=80=81: 'isaac.w.oram@intel.com' = ; > > 'nathaniel.l.desimone@intel.com' ; > > 'Felixp@ami.com' ; 'Harikrishnad@ami.com' > > ; 'manishj@ami.com' ; > > 'zacharyb@ami.com' > > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2][PATCH V1] MdePkg : = Add IPMI Macro and Structure > > Defintions to resolve the IPMI build error > > > > > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam > > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B46=E6=9C=8812=E6=97=A5 5:50 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com; = nathaniel.l.desimone@intel.com; > > > Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; > > > zacharyb@ami.com; manickavasakamk@ami.com; > gaoliming@byosoft.com.cn > > > =E4=B8=BB=E9=A2=98: [edk2][PATCH V1] MdePkg : Add IPMI Macro and = Structure > > Defintions > > > to resolve the IPMI build error > > > > > > Build error reported for missing structures > > > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > > > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > > > > > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > > > D_UPDATE_MODE > > > when using > > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > > > > > > MdePkg : Rename IPMI Macro and Structure Defintions > > > > > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > > IPMI_BMC_IN_FORCED_UPDATE_MODE > > > --- > > > > > > Notes: > > > V1 : > > > - Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > > - EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > > - IPMI_BMC_IN_FORCED_UPDATE_MODE > > > > > > 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch | > > > 61 > > > ++++++++++++++++++++ > > > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > | > > > 4 ++ > > > MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > | > > > 18 ++++++ > > > 3 files changed, 83 insertions(+) > > > > > > diff --git > > > a/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > > > b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > > > new file mode 100644 > > > index 0000000000..16d149e2d8 > > > --- /dev/null > > > +++ > b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patc > > > +++ h > > > @@ -0,0 +1,61 @@ > > > +From c5e221cfe5d815883f39b71667b6e8f644a27390 Mon Sep 17 > > 00:00:00 > > > 2001 > > > +From: manickavasakam karpagavinayagam > > > > > +Date: Thu, 10 Jun 2021 14:59:22 -0400 > > > +Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure > > > +Defintions > > > to resolve > > > + the IPMI build error > > > + > > > +Build error reported for missing structures > > > IPMI_SET_BOOT_OPTIONS_RESPONSE, > > > +EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros > > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > > > > > +EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORC > > > ED_UPDATE_MODE > > > +when using > > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > > > +--- > > > + MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > > > +MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19 > > > +++++++++++++++++++ > > > + 2 files changed, 23 insertions(+) > > > + > > > +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > +index 79db55523d..d7cdd3a865 100644 > > > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > +@@ -186,6 +186,10 @@ typedef struct { > > > + UINT8 ParameterData[0]; > > > + } IPMI_SET_BOOT_OPTIONS_REQUEST; > > > + > > > ++typedef struct { > > > ++ UINT8 CompletionCode:8; > > > ++} IPMI_SET_BOOT_OPTIONS_RESPONSE; > > > ++ > > > + // > > > + // Definitions for Get System Boot options command // diff = --git > > > +a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > +index 2d892dbd5a..1c692cc792 100644 > > > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > +@@ -17,4 +17,23 @@ > > > + // All Firmware commands and their structure definitions to = follow > here > > > + // > > > + > > > > > > = ++/*-------------------------------------------------------------------- > ++---- > --------------- > > > - > > > ++ Definitions for Get BMC Execution Context > > > > > > = ++---------------------------------------------------------------------- > ++---- > --------------* > > > / > > > ++#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > > > ++ > > > ++// > > > ++// Constants and Structure definitions for "Get Device ID" > > > ++command to > > > follow here > > > ++// > > > ++typedef struct { > > > ++ UINT8 CurrentExecutionContext; > > > ++ UINT8 PartitionPointer; > > > ++} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > > > ++ > > > ++// > > > ++// Current Execution Context responses // > > > ++#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 > > > ++#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > ++ > > > + #endif > > > +-- > > > +2.25.0.windows.1 > > > + > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > index 79db55523d..d7cdd3a865 100644 > > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > > @@ -186,6 +186,10 @@ typedef struct { > > > UINT8 ParameterData[0]; > > > > > > } IPMI_SET_BOOT_OPTIONS_REQUEST; > > > > > > > > > > > > +typedef struct { > > > > > > + UINT8 CompletionCode:8; > > > > > > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; > > > > > > + > > > > > > // > > > > > > // Definitions for Get System Boot options command > > > > > > // > > > > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > index 2d892dbd5a..c4cbe2349b 100644 > > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > > @@ -17,4 +17,22 @@ > > > // All Firmware commands and their structure definitions to = follow > > > here > > > > > > // > > > > > > > > > > > > +// > > > = -------------------------------------------------------------------------= --- > ------------ > > > > > > +// Definitions for Get BMC Execution Context > > > > > > +// > > > = -------------------------------------------------------------------------= --- > ------------ > > > > > > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 > > > > > > + > > > > > > +// > > > > > > +// Constants and Structure definitions for "Get Device ID" = command > > > +to > > > follow here > > > > > > +// > > > > > > +typedef struct { > > > > > > + UINT8 CurrentExecutionContext; > > > > > > + UINT8 PartitionPointer; > > > > > > +} IPMI_MSG_GET_BMC_EXEC_RSP; > > > > > > + > > > > > > +// > > > > > > +// Current Execution Context responses > > > > > > +// > > > > > > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > > > > + > > > > > > #endif > > > > > > -- > > > 2.25.0.windows.1 > > > > > > > > > Please consider the environment before printing this email. > > > > > > The information contained in this message may be confidential and > > > proprietary to American Megatrends (AMI). This communication is > > intended > > > to be read only by the individual or entity to whom it is = addressed > > > or > by their > > > designee. If the reader of this message is not the intended > > > recipient, > you are > > > on notice that any distribution of this message, in any form, is > strictly > > > prohibited. Please promptly notify the sender by reply e-mail or = by > > > telephone at 770-246-8600, and then delete or destroy all copies = of > > > the transmission. >=20 >=20 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is = intended to > be read only by the individual or entity to whom it is addressed or by = their > designee. If the reader of this message is not the intended recipient, = you are > on notice that any distribution of this message, in any form, is = strictly > prohibited. Please promptly notify the sender by reply e-mail or by = telephone > at 770-246-8600, and then delete or destroy all copies of the = transmission.