From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.10475.1678417042721903791 for ; Thu, 09 Mar 2023 18:57:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=MR7FUWNT; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id D270FDDA80F for ; Fri, 10 Mar 2023 10:57:20 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1678417040; bh=s1OthJcNTIgeujnuyj2ktl06JnJ71II8wKO2rIbCJa8=; h=From:To:References:In-Reply-To:Subject:Date; b=MR7FUWNTQ3JJwjUv/9Daf+vvMiWPGsAzEuCXlZq4vIZ8f1jK7NylVOwSn9TKCauw5 uDT7GbB17QEhvUWuoVG0yM7j5clgIEp9b2FHVYsZ8ERmdRDVtYhyX6I9IBTIDpfq0j GFsOTf1p2yEki9sFWfZife0WC0phRXYBpWMJHxP4= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id CD9B0DDA82E for ; Fri, 10 Mar 2023 10:57:20 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 9811ADDA824 for ; Fri, 10 Mar 2023 10:57:20 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 405B6DDA836 for ; Fri, 10 Mar 2023 10:57:17 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 10 Mar 2023 10:57:09 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Rebecca Cran'" , , "'Bob Feng'" , "'Yuwei Chen'" References: <20230225005431.12173-1-rebecca@bsdio.com> In-Reply-To: <20230225005431.12173-1-rebecca@bsdio.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMC8zXSBCYXNlVG9vbHM6IEZpeCBkb2MgYmxvY2sgbG9jYXRpb24gYW5kIGZvcm1hdHRpbmc7IHJ1biB1bmNydXN0aWZ5?= Date: Fri, 10 Mar 2023 10:57:12 +0800 Message-ID: <009c01d952fc$03d139e0$0b73ada0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJfxpCljrbd3kcBQcow5SPIloYhx63mapMg Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Rebecca: I think these changes are good. Reviewed-by: Liming Gao Besides, which tool is used to convert function comments to Doxygen format? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Rebecca Cran > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA2=D4=C225=C8=D5 8:54 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Bob Feng = ; Liming > Gao ; Yuwei Chen > =B3=AD=CB=CD: Rebecca Cran > =D6=F7=CC=E2: [PATCH 0/3] BaseTools: Fix doc block location and = formatting; run > uncrustify >=20 > Fix the formatting and location of documentation blocks in Source/C/Common, > and replace the duplicate prototype of __PcdSet with __PcdGet. Those > patches > will fail CI because it appears Uncrustify was never run on BaseTools? >=20 > Patch 3/3 reformats the files in Source/C/Common according to > Uncrustify. >=20 > Rebecca Cran (3): > BaseTools: Source/C/Common: Fix doc block locations and convert to > Doxygen > BaseTools: Replace duplicate __PcdSet prototype with __PcdGet > BaseTools: Run Uncrustify over files in Source/C/Common >=20 > BaseTools/Source/C/Common/BinderFuncs.h | 27 +- > BaseTools/Source/C/Common/CommonLib.h | 267 ++-- > BaseTools/Source/C/Common/Compress.h | 45 +- > BaseTools/Source/C/Common/Crc32.h | 36 +- > BaseTools/Source/C/Common/Decompress.h | 122 +- > BaseTools/Source/C/Common/EfiUtilityMsgs.h | 38 +- > BaseTools/Source/C/Common/FirmwareVolumeBufferLib.h | 101 +- > BaseTools/Source/C/Common/FvLib.h | 51 +- > BaseTools/Source/C/Common/MemoryFile.h | 76 +- > BaseTools/Source/C/Common/MyAlloc.h | 196 +-- > BaseTools/Source/C/Common/OsPath.h | 92 +- > BaseTools/Source/C/Common/ParseGuidedSectionTools.h | 101 +- > BaseTools/Source/C/Common/ParseInf.h | 228 ++-- > BaseTools/Source/C/Common/PcdValueCommon.h | 196 +-- > BaseTools/Source/C/Common/PeCoffLib.h | 66 +- > BaseTools/Source/C/Common/SimpleFileParsing.h | 24 +- > BaseTools/Source/C/Common/StringFuncs.h | 203 +-- > BaseTools/Source/C/Common/WinNtInclude.h | 28 +- > BaseTools/Source/C/Common/BasePeCoff.c | 1068 > +++++++-------- > BaseTools/Source/C/Common/BinderFuncs.c | 31 +- > BaseTools/Source/C/Common/CommonLib.c | 914 > ++++++------- > BaseTools/Source/C/Common/Crc32.c | 38 +- > BaseTools/Source/C/Common/Decompress.c | 795 > +++++------ > BaseTools/Source/C/Common/EfiCompress.c | 1189 > ++++++++-------- > BaseTools/Source/C/Common/EfiUtilityMsgs.c | 663 ++++----- > BaseTools/Source/C/Common/FirmwareVolumeBuffer.c | 1426 > ++++++++------------ > BaseTools/Source/C/Common/FvLib.c | 638 > ++++----- > BaseTools/Source/C/Common/MemoryFile.c | 131 +- > BaseTools/Source/C/Common/MyAlloc.c | 265 ++-- > BaseTools/Source/C/Common/OsPath.c | 180 +-- > BaseTools/Source/C/Common/ParseGuidedSectionTools.c | 142 +- > BaseTools/Source/C/Common/ParseInf.c | 401 +++--- > BaseTools/Source/C/Common/PcdValueCommon.c | 618 > ++++----- > BaseTools/Source/C/Common/PeCoffLoaderEx.c | 277 ++-- > BaseTools/Source/C/Common/SimpleFileParsing.c | 737 > +++++----- > BaseTools/Source/C/Common/StringFuncs.c | 310 ++--- > BaseTools/Source/C/Common/TianoCompress.c | 1075 > ++++++--------- > 37 files changed, 5544 insertions(+), 7251 deletions(-) >=20 > -- > 2.37.1 (Apple Git-137.1)