From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
<zhichao.gao@intel.com>,
"'Ke, Bo-ChangX'" <bo-changx.ke@intel.com>
Cc: "'Liu, Zhiguang'" <zhiguang.liu@intel.com>,
"'Bi, Dandan'" <dandan.bi@intel.com>,
"'Zeng, Star'" <star.zeng@intel.com>,
"'Kinney, Michael D'" <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
Date: Thu, 21 Apr 2022 09:03:09 +0800 [thread overview]
Message-ID: <009d01d8551b$91575f90$b4061eb0$@byosoft.com.cn> (raw)
In-Reply-To: <16E771221F3810EE.23693@groups.io>
Chang:
PR shows the patch coding style issue. Please fix them.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2022年4月20日 7:50
> 收件人: devel@edk2.groups.io; zhichao.gao@intel.com; 'Ke, Bo-ChangX'
> <bo-changx.ke@intel.com>
> 抄送: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; 'Bi, Dandan'
> <dandan.bi@intel.com>; 'Zeng, Star' <star.zeng@intel.com>; 'Kinney, Michael
> D' <michael.d.kinney@intel.com>
> 主题: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> with SMBIOS 3.5 fields
>
> PR https://github.com/tianocore/edk2/pull/2797 is created.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Gao,
> Zhichao
> > 发送时间: 2022年4月19日 13:09
> > 收件人: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>;
> Ke,
> > Bo-ChangX <bo-changx.ke@intel.com>
> > 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan
> > <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Kinney, Michael
> D
> > <michael.d.kinney@intel.com>
> > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> with
> > SMBIOS 3.5 fields
> >
> > Hi Liming, Mike,
> >
> > Can you help to create the PR of these patch set? This is the first patch and
> > the second one is ShellPkg with the same titile.
> >
> > Thanks,
> > Zhichao
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > gaoliming
> > > Sent: Sunday, April 17, 2022 11:25 AM
> > > To: devel@edk2.groups.io; Ke, Bo-ChangX <bo-changx.ke@intel.com>;
> Gao,
> > > Zhichao <zhichao.gao@intel.com>
> > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan
> > > <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Kinney,
> Michael
> > > D <michael.d.kinney@intel.com>
> > > Subject: 回复: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type
> 9
> > > with SMBIOS 3.5 fields
> > >
> > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > >
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Bo
> Chang
> > Ke
> > > > 发送时间: 2022年4月15日 16:35
> > > > 收件人: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> > > > 抄送: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan
> > > > <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Gao, Liming
> > > > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosview type 9
> > > with
> > > > SMBIOS 3.5 fields
> > > >
> > > > Add Kinney, Michael D and Gao, Liming
> > > >
> > > > Best Regards.
> > > >
> > > > -----Original Message-----
> > > > From: Gao, Zhichao <zhichao.gao@intel.com>
> > > > Sent: Thursday, April 14, 2022 10:25 AM
> > > > To: Ke, Bo-ChangX <bo-changx.ke@intel.com>; devel@edk2.groups.io
> > > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Bi, Dandan
> > > > <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
> > > > Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with
> SMBIOS
> > > > 3.5 fields
> > > >
> > > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> > > >
> > > > Thanks,
> > > > Zhichao
> > > >
> > > > > -----Original Message-----
> > > > > From: Ke, Bo-ChangX <bo-changx.ke@intel.com>
> > > > > Sent: Wednesday, April 13, 2022 11:14 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Zhichao
> > > > > <zhichao.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng,
> > > > > Star <star.zeng@intel.com>
> > > > > Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS
> > 3.5
> > > > > fields
> > > > >
> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
> > > > >
> > > > > update smbiosview type 9 related fileds.
> > > > >
> > > > > Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
> > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > > > > Cc: Dandan Bi <dandan.bi@intel.com>
> > > > > Cc: Star Zeng <star.zeng@intel.com>
> > > > > ---
> > > > > MdePkg/Include/IndustryStandard/SmBios.h | 49
> > > > > +++++++++++++++++++++++-
> > > > > 1 file changed, 48 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > index 2b1567b052..52f2e35ee9 100644
> > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > @@ -1306,6 +1306,11 @@ typedef enum {
> > > > > SlotTypePciExpressMini52pinWithBSKO = 0x21, ///< PCI
> > > > Express Mini 52-pin
> > > > > (CEM spec. 2.0) with bottom-side keep-outs.
> > > > > SlotTypePciExpressMini52pinWithoutBSKO = 0x22, ///< PCI
> > Express
> > > > Mini 52-
> > > > > pin (CEM spec. 2.0) without bottom-side keep-outs.
> > > > > SlotTypePciExpressMini76pin = 0x23, ///< PCI
> > > > Express Mini 76-pin (CEM
> > > > > spec. 2.0) Corresponds to Display-Mini card.
> > > > > + SlotTypePCIExpressGen4SFF_8639 = 0x24, ///< U.2
> > > > > + SlotTypePCIExpressGen5SFF_8639 = 0x25, ///< U.2
> > > > > + SlotTypeOCPNIC30SmallFormFactor = 0x26, ///< SFF
> > > > > + SlotTypeOCPNIC30LargeFormFactor = 0x27, ///< LFF
> > > > > + SlotTypeOCPNICPriorto30 = 0x28,
> > > > > SlotTypeCXLFlexbus10 = 0x30,
> > > > > SlotTypePC98C20 = 0xA0,
> > > > > SlotTypePC98C24 = 0xA1,
> > > > > @@ -1335,7 +1340,16 @@ typedef enum {
> > > > > SlotTypePciExpressGen4X2 = 0xBA,
> > > > > SlotTypePciExpressGen4X4 = 0xBB,
> > > > > SlotTypePciExpressGen4X8 = 0xBC,
> > > > > - SlotTypePciExpressGen4X16 = 0xBD
> > > > > + SlotTypePciExpressGen4X16 = 0xBD,
> > > > > + SlotTypePCIExpressGen5 = 0xBE,
> > > > > + SlotTypePCIExpressGen5X1 = 0xBF,
> > > > > + SlotTypePCIExpressGen5X2 = 0xC0,
> > > > > + SlotTypePCIExpressGen5X4 = 0xC1,
> > > > > + SlotTypePCIExpressGen5X8 = 0xC2,
> > > > > + SlotTypePCIExpressGen5X16 = 0xC3,
> > > > > + SlotTypePCIExpressGen6andBeyond = 0xC4,
> > > > > + SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot = 0xC5,
> > > > > + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot = 0xC6
> > > > > } MISC_SLOT_TYPE;
> > > > >
> > > > > ///
> > > > > @@ -1358,6 +1372,39 @@ typedef enum {
> > > > > SlotDataBusWidth32X = 0x0E ///< Or X32
> > > > > } MISC_SLOT_DATA_BUS_WIDTH;
> > > > >
> > > > > +///
> > > > > +/// System Slots - Slot Physical Width.
> > > > > +///
> > > > > +typedef enum {
> > > > > + SlotPhysicalWidthOther = 0x01,
> > > > > + SlotPhysicalWidthUnknown = 0x02,
> > > > > + SlotPhysicalWidth8Bit = 0x03,
> > > > > + SlotPhysicalWidth16Bit = 0x04,
> > > > > + SlotPhysicalWidth32Bit = 0x05,
> > > > > + SlotPhysicalWidth64Bit = 0x06,
> > > > > + SlotPhysicalWidth128Bit = 0x07,
> > > > > + SlotPhysicalWidth1X = 0x08, ///< Or X1
> > > > > + SlotPhysicalWidth2X = 0x09, ///< Or X2
> > > > > + SlotPhysicalWidth4X = 0x0A, ///< Or X4
> > > > > + SlotPhysicalWidth8X = 0x0B, ///< Or X8
> > > > > + SlotPhysicalWidth12X = 0x0C, ///< Or X12
> > > > > + SlotPhysicalWidth16X = 0x0D, ///< Or X16
> > > > > + SlotPhysicalWidth32X = 0x0E ///< Or X32
> > > > > +} MISC_SLOT_PHYSICAL_WIDTH;
> > > > > +
> > > > > +///
> > > > > +/// System Slots - Slot Information.
> > > > > +///
> > > > > +typedef enum {
> > > > > + others = 0x00,
> > > > > + Gen1 = 0x01,
> > > > > + Gen2 = 0x01,
> > > > > + Gen3 = 0x03,
> > > > > + Gen4 = 0x04,
> > > > > + Gen5 = 0x05,
> > > > > + Gen6 = 0x06
> > > > > +} MISC_SLOT_INFORMATION;
> > > > > +
> > > > > ///
> > > > > /// System Slots - Current Usage.
> > > > > ///
> > > > > --
> > > > > 2.32.0.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
prev parent reply other threads:[~2022-04-21 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 3:14 [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields Bo Chang Ke
2022-04-14 2:24 ` Gao, Zhichao
2022-04-15 8:35 ` Bo Chang Ke
2022-04-17 3:24 ` 回复: [edk2-devel] " gaoliming
2022-04-19 5:08 ` Gao, Zhichao
2022-04-19 23:49 ` 回复: " gaoliming
[not found] ` <16E771221F3810EE.23693@groups.io>
2022-04-21 1:03 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009d01d8551b$91575f90$b4061eb0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox