From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.15895.1650502991334377304 for ; Wed, 20 Apr 2022 18:03:12 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([101.224.116.119]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 21 Apr 2022 09:03:05 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.224.116.119 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Ke, Bo-ChangX'" Cc: "'Liu, Zhiguang'" , "'Bi, Dandan'" , "'Zeng, Star'" , "'Kinney, Michael D'" References: <000101d8520a$ad32fc60$0798f520$@byosoft.com.cn> <16E771221F3810EE.23693@groups.io> In-Reply-To: <16E771221F3810EE.23693@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyXSBNZGVQa2c6IFVwZGF0ZSBzbWJpb3N2aWV3IHR5cGUgOSB3aXRoIFNNQklPUyAzLjUgZmllbGRz?= Date: Thu, 21 Apr 2022 09:03:09 +0800 Message-ID: <009d01d8551b$91575f90$b4061eb0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH3v/Xi0ACIcYe9hmqvC4mSBdrLDgMV9LDHAravN2cBshVLxAGfffAFATXHmymsaBcRsA== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Chang: PR shows the patch coding style issue. Please fix them.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B44=E6=9C=8820=E6=97=A5 = 7:50 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; zhichao.gao@intel.com;= 'Ke, Bo-ChangX' > > =E6=8A=84=E9=80=81: 'Liu, Zhiguang' ; 'Bi, Dandan= ' > ; 'Zeng, Star' ; 'Kinney, Micha= el > D' > =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v2] MdePkg: U= pdate smbiosview type 9 > with SMBIOS 3.5 fields >=20 > PR https://github.com/tianocore/edk2/pull/2797 is created. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Gao, > Zhichao > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B44=E6=9C=8819=E6=97= =A5 13:09 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Gao, Liming ; > Ke, > > Bo-ChangX > > =E6=8A=84=E9=80=81: Liu, Zhiguang ; Bi, Dandan > > ; Zeng, Star ; Kinney, Michae= l > D > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbiosvi= ew type 9 > with > > SMBIOS 3.5 fields > > > > Hi Liming, Mike, > > > > Can you help to create the PR of these patch set? This is the first pat= ch and > > the second one is ShellPkg with the same titile. > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > gaoliming > > > Sent: Sunday, April 17, 2022 11:25 AM > > > To: devel@edk2.groups.io; Ke, Bo-ChangX ; > Gao, > > > Zhichao > > > Cc: Liu, Zhiguang ; Bi, Dandan > > > ; Zeng, Star ; Kinney, > Michael > > > D > > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v2] MdePkg: Update s= mbiosview type > 9 > > > with SMBIOS 3.5 fields > > > > > > Reviewed-by: Liming Gao > > > > > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Bo > Chang > > Ke > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B44=E6=9C=8815=E6= =97=A5 16:35 > > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: Gao, Zhichao ; = devel@edk2.groups.io > > > > =E6=8A=84=E9=80=81: Liu, Zhiguang ; Bi, Dan= dan > > > > ; Zeng, Star ; Gao, Limin= g > > > > ; Kinney, Michael D > > > > > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2] MdePkg: Update smbi= osview type 9 > > > with > > > > SMBIOS 3.5 fields > > > > > > > > Add Kinney, Michael D and Gao, Liming > > > > > > > > Best Regards. > > > > > > > > -----Original Message----- > > > > From: Gao, Zhichao > > > > Sent: Thursday, April 14, 2022 10:25 AM > > > > To: Ke, Bo-ChangX ; devel@edk2.groups.io > > > > Cc: Liu, Zhiguang ; Bi, Dandan > > > > ; Zeng, Star > > > > Subject: RE: [PATCH v2] MdePkg: Update smbiosview type 9 with > SMBIOS > > > > 3.5 fields > > > > > > > > Reviewed-by: Zhichao Gao > > > > > > > > Thanks, > > > > Zhichao > > > > > > > > > -----Original Message----- > > > > > From: Ke, Bo-ChangX > > > > > Sent: Wednesday, April 13, 2022 11:14 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Liu, Zhiguang ; Gao, Zhichao > > > > > ; Bi, Dandan ; Zeng, > > > > > Star > > > > > Subject: [PATCH v2] MdePkg: Update smbiosview type 9 with SMBIOS > > 3.5 > > > > > fields > > > > > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3896 > > > > > > > > > > update smbiosview type 9 related fileds. > > > > > > > > > > Signed-off-by: Bo Chang Ke > > > > > Cc: Zhiguang Liu > > > > > Cc: Zhichao Gao > > > > > Cc: Dandan Bi > > > > > Cc: Star Zeng > > > > > --- > > > > > MdePkg/Include/IndustryStandard/SmBios.h | 49 > > > > > +++++++++++++++++++++++- > > > > > 1 file changed, 48 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > > > > > b/MdePkg/Include/IndustryStandard/SmBios.h > > > > > index 2b1567b052..52f2e35ee9 100644 > > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h > > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > > > > > @@ -1306,6 +1306,11 @@ typedef enum { > > > > > SlotTypePciExpressMini52pinWithBSKO =3D 0x21, ///< PCI > > > > Express Mini 52-pin > > > > > (CEM spec. 2.0) with bottom-side keep-outs. > > > > > SlotTypePciExpressMini52pinWithoutBSKO =3D 0x22, ///< PCI > > Express > > > > Mini 52- > > > > > pin (CEM spec. 2.0) without bottom-side keep-outs. > > > > > SlotTypePciExpressMini76pin =3D 0x23, ///< PCI > > > > Express Mini 76-pin (CEM > > > > > spec. 2.0) Corresponds to Display-Mini card. > > > > > + SlotTypePCIExpressGen4SFF_8639 =3D 0x24, ///< U.2 > > > > > + SlotTypePCIExpressGen5SFF_8639 =3D 0x25, ///< U.2 > > > > > + SlotTypeOCPNIC30SmallFormFactor =3D 0x26, ///< SFF > > > > > + SlotTypeOCPNIC30LargeFormFactor =3D 0x27, ///< LFF > > > > > + SlotTypeOCPNICPriorto30 =3D 0x28, > > > > > SlotTypeCXLFlexbus10 =3D 0x30, > > > > > SlotTypePC98C20 =3D 0xA0, > > > > > SlotTypePC98C24 =3D 0xA1, > > > > > @@ -1335,7 +1340,16 @@ typedef enum { > > > > > SlotTypePciExpressGen4X2 =3D 0xBA, > > > > > SlotTypePciExpressGen4X4 =3D 0xBB, > > > > > SlotTypePciExpressGen4X8 =3D 0xBC, > > > > > - SlotTypePciExpressGen4X16 =3D 0xBD > > > > > + SlotTypePciExpressGen4X16 =3D 0xBD, > > > > > + SlotTypePCIExpressGen5 =3D 0xBE, > > > > > + SlotTypePCIExpressGen5X1 =3D 0xBF, > > > > > + SlotTypePCIExpressGen5X2 =3D 0xC0, > > > > > + SlotTypePCIExpressGen5X4 =3D 0xC1, > > > > > + SlotTypePCIExpressGen5X8 =3D 0xC2, > > > > > + SlotTypePCIExpressGen5X16 =3D 0xC3, > > > > > + SlotTypePCIExpressGen6andBeyond =3D 0xC4, > > > > > + SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot =3D 0xC5, > > > > > + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot =3D 0xC6 > > > > > } MISC_SLOT_TYPE; > > > > > > > > > > /// > > > > > @@ -1358,6 +1372,39 @@ typedef enum { > > > > > SlotDataBusWidth32X =3D 0x0E ///< Or X32 > > > > > } MISC_SLOT_DATA_BUS_WIDTH; > > > > > > > > > > +/// > > > > > +/// System Slots - Slot Physical Width. > > > > > +/// > > > > > +typedef enum { > > > > > + SlotPhysicalWidthOther =3D 0x01, > > > > > + SlotPhysicalWidthUnknown =3D 0x02, > > > > > + SlotPhysicalWidth8Bit =3D 0x03, > > > > > + SlotPhysicalWidth16Bit =3D 0x04, > > > > > + SlotPhysicalWidth32Bit =3D 0x05, > > > > > + SlotPhysicalWidth64Bit =3D 0x06, > > > > > + SlotPhysicalWidth128Bit =3D 0x07, > > > > > + SlotPhysicalWidth1X =3D 0x08, ///< Or X1 > > > > > + SlotPhysicalWidth2X =3D 0x09, ///< Or X2 > > > > > + SlotPhysicalWidth4X =3D 0x0A, ///< Or X4 > > > > > + SlotPhysicalWidth8X =3D 0x0B, ///< Or X8 > > > > > + SlotPhysicalWidth12X =3D 0x0C, ///< Or X12 > > > > > + SlotPhysicalWidth16X =3D 0x0D, ///< Or X16 > > > > > + SlotPhysicalWidth32X =3D 0x0E ///< Or X32 > > > > > +} MISC_SLOT_PHYSICAL_WIDTH; > > > > > + > > > > > +/// > > > > > +/// System Slots - Slot Information. > > > > > +/// > > > > > +typedef enum { > > > > > + others =3D 0x00, > > > > > + Gen1 =3D 0x01, > > > > > + Gen2 =3D 0x01, > > > > > + Gen3 =3D 0x03, > > > > > + Gen4 =3D 0x04, > > > > > + Gen5 =3D 0x05, > > > > > + Gen6 =3D 0x06 > > > > > +} MISC_SLOT_INFORMATION; > > > > > + > > > > > /// > > > > > /// System Slots - Current Usage. > > > > > /// > > > > > -- > > > > > 2.32.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20