* [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms @ 2023-05-09 16:44 Rebecca Cran 2023-05-10 0:13 ` Yao, Jiewen 0 siblings, 1 reply; 4+ messages in thread From: Rebecca Cran @ 2023-05-09 16:44 UTC (permalink / raw) To: devel, Jiewen Yao, Jian J Wang, Michael D Kinney, Liming Gao; +Cc: Rebecca Cran Add missing break in Tpm2TestParms. Reported in https://github.com/tianocore/edk2/issues/4073 Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c index 9db301ec9a90..f0e6019a47be 100644 --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c @@ -743,6 +743,7 @@ Tpm2TestParms ( return EFI_INVALID_PARAMETER; } + break; case TPM_ALG_SYMCIPHER: WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters->parameters.symDetail.algorithm)); Buffer += sizeof (UINT16); -- 2.39.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms 2023-05-09 16:44 [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms Rebecca Cran @ 2023-05-10 0:13 ` Yao, Jiewen 2023-05-11 1:46 ` 回复: [edk2-devel] " gaoliming 0 siblings, 1 reply; 4+ messages in thread From: Yao, Jiewen @ 2023-05-10 0:13 UTC (permalink / raw) To: Rebecca Cran, devel@edk2.groups.io, Wang, Jian J, Kinney, Michael D, Gao, Liming Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> Can we add this in 202305 stable tag? > -----Original Message----- > From: Rebecca Cran <rebecca@bsdio.com> > Sent: Wednesday, May 10, 2023 12:45 AM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, > Jian J <jian.j.wang@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: Rebecca Cran <rebecca@bsdio.com> > Subject: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms > > Add missing break in Tpm2TestParms. > > Reported in https://github.com/tianocore/edk2/issues/4073 > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > --- > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > index 9db301ec9a90..f0e6019a47be 100644 > --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > @@ -743,6 +743,7 @@ Tpm2TestParms ( > return EFI_INVALID_PARAMETER; > } > > + break; > case TPM_ALG_SYMCIPHER: > WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters- > >parameters.symDetail.algorithm)); > Buffer += sizeof (UINT16); > -- > 2.39.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms 2023-05-10 0:13 ` Yao, Jiewen @ 2023-05-11 1:46 ` gaoliming 2023-05-11 3:34 ` Yao, Jiewen 0 siblings, 1 reply; 4+ messages in thread From: gaoliming @ 2023-05-11 1:46 UTC (permalink / raw) To: devel, jiewen.yao, 'Rebecca Cran', 'Wang, Jian J', 'Kinney, Michael D' Jiewen: This is a bug fix. It can be merged for 202305. Thanks Liming> -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > 发送时间: 2023年5月10日 8:13 > 收件人: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io; Wang, > Jian J <jian.j.wang@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH 1/1] SecurityPkg: Add missing break in > Tpm2TestParms > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > Can we add this in 202305 stable tag? > > > > -----Original Message----- > > From: Rebecca Cran <rebecca@bsdio.com> > > Sent: Wednesday, May 10, 2023 12:45 AM > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, > > Jian J <jian.j.wang@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn> > > Cc: Rebecca Cran <rebecca@bsdio.com> > > Subject: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms > > > > Add missing break in Tpm2TestParms. > > > > Reported in https://github.com/tianocore/edk2/issues/4073 > > > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > > --- > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > index 9db301ec9a90..f0e6019a47be 100644 > > --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > @@ -743,6 +743,7 @@ Tpm2TestParms ( > > return EFI_INVALID_PARAMETER; > > } > > > > + break; > > case TPM_ALG_SYMCIPHER: > > WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters- > > >parameters.symDetail.algorithm)); > > Buffer += sizeof (UINT16); > > -- > > 2.39.2 > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms 2023-05-11 1:46 ` 回复: [edk2-devel] " gaoliming @ 2023-05-11 3:34 ` Yao, Jiewen 0 siblings, 0 replies; 4+ messages in thread From: Yao, Jiewen @ 2023-05-11 3:34 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming, 'Rebecca Cran', Wang, Jian J, Kinney, Michael D Thank you! Merged https://github.com/tianocore/edk2/pull/4386 > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > gaoliming via groups.io > Sent: Thursday, May 11, 2023 9:46 AM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; 'Rebecca > Cran' <rebecca@bsdio.com>; Wang, Jian J <jian.j.wang@intel.com>; Kinney, > Michael D <michael.d.kinney@intel.com> > Subject: 回复: [edk2-devel] [PATCH 1/1] SecurityPkg: Add missing break in > Tpm2TestParms > > Jiewen: > This is a bug fix. It can be merged for 202305. > > Thanks > Liming> -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen > > 发送时间: 2023年5月10日 8:13 > > 收件人: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io; > Wang, > > Jian J <jian.j.wang@intel.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn> > > 主题: Re: [edk2-devel] [PATCH 1/1] SecurityPkg: Add missing break in > > Tpm2TestParms > > > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > > > > Can we add this in 202305 stable tag? > > > > > > > -----Original Message----- > > > From: Rebecca Cran <rebecca@bsdio.com> > > > Sent: Wednesday, May 10, 2023 12:45 AM > > > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang, > > > Jian J <jian.j.wang@intel.com>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn> > > > Cc: Rebecca Cran <rebecca@bsdio.com> > > > Subject: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms > > > > > > Add missing break in Tpm2TestParms. > > > > > > Reported in https://github.com/tianocore/edk2/issues/4073 > > > > > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > > > --- > > > SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > index 9db301ec9a90..f0e6019a47be 100644 > > > --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c > > > @@ -743,6 +743,7 @@ Tpm2TestParms ( > > > return EFI_INVALID_PARAMETER; > > > } > > > > > > + break; > > > case TPM_ALG_SYMCIPHER: > > > WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters- > > > >parameters.symDetail.algorithm)); > > > Buffer += sizeof (UINT16); > > > -- > > > 2.39.2 > > > > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-11 3:34 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-09 16:44 [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms Rebecca Cran 2023-05-10 0:13 ` Yao, Jiewen 2023-05-11 1:46 ` 回复: [edk2-devel] " gaoliming 2023-05-11 3:34 ` Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox