From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <zhuenze@byosoft.com.cn>,
"'Bret Barkelew'" <Bret.Barkelew@microsoft.com>
Cc: "'Ray Ni'" <ray.ni@intel.com>,
"'Zhichao Gao'" <zhichao.gao@intel.com>,
"'Liming Gao'" <liming.gao@intel.com>
Subject: 回复: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17
Date: Tue, 3 Nov 2020 09:01:04 +0800 [thread overview]
Message-ID: <00a801d6b17c$ce74a3e0$6b5deba0$@byosoft.com.cn> (raw)
In-Reply-To: <602b3514eaae784b1983fb43f1b85217d8048745.1603951995.git.zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: bounce+27952+66729+4905953+8761045@groups.io
> <bounce+27952+66729+4905953+8761045@groups.io> 代表 Enze Zhu
> 发送时间: 2020年10月29日 14:14
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>;
> Liming Gao <liming.gao@intel.com>
> 主题: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD
> show for smbios 3.3.0 type17
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952
>
> In MdePkg/SmBios.h,there are two additional DWORD added
> for type 17,but these two DWORD do not show in SmbiosView,
> So add them.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
> .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 7
> +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 7517465ddd..4dd029d6b4 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -795,6 +795,13 @@ SmbiosPrintStructure (
> PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
> }
> }
> + //
> + // Add for smbios 3.3.0
> + //
> + if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> + PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> + PRINT_STRUCT_VALUE_H (Struct, Type17,
> ExtendedConfiguredMemorySpeed);
> + }
> break;
>
> //
> --
> 2.27.0.windows.1
>
>
>
>
>
>
prev parent reply other threads:[~2020-11-03 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 6:13 [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17 Enze Zhu
2020-11-03 1:01 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a801d6b17c$ce74a3e0$6b5deba0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox