* [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17
@ 2020-10-29 6:13 Enze Zhu
2020-11-03 1:01 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 2+ messages in thread
From: Enze Zhu @ 2020-10-29 6:13 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Zhichao Gao, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952
In MdePkg/SmBios.h,there are two additional DWORD added
for type 17,but these two DWORD do not show in SmbiosView,
So add them.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
.../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 7517465ddd..4dd029d6b4 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -795,6 +795,13 @@ SmbiosPrintStructure (
PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
}
}
+ //
+ // Add for smbios 3.3.0
+ //
+ if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
+ PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
+ PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedConfiguredMemorySpeed);
+ }
break;
//
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* 回复: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17
2020-10-29 6:13 [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17 Enze Zhu
@ 2020-11-03 1:01 ` gaoliming
0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2020-11-03 1:01 UTC (permalink / raw)
To: devel, zhuenze, 'Bret Barkelew'
Cc: 'Ray Ni', 'Zhichao Gao', 'Liming Gao'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: bounce+27952+66729+4905953+8761045@groups.io
> <bounce+27952+66729+4905953+8761045@groups.io> 代表 Enze Zhu
> 发送时间: 2020年10月29日 14:14
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>;
> Liming Gao <liming.gao@intel.com>
> 主题: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD
> show for smbios 3.3.0 type17
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952
>
> In MdePkg/SmBios.h,there are two additional DWORD added
> for type 17,but these two DWORD do not show in SmbiosView,
> So add them.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
> .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 7
> +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 7517465ddd..4dd029d6b4 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -795,6 +795,13 @@ SmbiosPrintStructure (
> PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
> }
> }
> + //
> + // Add for smbios 3.3.0
> + //
> + if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> + PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> + PRINT_STRUCT_VALUE_H (Struct, Type17,
> ExtendedConfiguredMemorySpeed);
> + }
> break;
>
> //
> --
> 2.27.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-29 6:13 [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17 Enze Zhu
2020-11-03 1:01 ` 回复: [edk2-devel] " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox