From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Yunhua Feng'" <fengyunhua@byosoft.com.cn>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [PATCH] BaseTools: Fix BaseTools nmake cleanall hang issue
Date: Tue, 3 Nov 2020 09:03:59 +0800 [thread overview]
Message-ID: <00a901d6b17d$368284c0$a3878e40$@byosoft.com.cn> (raw)
In-Reply-To: <20201030031108.2033-1-fengyunhua@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Yunhua Feng <fengyunhua@byosoft.com.cn>
> 发送时间: 2020年10月30日 11:11
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [PATCH] BaseTools: Fix BaseTools nmake cleanall hang issue
>
> On windows system, when use command chcp displays the number of the
> active console code page, if the active console code is 936, run
> make cleanall in the BaseTools will hang.
> Issue reproduce step:
> chcp 936
> edksetup.bat VS2015
> cd BaseTools
> nmake cleanall
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
> BaseTools/Source/C/Makefiles/NmakeSubdirs.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/C/Makefiles/NmakeSubdirs.py
> b/BaseTools/Source/C/Makefiles/NmakeSubdirs.py
> index 9b699ea086..1f4a45004f 100644
> --- a/BaseTools/Source/C/Makefiles/NmakeSubdirs.py
> +++ b/BaseTools/Source/C/Makefiles/NmakeSubdirs.py
> @@ -45,7 +45,10 @@ def RunCommand(WorkDir=None, *Args, **kwargs):
>
> output_lock.acquire(True)
> print("execute command \"{0}\" in directory {1}".format("
".join(Args),
> WorkDir))
> - print(message)
> + try:
> + print(message)
> + except:
> + pass
> output_lock.release()
>
> return p.returncode, stdout
> --
> 2.27.0.windows.1
prev parent reply other threads:[~2020-11-03 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 3:11 [PATCH] BaseTools: Fix BaseTools nmake cleanall hang issue fengyunhua
2020-11-03 1:03 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a901d6b17d$368284c0$a3878e40$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox