From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
"'Chandramohan Akula'" <chandramohan.akula@broadcom.com>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>
Subject: 回复: [edk2-devel] 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()
Date: Wed, 17 Mar 2021 09:21:05 +0800 [thread overview]
Message-ID: <00ab01d71acb$cd2cfd80$6786f880$@byosoft.com.cn> (raw)
In-Reply-To: <166A887F01CF1B18.3460@groups.io>
Create PR https://github.com/tianocore/edk2/pull/1495
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年3月9日 9:31
> 收件人: 'Chandramohan Akula' <chandramohan.akula@broadcom.com>;
> devel@edk2.groups.io
> 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu'
> <zhiguang.liu@intel.com>
> 主题: [edk2-devel] 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the
> arguments passed to IsLanguageSupported()
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: Chandramohan Akula <chandramohan.akula@broadcom.com>
> > 发送时间: 2021年3月8日 11:03
> > 收件人: devel@edk2.groups.io
> > 抄送: Chandramohan Akula <chandramohan.akula@broadcom.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to
> > IsLanguageSupported()
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3211
> >
> > Correct the arguments passed to the IsLanguageSupported() function in
> > AddUnicodeString2() and LookupUnicodeString2() as expected by the
> function
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Chandramohan Akula
> <chandramohan.akula@broadcom.com>
> > ---
> > MdePkg/Library/UefiLib/UefiLib.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Library/UefiLib/UefiLib.c
> > b/MdePkg/Library/UefiLib/UefiLib.c
> > index 835218f9824f..b6a33a0a488e 100644
> > --- a/MdePkg/Library/UefiLib/UefiLib.c
> > +++ b/MdePkg/Library/UefiLib/UefiLib.c
> > @@ -839,7 +839,7 @@ LookupUnicodeString2 (
> > SupportedLanguages += 3;
> >
> > }
> >
> > } else {
> >
> > - Found = !IsLanguageSupported(Language, SupportedLanguages);
> >
> > + Found = !IsLanguageSupported(SupportedLanguages, Language);
> >
> > }
> >
> >
> >
> >
> >
> > @@ -1133,7 +1133,7 @@ AddUnicodeString2 (
> > SupportedLanguages += 3;
> >
> > }
> >
> > } else {
> >
> > - Found = !IsLanguageSupported(Language, SupportedLanguages);
> >
> > + Found = !IsLanguageSupported(SupportedLanguages, Language);
> >
> > }
> >
> > //
> >
> > // If Language is not a member of SupportedLanguages, then return
> > EFI_UNSUPPORTED
> >
> > --
> > 2.27.0
>
>
>
>
>
>
>
prev parent reply other threads:[~2021-03-17 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1615172298.git.chandramohan.akula@broadcom.com>
2021-03-08 3:02 ` [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported() chandramohan.akula
2021-03-09 1:31 ` 回复: " gaoliming
[not found] ` <166A887F01CF1B18.3460@groups.io>
2021-03-17 1:21 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ab01d71acb$cd2cfd80$6786f880$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox