* [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()
[not found] <cover.1615172298.git.chandramohan.akula@broadcom.com>
@ 2021-03-08 3:02 ` chandramohan.akula
2021-03-09 1:31 ` 回复: " gaoliming
[not found] ` <166A887F01CF1B18.3460@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: chandramohan.akula @ 2021-03-08 3:02 UTC (permalink / raw)
To: devel; +Cc: Chandramohan Akula, Michael D Kinney, Liming Gao, Zhiguang Liu
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3211
Correct the arguments passed to the IsLanguageSupported() function in
AddUnicodeString2() and LookupUnicodeString2() as expected by the function
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Chandramohan Akula <chandramohan.akula@broadcom.com>
---
MdePkg/Library/UefiLib/UefiLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
index 835218f9824f..b6a33a0a488e 100644
--- a/MdePkg/Library/UefiLib/UefiLib.c
+++ b/MdePkg/Library/UefiLib/UefiLib.c
@@ -839,7 +839,7 @@ LookupUnicodeString2 (
SupportedLanguages += 3;
}
} else {
- Found = !IsLanguageSupported(Language, SupportedLanguages);
+ Found = !IsLanguageSupported(SupportedLanguages, Language);
}
@@ -1133,7 +1133,7 @@ AddUnicodeString2 (
SupportedLanguages += 3;
}
} else {
- Found = !IsLanguageSupported(Language, SupportedLanguages);
+ Found = !IsLanguageSupported(SupportedLanguages, Language);
}
//
// If Language is not a member of SupportedLanguages, then return EFI_UNSUPPORTED
--
2.27.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()
2021-03-08 3:02 ` [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported() chandramohan.akula
@ 2021-03-09 1:31 ` gaoliming
[not found] ` <166A887F01CF1B18.3460@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: gaoliming @ 2021-03-09 1:31 UTC (permalink / raw)
To: 'Chandramohan Akula', devel
Cc: 'Michael D Kinney', 'Zhiguang Liu'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Chandramohan Akula <chandramohan.akula@broadcom.com>
> 发送时间: 2021年3月8日 11:03
> 收件人: devel@edk2.groups.io
> 抄送: Chandramohan Akula <chandramohan.akula@broadcom.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to
> IsLanguageSupported()
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3211
>
> Correct the arguments passed to the IsLanguageSupported() function in
> AddUnicodeString2() and LookupUnicodeString2() as expected by the function
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Chandramohan Akula <chandramohan.akula@broadcom.com>
> ---
> MdePkg/Library/UefiLib/UefiLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c
> b/MdePkg/Library/UefiLib/UefiLib.c
> index 835218f9824f..b6a33a0a488e 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -839,7 +839,7 @@ LookupUnicodeString2 (
> SupportedLanguages += 3;
>
> }
>
> } else {
>
> - Found = !IsLanguageSupported(Language, SupportedLanguages);
>
> + Found = !IsLanguageSupported(SupportedLanguages, Language);
>
> }
>
>
>
>
>
> @@ -1133,7 +1133,7 @@ AddUnicodeString2 (
> SupportedLanguages += 3;
>
> }
>
> } else {
>
> - Found = !IsLanguageSupported(Language, SupportedLanguages);
>
> + Found = !IsLanguageSupported(SupportedLanguages, Language);
>
> }
>
> //
>
> // If Language is not a member of SupportedLanguages, then return
> EFI_UNSUPPORTED
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* 回复: [edk2-devel] 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()
[not found] ` <166A887F01CF1B18.3460@groups.io>
@ 2021-03-17 1:21 ` gaoliming
0 siblings, 0 replies; 3+ messages in thread
From: gaoliming @ 2021-03-17 1:21 UTC (permalink / raw)
To: devel, gaoliming, 'Chandramohan Akula'
Cc: 'Michael D Kinney', 'Zhiguang Liu'
Create PR https://github.com/tianocore/edk2/pull/1495
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年3月9日 9:31
> 收件人: 'Chandramohan Akula' <chandramohan.akula@broadcom.com>;
> devel@edk2.groups.io
> 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu'
> <zhiguang.liu@intel.com>
> 主题: [edk2-devel] 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the
> arguments passed to IsLanguageSupported()
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: Chandramohan Akula <chandramohan.akula@broadcom.com>
> > 发送时间: 2021年3月8日 11:03
> > 收件人: devel@edk2.groups.io
> > 抄送: Chandramohan Akula <chandramohan.akula@broadcom.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> > 主题: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to
> > IsLanguageSupported()
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3211
> >
> > Correct the arguments passed to the IsLanguageSupported() function in
> > AddUnicodeString2() and LookupUnicodeString2() as expected by the
> function
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Chandramohan Akula
> <chandramohan.akula@broadcom.com>
> > ---
> > MdePkg/Library/UefiLib/UefiLib.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Library/UefiLib/UefiLib.c
> > b/MdePkg/Library/UefiLib/UefiLib.c
> > index 835218f9824f..b6a33a0a488e 100644
> > --- a/MdePkg/Library/UefiLib/UefiLib.c
> > +++ b/MdePkg/Library/UefiLib/UefiLib.c
> > @@ -839,7 +839,7 @@ LookupUnicodeString2 (
> > SupportedLanguages += 3;
> >
> > }
> >
> > } else {
> >
> > - Found = !IsLanguageSupported(Language, SupportedLanguages);
> >
> > + Found = !IsLanguageSupported(SupportedLanguages, Language);
> >
> > }
> >
> >
> >
> >
> >
> > @@ -1133,7 +1133,7 @@ AddUnicodeString2 (
> > SupportedLanguages += 3;
> >
> > }
> >
> > } else {
> >
> > - Found = !IsLanguageSupported(Language, SupportedLanguages);
> >
> > + Found = !IsLanguageSupported(SupportedLanguages, Language);
> >
> > }
> >
> > //
> >
> > // If Language is not a member of SupportedLanguages, then return
> > EFI_UNSUPPORTED
> >
> > --
> > 2.27.0
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1615172298.git.chandramohan.akula@broadcom.com>
2021-03-08 3:02 ` [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported() chandramohan.akula
2021-03-09 1:31 ` 回复: " gaoliming
[not found] ` <166A887F01CF1B18.3460@groups.io>
2021-03-17 1:21 ` 回复: [edk2-devel] " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox