From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.35577.1683770458794963902 for ; Wed, 10 May 2023 19:01:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=r4i8J0k6; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6835ACD1F754 for ; Thu, 11 May 2023 10:00:56 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683770456; bh=8Xy6UzQSUyZXEm0Hm4gi8uqQ9jTn+8V5L8dqMtbWj3Y=; h=From:To:References:In-Reply-To:Subject:Date; b=r4i8J0k63Uhqh7uHJtLJEiou59GRYSz5YaJDdjq9Wd4/asytwB2lSsHUivQCJhXZO /twHS6GAoxwLqE6T+JODiSHK7FJ3KCkxvts4YGYGQ5niXPp4wAijKasx1sDEpJarS1 JJMWN33y3UKw4CKkRmDXUoVdbmDDozvrcq+W1BzM= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 63FC6CD1F743 for ; Thu, 11 May 2023 10:00:56 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 372AECD1F73E for ; Thu, 11 May 2023 10:00:56 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id DDED4CD1F766 for ; Thu, 11 May 2023 10:00:53 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 11 May 2023 10:00:49 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , References: <20230510233930.1419-1-gua.guo@intel.com> In-Reply-To: <20230510233930.1419-1-gua.guo@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY5IDAvNV0gVHJhY2UgSHViIGRlYnVnIGxpYnJhcnkgc3VwcG9ydA==?= Date: Thu, 11 May 2023 10:00:53 +0800 Message-ID: <00ad01d983ac$6ae70980$40b51c80$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGN+9u4Mc7M72fSTmXkw2ulE+NbaK/rYQZg Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Acked-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Guo, Gua > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA5=D4=C211=C8=D5 7:39 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: gua.guo@intel.com > =D6=F7=CC=E2: [edk2-devel] [PATCH v9 0/5] Trace Hub debug library support >=20 > From: Gua Guo >=20 > V9: Add more maintainers into CC list > - https://github.com/tianocore/edk2/pull/3901 > F: * > M: Andrew Fish [ajfish] > M: Leif Lindholm [leiflindholm] > M: Michael D Kinney [mdkinney] >=20 > MdeModulePkg > M: Jian J Wang [jwang36] > M: Liming Gao [lgao4] >=20 > .pytool/ > M: Sean Brogan [spbrogan] > M: Michael Kubacki [makubacki] > R: Michael D Kinney [mdkinney] > R: Liming Gao [lgao4] >=20 > MdePkg/ > M: Michael D Kinney [mdkinney] > M: Liming Gao [lgao4] > R: Zhiguang Liu [LiuZhiguang001] >=20 >=20 > V8: Add MdeModulePkg maintainers into CC list >=20 > V7: Miss one patch on V6 >=20 > V6: > - https://github.com/tianocore/edk2/pull/3901 > Split submodule into new patch > Fix formatting issue > Add Review-by message > Offline check with Victor to use my sign-off name. >=20 > V5: if no other open, it will be final change > - https://github.com/tianocore/edk2/pull/3901 > Fix random exception when long run catalog debug message >=20 > V4 > - https://github.com/tianocore/edk2/pull/3901 - Done > Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make > implement code more simple. >=20 > V3 > - https://github.com/tianocore/edk2/pull/3901 - Done > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > Solution: Remove this macro, use Library Constructor to allocate it > dynamiclly. > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo > n.c: SwapBytesGuid () algorithm wrong. > Solution: Follow correct algorithm to implement it. > VOID > EFIAPI > SwapBytesGuid ( > IN GUID *Guid, <----------- In PreMem, guid is global > data so region is readonly, add output data to support it. > OUT GUID *ConvertedGuid > ); >=20 > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D > Solution: use *_*_*_CC_FLAGS =3D -DMIPI_SYST_STATIC to unified both. >=20 >=20 > V2 > - https://github.com/tianocore/edk2/pull/3901 > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo > n.c: SwapBytesGuid () algorithm wrong. > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D >=20 > V1 > Previous PR: > - https://github.com/tianocore/edk2/pull/3613 > - TraceHubDebugLib without submodule - Reject >=20 > - https://github.com/tianocore/edk2/pull/3793 > - TraceHubDebugLib with submodule and without seperate into > MipiSysTLib and TraceHubDebugLib - Reject >=20 > Gua Guo (5): > MdePkg: Add mipisyst submodule > MdePkg: Add MipiSysTLib library > MdePkg: Add NULL library of TraceHubDebugSysTLib > MdeModulePkg: Add TraceHubDebugSysTLib library > Maintainers.txt: Update reviewers and maintainers for > TraceHubDebugLib. >=20 > .gitmodules | 3 + > .pytool/CISettings.py | 2 + > Maintainers.txt | 18 + > .../Include/Guid/TraceHubDebugInfoHob.h | 24 + > .../BaseTraceHubDebugSysTLib.c | 245 ++++++ > .../BaseTraceHubDebugSysTLib.inf | 44 + > .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++ > .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++ > .../InternalTraceHubApi.c | 74 ++ > .../InternalTraceHubApi.h | 37 + > .../InternalTraceHubApiCommon.c | 200 +++++ > .../InternalTraceHubApiCommon.h | 119 +++ > .../PeiTraceHubDebugSysTLib.c | 282 +++++++ > .../PeiTraceHubDebugSysTLib.inf | 50 ++ > .../Library/TraceHubDebugSysTLib/Readme.md | 26 + > MdeModulePkg/MdeModulePkg.dec | 21 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > MdeModulePkg/MdeModulePkg.uni | 18 + > MdePkg/Include/Library/MipiSysTLib.h | 66 ++ > MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ > MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++ > MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ > MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ > MdePkg/Library/MipiSysTLib/Readme.md | 25 + > MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 > ++++++++++++++++++ > MdePkg/Library/MipiSysTLib/mipisyst | 1 + > .../TraceHubDebugSysTLibNull.c | 76 ++ > .../TraceHubDebugSysTLibNull.inf | 29 + > MdePkg/MdePkg.ci.yaml | 12 +- > MdePkg/MdePkg.dec | 9 + > MdePkg/MdePkg.dsc | 2 + > ReadMe.rst | 1 + > 34 files changed, 3177 insertions(+), 3 deletions(-) > create mode 100644 > MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib. > c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib. > inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys > TLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys > TLib.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo > n.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommo > n.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.in > f > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md > create mode 100644 MdePkg/Include/Library/MipiSysTLib.h > create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h > create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h > create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md > create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h > create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf >=20 > -- > 2.39.2.windows.1 >=20 >=20 >=20 >=20 >=20