回复: [edk2-devel] [PATCH V3 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols

["gaoliming" <gaoliming@byosoft.com.cn>]

Abner:
  I have one comment. 

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner Chang
> 发送时间: 2021年3月24日 13:35
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>;
> Nickle Wang <nickle.wang@hpe.com>; Peter O'Hanley
> <peter.ohanley@hpe.com>
> 主题: [edk2-devel] [PATCH V3 2/2] ShellPkg/UefiHandleParsingLib: Support
> EFI Redfish protocols
> 
> Add handle parsing for EFI Redfish Discover protocol.
> Add handle parsing for EFI RestEx protocol.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++-
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c   | 8 ++++++--
>  .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++-
>  3 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git
a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> index 93b69cd8e9..446cd8d609 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> @@ -2,7 +2,7 @@
>  #  Provides interface to advanced shell functionality for parsing both
handle
> and protocol database.
>  #  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
<BR>
>  #  (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> L.P.<BR>
> -#  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +#  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> LP<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -269,6 +269,8 @@
>    gEfiHttpProtocolGuid                                    ##
> UNDEFINED
>    gEfiHttpUtilitiesProtocolGuid                           ##
> UNDEFINED
>    gEfiRestProtocolGuid                                    ##
> UNDEFINED
> +  gEfiRestExProtocolGuid                                  ##
> UNDEFINED
> +  gEfiRedfishDiscoverProtocolGuid                         ##
> UNDEFINED
>    gEfiMmEndOfDxeProtocolGuid                              ##
> UNDEFINED
>    gEfiMmIoTrapDispatchProtocolGuid                        ##
> UNDEFINED
>    gEfiMmPowerButtonDispatchProtocolGuid                   ##
> UNDEFINED
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 500a95a89a..c00337d6b2 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -3,7 +3,7 @@
> 
>    Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
>    (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> L.P.<BR>
> -  (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +  (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> LP<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[] = {
>    {STRING_TOKEN(STR_NET_HTTP),              &gEfiHttpProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_NET_HTTP_U),
> &gEfiHttpUtilitiesProtocolGuid,                   NULL},
>    {STRING_TOKEN(STR_REST),                  &gEfiRestProtocolGuid,
> NULL},
> -
> +//
> +// UEFI 2.8
> +//
> +  {STRING_TOKEN(STR_REST_EX),
> &gEfiRestExProtocolGuid,                          NULL},
> +  {STRING_TOKEN(STR_REDFISH_DISCOVER),
> &gEfiRedfishDiscoverProtocolGuid,                 NULL},

This change should be moved to the position after UEFI 2.7 in this table. 

Thanks
Liming
>  //
>  // PI 1.5
>  //
> diff --git
a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> index 9c8028d0d5..69fcbdfe0e 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni
> @@ -2,7 +2,7 @@
>  //
>  // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
<BR>
>  // (C) Copyright 2013-2015 Hewlett-Packard Development Company,
> L.P.<BR>
> -// (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR>
> +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development
> LP<BR>
>  // SPDX-License-Identifier: BSD-2-Clause-Patent
>  //
>  // Module Name:
> @@ -308,6 +308,8 @@
>  #string STR_NET_HTTP              #language en-US "Http"
>  #string STR_NET_HTTP_U            #language en-US "HttpUtilities"
>  #string STR_REST                  #language en-US "Rest"
> +#string STR_REST_EX               #language en-US "RestEx"
> +#string STR_REDFISH_DISCOVER      #language en-US "RedfishDiscover"
> 
>  #string STR_MM_EOD                #language en-US "MmEndOfDxe"
>  #string STR_MM_ITD                #language en-US
> "MmIoTrapDispatch"
> --
> 2.17.1
> 
> 
> 
> 
>