From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.2343.1616637870999479998 for ; Wed, 24 Mar 2021 19:04:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 25 Mar 2021 10:04:29 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Ray Ni'" , "'Zhichao Gao'" , "'Nickle Wang'" , "'Peter O'Hanley'" References: <20210324053440.23237-1-abner.chang@hpe.com> <20210324053440.23237-3-abner.chang@hpe.com> In-Reply-To: <20210324053440.23237-3-abner.chang@hpe.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYzIDIvMl0gU2hlbGxQa2cvVWVmaUhhbmRsZVBhcnNpbmdMaWI6IFN1cHBvcnQgRUZJIFJlZGZpc2ggcHJvdG9jb2xz?= Date: Thu, 25 Mar 2021 10:04:28 +0800 Message-ID: <00b201d7211b$30be2400$923a6c00$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIaK4MEyvFAQPG7h1MYt7t68ZkqTQE0qUVUqgQ5W2A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Abner: I have one comment.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Abner Chang > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C224=C8=D5 13:35 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Ray Ni ; Zhichao Gao ; > Nickle Wang ; Peter O'Hanley > > =D6=F7=CC=E2: [edk2-devel] [PATCH V3 2/2] ShellPkg/UefiHandleParsingLib:= Support > EFI Redfish protocols >=20 > Add handle parsing for EFI Redfish Discover protocol. > Add handle parsing for EFI RestEx protocol. >=20 > Signed-off-by: Abner Chang > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Nickle Wang > Cc: Peter O'Hanley > Reviewed-by: Zhichao Gao > --- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 ++++++-- > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- > 3 files changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > index 93b69cd8e9..446cd8d609 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > @@ -2,7 +2,7 @@ > # Provides interface to advanced shell functionality for parsing both handle > and protocol database. > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
> # (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.
> -# (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -269,6 +269,8 @@ > gEfiHttpProtocolGuid ## > UNDEFINED > gEfiHttpUtilitiesProtocolGuid ## > UNDEFINED > gEfiRestProtocolGuid ## > UNDEFINED > + gEfiRestExProtocolGuid ## > UNDEFINED > + gEfiRedfishDiscoverProtocolGuid ## > UNDEFINED > gEfiMmEndOfDxeProtocolGuid ## > UNDEFINED > gEfiMmIoTrapDispatchProtocolGuid ## > UNDEFINED > gEfiMmPowerButtonDispatchProtocolGuid ## > UNDEFINED > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.= c > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > index 500a95a89a..c00337d6b2 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > @@ -3,7 +3,7 @@ >=20 > Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.
> - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -2355,7 +2355,11 @@ STATIC CONST GUID_INFO_BLOCK > mGuidStringList[] =3D { > {STRING_TOKEN(STR_NET_HTTP), &gEfiHttpProtocolGuid, > NULL}, > {STRING_TOKEN(STR_NET_HTTP_U), > &gEfiHttpUtilitiesProtocolGuid, NULL}, > {STRING_TOKEN(STR_REST), &gEfiRestProtocolGuid, > NULL}, > - > +// > +// UEFI 2.8 > +// > + {STRING_TOKEN(STR_REST_EX), > &gEfiRestExProtocolGuid, NULL}, > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > &gEfiRedfishDiscoverProtocolGuid, NULL}, This change should be moved to the position after UEFI 2.7 in this table.= =20 Thanks Liming > // > // PI 1.5 > // > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > index 9c8028d0d5..69fcbdfe0e 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > @@ -2,7 +2,7 @@ > // > // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.
> // (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.
> -// (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent > // > // Module Name: > @@ -308,6 +308,8 @@ > #string STR_NET_HTTP #language en-US "Http" > #string STR_NET_HTTP_U #language en-US "HttpUtilities" > #string STR_REST #language en-US "Rest" > +#string STR_REST_EX #language en-US "RestEx" > +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" >=20 > #string STR_MM_EOD #language en-US "MmEndOfDxe" > #string STR_MM_ITD #language en-US > "MmIoTrapDispatch" > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20