From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.5458.1614316625991611064 for ; Thu, 25 Feb 2021 21:17:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 26 Feb 2021 13:17:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Li, Walon'" Cc: , , References: <20210219093931.1458-1-walon.li@hpe.com> <1666098D782F198A.19946@groups.io> In-Reply-To: <1666098D782F198A.19946@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyXSBNZGVNb2R1bGVQa2cvVWVmaUJvb3RNYW5hZ2VyTGliOiBQdXQgQm9vdE1lbnUgYXQgdGhlIGVuZCBvZiBCb290T3JkZXI=?= Date: Fri, 26 Feb 2021 13:17:03 +0800 Message-ID: <00b701d70bfe$9ef60140$dce203c0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHSB0iKlCA9c696PmmKdWtJE+YRtgLHz6kQAYsCcPWqUVgFgA== Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Merge @ 7f34681c488aee2563eaa2afcc6a2c8aa7c5b912 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+71937+4905953+8761045@groups.io > =B4=FA=B1=ED gaoliming > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C222=C8=D5 18:00 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; sunnywang@hpe.com; 'Li, Walon' > > =B3=AD=CB=CD: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com > =D6=F7=CC=E2: =BB=D8=B8=B4: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBoo= tManagerLib: > Put BootMenu at the end of BootOrder >=20 > Reviewed-by: Liming Gao >=20 > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > =B7=A2=BC=FE=C8=CB: bounce+27952+71931+4905953+8761045@groups.io > > =B4=FA=B1=ED Wang, > Sunny > > (HPS SW) > > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA2=D4=C222=C8=D5 17:30 > > =CA=D5=BC=FE=C8=CB: Li, Walon ; devel@edk2.groups.io > > =B3=AD=CB=CD: lersek@redhat.com; ray.ni@intel.com; hao.a.wu@intel.com; > > gaoliming@byosoft.com.cn; Wang, Sunny (HPS SW) > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManager= Lib: > Put > > BootMenu at the end of BootOrder > > > > Yeah, the problem is that always adding the Boot Menu to the top of > > BootOrder causes confusion to the users who manipulate the Boot Order > > under OS. Also, we can't find any reason why the Boot Menu needs to be > > always added to the top of the Boot Order even if we check the change > > history and emails. > > > > Reviewed-by: Sunny Wang > > > > > > -----Original Message----- > > From: Li, Walon > > Sent: Friday, February 19, 2021 5:40 PM > > To: devel@edk2.groups.io > > Cc: Li, Walon ; Wang, Sunny (HPS SW) > > ; lersek@redhat.com; ray.ni@intel.com; > > hao.a.wu@intel.com; gaoliming@byosoft.com.cn > > Subject: [PATCH v2] MdeModulePkg/UefiBootManagerLib: Put BootMenu at > > the end of BootOrder > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3135 > > > > When Boot Menu does not exist in the BootOrder, > > BmRegisterBootManagerMenu will create one into list. However, it shoul= d > be > > put at the "end" of BootOrder instead of "start" of BootOrder. Replace= 0 > by -1 > > to adjust order of load options. > > > > Signed-off-by: Walon Li > > --- > > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > index aff620ad52..6cc34d29c0 100644 > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > > @@ -3,7 +3,7 @@ > > Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. Copyrig= ht > (c) > > 2011 - 2020, Intel Corporation. All rights reserved.
-(C) Copyright > > 2015-2016 Hewlett Packard Enterprise Development LP
+(C) Copyright > > 2015-2021 Hewlett Packard Enterprise Development LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent **/@@ -2505,7 +2505,7 > @@ > > BmRegisterBootManagerMenu ( > > EfiBootManagerFreeLoadOptions (BootOptions, > > BootOptionCount); ); - return > EfiBootManagerAddLoadOptionVariable > > (BootOption, 0);+ return EfiBootManagerAddLoadOptionVariable > > (BootOption, (UINTN) -1); } /**-- > > 2.23.0.windows.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 >=20 >=20