[PATCH v1 0/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[PATCH v1 0/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[Kirkendall, Garrett]

When build.by POSTBUILD handling section returns other than 0, set
ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
than 0.

Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>

Garrett Kirkendall (1):
  BaseTools: build: Set ReturnCode on POSTBUILD fail

 BaseTools/Source/Python/build/build.py | 1 +
 1 file changed, 1 insertion(+)

--
2.30.1.windows.1

[PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[Kirkendall, Garrett]

When build.by POSTBUILD handling section returns other than 0, set
ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
than 0.

Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>

Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
---
 BaseTools/Source/Python/build/build.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 037493f0b02a..3e4d83409f49 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -2757,6 +2757,7 @@ def Main():
             Conclusion = "Done"
         except:
             Conclusion = "Failed"
+            ReturnCode = POSTBUILD_ERROR
     elif ReturnCode == ABORT_ERROR:
         Conclusion = "Aborted"
     else:
-- 
2.30.1.windows.1

回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[gaoliming]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Garrett Kirkendall <Garrett.Kirkendall@amd.com>
> 发送时间: 2021年5月14日 23:02
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>; Garrett
> Kirkendall <garrett.kirkendall@amd.com>
> 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
> 
> When build.by POSTBUILD handling section returns other than 0, set
> ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> than 0.
> 
> Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> 
> Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
> ---
>  BaseTools/Source/Python/build/build.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/BaseTools/Source/Python/build/build.py
> b/BaseTools/Source/Python/build/build.py
> index 037493f0b02a..3e4d83409f49 100755
> --- a/BaseTools/Source/Python/build/build.py
> +++ b/BaseTools/Source/Python/build/build.py
> @@ -2757,6 +2757,7 @@ def Main():
>              Conclusion = "Done"
> 
>          except:
> 
>              Conclusion = "Failed"
> 
> +            ReturnCode = POSTBUILD_ERROR
> 
>      elif ReturnCode == ABORT_ERROR:
> 
>          Conclusion = "Aborted"
> 
>      else:
> 
> --
> 2.30.1.windows.1

Re: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[Kirkendall, Garrett]

Any traction on this patch?  Thank you Liming Gao for your quick response.

GARRETT KIRKENDALL
SMTS Firmware Engineer
7171 Southwest Parkway, Austin, TX 78735 USA 
AMD   facebook  |  amd.com

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Sunday, May 16, 2021 3:10 AM
> To: Kirkendall, Garrett <Garrett.Kirkendall@amd.com>;
> devel@edk2.groups.io
> Cc: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>
> Subject: 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on
> POSTBUILD fail
> 
> [CAUTION: External Email]
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: Garrett Kirkendall <Garrett.Kirkendall@amd.com>
> > 发送时间: 2021年5月14日 23:02
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> Garrett
> > Kirkendall <garrett.kirkendall@amd.com>
> > 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
> >
> > When build.by POSTBUILD handling section returns other than 0, set
> > ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> > than 0.
> >
> > Fix for
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> >
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D1977&amp;data=04%7C01%7Cg
> arre
> >
> tt.kirkendall%40amd.com%7C82d1c5d0ec074f97850808d918420023%7C3dd89
> 61fe
> >
> 4884e608e11a82d994e183d%7C0%7C0%7C637567494029885033%7CUnknown
> %7CTWFpb
> >
> GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
> 6Mn0
> >
> %3D%7C1000&amp;sdata=tJsVIW3rhrBZiovl6Q%2FnvLUtiJCM%2BDksqSZHU
> QGaskw%3
> > D&amp;reserved=0
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> >
> > Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > ---
> >  BaseTools/Source/Python/build/build.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/build/build.py
> > b/BaseTools/Source/Python/build/build.py
> > index 037493f0b02a..3e4d83409f49 100755
> > --- a/BaseTools/Source/Python/build/build.py
> > +++ b/BaseTools/Source/Python/build/build.py
> > @@ -2757,6 +2757,7 @@ def Main():
> >              Conclusion = "Done"
> >
> >          except:
> >
> >              Conclusion = "Failed"
> >
> > +            ReturnCode = POSTBUILD_ERROR
> >
> >      elif ReturnCode == ABORT_ERROR:
> >
> >          Conclusion = "Aborted"
> >
> >      else:
> >
> > --
> > 2.30.1.windows.1
> 
> 

回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

[gaoliming]

This patch is reviewed before soft feature freeze. 

So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it for
this stable tag. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年5月16日 16:10
> 收件人: 'Garrett Kirkendall' <Garrett.Kirkendall@amd.com>;
> devel@edk2.groups.io
> 抄送: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode
on
> POSTBUILD fail
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: Garrett Kirkendall <Garrett.Kirkendall@amd.com>
> > 发送时间: 2021年5月14日 23:02
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> Garrett
> > Kirkendall <garrett.kirkendall@amd.com>
> > 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
> >
> > When build.by POSTBUILD handling section returns other than 0, set
> > ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> > than 0.
> >
> > Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> >
> > Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > ---
> >  BaseTools/Source/Python/build/build.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/build/build.py
> > b/BaseTools/Source/Python/build/build.py
> > index 037493f0b02a..3e4d83409f49 100755
> > --- a/BaseTools/Source/Python/build/build.py
> > +++ b/BaseTools/Source/Python/build/build.py
> > @@ -2757,6 +2757,7 @@ def Main():
> >              Conclusion = "Done"
> >
> >          except:
> >
> >              Conclusion = "Failed"
> >
> > +            ReturnCode = POSTBUILD_ERROR
> >
> >      elif ReturnCode == ABORT_ERROR:
> >
> >          Conclusion = "Aborted"
> >
> >      else:
> >
> > --
> > 2.30.1.windows.1
> 
> 
> 
> 
> 
> 
>