From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Yuwei Chen'" <yuwei.chen@intel.com>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>
Subject: 回复: [PATCH 1/1] BaseTools: Change RealPath to AbsPath
Date: Fri, 17 Sep 2021 09:10:03 +0800 [thread overview]
Message-ID: <00be01d7ab60$bf4e0350$3dea09f0$@byosoft.com.cn> (raw)
In-Reply-To: <20210916065911.716-1-yuwei.chen@intel.com>
Is there any other case to use RealPath in BaseTools? Or, have you confirm
that all RealPath usage have been removed?
Liming
> -----邮件原件-----
> 发件人: Yuwei Chen <yuwei.chen@intel.com>
> 发送时间: 2021年9月16日 14:59
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: [PATCH 1/1] BaseTools: Change RealPath to AbsPath
>
> Currently the realpath is used when parse modules, which shows the
> path with a drive letter in build log. In Windows 'subst' comand is
> used to associates a path with a drive letter, when use the mapped
> drive letter for build, with realpath function the build log will
> have different disk letter info which will cause confusion. In this
> situation, if use adspath function to show the path info, it will keep
> same letter with the mapped drive letter, which avoids confusion.
> This patch modifies the realpath to abspath.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/GenFds/FfsInfStatement.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> b/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> index 20573ca28d2f..568efb6d7685 100644
> --- a/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> +++ b/BaseTools/Source/Python/GenFds/FfsInfStatement.py
> @@ -707,8 +707,8 @@ class FfsInfStatement(FfsInfStatementClassObject):
> FileName,
> 'DEBUG'
> )
> - OutputPath = os.path.realpath(OutputPath)
> - DebugPath = os.path.realpath(DebugPath)
> + OutputPath = os.path.abspath(OutputPath)
> + DebugPath = os.path.abspath(DebugPath)
> return OutputPath, DebugPath
>
> ## __GenSimpleFileSection__() method
> --
> 2.26.1.windows.1
prev parent reply other threads:[~2021-09-17 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 6:59 [PATCH 1/1] BaseTools: Change RealPath to AbsPath Yuwei Chen
2021-09-17 1:10 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00be01d7ab60$bf4e0350$3dea09f0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox