public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'zhoucheng'" <zhoucheng@phytium.com.cn>, <devel@edk2.groups.io>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>
Subject: 回复: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data
Date: Fri, 23 Apr 2021 08:53:20 +0800	[thread overview]
Message-ID: <00bf01d737db$0e22b4c0$2a681e40$@byosoft.com.cn> (raw)
In-Reply-To: <1619057465-13347-2-git-send-email-zhoucheng@phytium.com.cn>

Cheng Zhou:
  Please update the commit message to highlight this change based on NVME1.3
spec. 

  With this update, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: zhoucheng <zhoucheng@phytium.com.cn>
> 发送时间: 2021年4月22日 10:11
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme
> amdin controller data
> 
> Add definition that describes the structure of Nvme admin controller data.
> 
> Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Nvme.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Nvme.h
> b/MdePkg/Include/IndustryStandard/Nvme.h
> index 9b19a2074b0d..61bf0fadc05c 100644
> --- a/MdePkg/Include/IndustryStandard/Nvme.h
> +++ b/MdePkg/Include/IndustryStandard/Nvme.h
> @@ -353,7 +353,13 @@ typedef struct {
>    UINT8  Npss;                /* Number of Power States Support */
>    UINT8  Avscc;               /* Admin Vendor Specific Command
> Configuration */
>    UINT8  Apsta;               /* Autonomous Power State Transition
> Attributes */
> -  UINT8  Rsvd2[246];          /* Reserved as of Nvm Express 1.1 Spec
> */
> +  UINT16 Wctemp;              /* Warning Composite Temperature
> Threshold */
> +  UINT16 Cctemp;              /* Critical Composite Temperature
> Threshold */
> +  UINT16 Mtfa;                /* Maximum Time for Firmware
> Activation */
> +  UINT8  Hmpre[4];            /* Host Memory Buffer Preferred Size
> */
> +  UINT8  Hmmin[4];            /* Host Memory Buffer Minimum Size
> */
> +  UINT8  Tnvmcap[16];         /* Total NVM Capacity */
> +  UINT8  Rsvd2[216];          /* Reserved as of Nvm Express 1.3 Spec
> */
>    //
>    // NVM Command Set Attributes
>    //
> --
> 1.9.1




       reply	other threads:[~2021-04-23  0:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1619057465-13347-1-git-send-email-zhoucheng@phytium.com.cn>
     [not found] ` <1619057465-13347-2-git-send-email-zhoucheng@phytium.com.cn>
2021-04-23  0:53   ` gaoliming [this message]
2021-04-23  3:17     ` [edk2-devel] 回复: [PATCH v1 1/2] MdePkg:Update IndustryStandard/Nvme.h with Nvme amdin controller data Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00bf01d737db$0e22b4c0$2a681e40$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox