public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses
Date: Thu, 2 Jan 2020 16:36:36 +0100	[thread overview]
Message-ID: <00c0936c-8697-05c9-4dbc-96761b1b448d@redhat.com> (raw)
In-Reply-To: <20200102152448.11739-1-philmd@redhat.com>

On 1/2/20 4:24 PM, Philippe Mathieu-Daude wrote:
> Last month I cleaned the git-history incorrect email
> addresses: https://edk2.groups.io/g/devel/message/51834
> but today I noticed more incorrect addresses got committed
> (see caa917491a4..33a3293651).
> To avoid having the same cleanup in the future, fix the
> problem once for all by having PatchCheck doing this
> automatically (on merge).
> 
> Since we already have code to check email address in
> PatchCheck, factor the code out to reuse it, and
> add checks for committer/author addresses.
> 
> Philippe Mathieu-Daude (4):
>    BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck
>    BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked
>    BaseTools/PatchCheck.py: Check the patch author email address
>    BaseTools/PatchCheck.py: Check the committer email address
> 
>   BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++----------
>   1 file changed, 69 insertions(+), 30 deletions(-)

Please disregard this cover, I forgot to use the Cc tags:

Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>

I hit ^C too late :S


  reply	other threads:[~2020-01-02 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 15:24 [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses Philippe Mathieu-Daudé
2020-01-02 15:36 ` Philippe Mathieu-Daudé [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-02 15:25 Philippe Mathieu-Daudé
2020-01-03 13:11 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00c0936c-8697-05c9-4dbc-96761b1b448d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox