From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.13053.1577979400589997015 for ; Thu, 02 Jan 2020 07:36:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CXd/xKzS; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577979399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2Q2nk1TN5ALR/l6/eN/sphwZKK7UGx+lTtG5rrdq+Y=; b=CXd/xKzS15Ahp/9Yb5xq/mpMcmKzy0OpuvSYuJu3i9bqLtHaKtplrrcYYH+vaMa/NGplK/ NGXjr6ePsO+zVozGCEpw0OoC0XEfP1BVXisaWEWNCmUhsbs1ZAwIJK1pUc00W5r+9nhbrf RZnMzV023uXEu0udvSTRFfIrt4yAYEM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-0T8eyI05OUW12YrcRe_-Fw-1; Thu, 02 Jan 2020 10:36:38 -0500 Received: by mail-wm1-f70.google.com with SMTP id h130so859470wme.7 for ; Thu, 02 Jan 2020 07:36:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E2Q2nk1TN5ALR/l6/eN/sphwZKK7UGx+lTtG5rrdq+Y=; b=FwBXbAfzzCHSXca41pDLIEzunH6kx1joE/SkhMVm4CXRQkRgcjlYktp4OVn05i2cuQ ZB02/KGUK5Qi5DVzLQvRQzv6CKv1euIQciSsPtXuagSdXt4nCM1YeSCDuluBcA+U/BUc o1y9l/FMWS1FJaQSimJgFiHtdTVk5yj/vsxkfXbkYHehD5i9TZpo5a6VLkjb/F4U8aJG a33ezPt3Kqigr7Miy8HQK5dzFO7dsqP8L00kQN7y3BIyAZCgnI4uZyZc+Tz+MGzXzcJP Ndsy92VojajthNMgKsDc5qAoBSltdYXqrsr6H2phM9MH/lpIfj6S+Tcd7dTMF4GuYy6G Qa6Q== X-Gm-Message-State: APjAAAW0kkooi+Kx2FbHbOeK/6XrBvyRU7BcT/2hswPyhSOuUg4+sEC2 7y/COh+DncEzzOSgMSH7KlU9nA6yyTkhtH8AVT8StHtZoWDEqTLzG+Fo03qmKQRY6Upz7qavTte N0RhoA4nuVIaWYQ== X-Received: by 2002:a7b:c3d2:: with SMTP id t18mr15332641wmj.90.1577979397533; Thu, 02 Jan 2020 07:36:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwwDUmReEp29NDOUr4g4CmUcNI/Bo5nkeS3qGDl41y6Sn7ObgMvPwxM7FMlupmyVHv+vcPr2A== X-Received: by 2002:a7b:c3d2:: with SMTP id t18mr15332630wmj.90.1577979397346; Thu, 02 Jan 2020 07:36:37 -0800 (PST) Return-Path: Received: from [192.168.50.32] (243.red-88-26-246.staticip.rima-tde.net. [88.26.246.243]) by smtp.gmail.com with ESMTPSA id u1sm8781061wmc.5.2020.01.02.07.36.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2020 07:36:36 -0800 (PST) Subject: Re: [PATCH 0/4] BaseTools/PatchCheck: Check committer/author email addresses To: devel@edk2.groups.io Cc: Laszlo Ersek , Michael D Kinney References: <20200102152448.11739-1-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <00c0936c-8697-05c9-4dbc-96761b1b448d@redhat.com> Date: Thu, 2 Jan 2020 16:36:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200102152448.11739-1-philmd@redhat.com> X-MC-Unique: 0T8eyI05OUW12YrcRe_-Fw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/2/20 4:24 PM, Philippe Mathieu-Daude wrote: > Last month I cleaned the git-history incorrect email > addresses: https://edk2.groups.io/g/devel/message/51834 > but today I noticed more incorrect addresses got committed > (see caa917491a4..33a3293651). > To avoid having the same cleanup in the future, fix the > problem once for all by having PatchCheck doing this > automatically (on merge). > > Since we already have code to check email address in > PatchCheck, factor the code out to reuse it, and > add checks for committer/author addresses. > > Philippe Mathieu-Daude (4): > BaseTools/PatchCheck.py: Extract email check code to EmailAddressCheck > BaseTools/PatchCheck.py: Let EmailAddressCheck describe email checked > BaseTools/PatchCheck.py: Check the patch author email address > BaseTools/PatchCheck.py: Check the committer email address > > BaseTools/Scripts/PatchCheck.py | 99 +++++++++++++++++++++++---------- > 1 file changed, 69 insertions(+), 30 deletions(-) Please disregard this cover, I forgot to use the Cc tags: Cc: Liming Gao Cc: Jordan Justen I hit ^C too late :S