From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ke, Bo-ChangX'" <bo-changx.ke@intel.com>, <devel@edk2.groups.io>
Cc: "'Kinney, Michael D'" <michael.d.kinney@intel.com>,
"'Liu, Zhiguang'" <zhiguang.liu@intel.com>,
"'Gao, Zhichao'" <zhichao.gao@intel.com>,
"'Bi, Dandan'" <dandan.bi@intel.com>,
"'Zeng, Star'" <star.zeng@intel.com>
Subject: 回复: [edk2-devel] [PATCH v3] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields
Date: Fri, 22 Apr 2022 09:26:02 +0800 [thread overview]
Message-ID: <00c101d855e7$ede34310$c9a9c930$@byosoft.com.cn> (raw)
In-Reply-To: <BN6PR11MB1570B944FABA83618A51DD31D4F49@BN6PR11MB1570.namprd11.prod.outlook.com>
Change:
https://github.com/tianocore/edk2/pull/2797 is used to merge these two
patches.
Thanks
Liming
> -----邮件原件-----
> 发件人: Ke, Bo-ChangX <bo-changx.ke@intel.com>
> 发送时间: 2022年4月21日 19:06
> 收件人: devel@edk2.groups.io; Ke, Bo-ChangX <bo-changx.ke@intel.com>
> 抄送: Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng,
> Star <star.zeng@intel.com>
> 主题: RE: [edk2-devel] [PATCH v3] MdePkg: Update smbiosview type 9 with
> SMBIOS 3.5 fields
>
> Hi Liming, Mike,
>
> Fix coding style issue,
>
> And create a PR here: https://github.com/tianocore/edk2/pull/2811
>
> The CI checks have passed.
>
> Can you help push this PR?
>
> Thank you very much.
>
> Best Regards.
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bo Chang
> Ke
> Sent: Thursday, April 21, 2022 6:55 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Zeng,
> Star <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH v3] MdePkg: Update smbiosview type 9 with
> SMBIOS 3.5 fields
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
>
> update smbiosview type 9 related fileds.
>
> Signed-off-by: Bo Chang Ke <bo-changx.ke@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 177 ++++++++++++++---------
> 1 file changed, 112 insertions(+), 65 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 2b1567b052..20d62680a5 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1271,71 +1271,85 @@ typedef struct { /// System Slots - Slot Type
> /// typedef enum {
> - SlotTypeOther = 0x01,
> - SlotTypeUnknown = 0x02,
> - SlotTypeIsa = 0x03,
> - SlotTypeMca = 0x04,
> - SlotTypeEisa = 0x05,
> - SlotTypePci = 0x06,
> - SlotTypePcmcia = 0x07,
> - SlotTypeVlVesa = 0x08,
> - SlotTypeProprietary = 0x09,
> - SlotTypeProcessorCardSlot = 0x0A,
> - SlotTypeProprietaryMemoryCardSlot = 0x0B,
> - SlotTypeIORiserCardSlot = 0x0C,
> - SlotTypeNuBus = 0x0D,
> - SlotTypePci66MhzCapable = 0x0E,
> - SlotTypeAgp = 0x0F,
> - SlotTypeApg2X = 0x10,
> - SlotTypeAgp4X = 0x11,
> - SlotTypePciX = 0x12,
> - SlotTypeAgp8X = 0x13,
> - SlotTypeM2Socket1_DP = 0x14,
> - SlotTypeM2Socket1_SD = 0x15,
> - SlotTypeM2Socket2 = 0x16,
> - SlotTypeM2Socket3 = 0x17,
> - SlotTypeMxmTypeI = 0x18,
> - SlotTypeMxmTypeII = 0x19,
> - SlotTypeMxmTypeIIIStandard = 0x1A,
> - SlotTypeMxmTypeIIIHe = 0x1B,
> - SlotTypeMxmTypeIV = 0x1C,
> - SlotTypeMxm30TypeA = 0x1D,
> - SlotTypeMxm30TypeB = 0x1E,
> - SlotTypePciExpressGen2Sff_8639 = 0x1F,
> - SlotTypePciExpressGen3Sff_8639 = 0x20,
> - SlotTypePciExpressMini52pinWithBSKO = 0x21, ///< PCI Express
> Mini 52-pin (CEM spec. 2.0) with bottom-side keep-outs.
> - SlotTypePciExpressMini52pinWithoutBSKO = 0x22, ///< PCI Express
> Mini 52-pin (CEM spec. 2.0) without bottom-side keep-outs.
> - SlotTypePciExpressMini76pin = 0x23, ///< PCI Express
> Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card.
> - SlotTypeCXLFlexbus10 = 0x30,
> - SlotTypePC98C20 = 0xA0,
> - SlotTypePC98C24 = 0xA1,
> - SlotTypePC98E = 0xA2,
> - SlotTypePC98LocalBus = 0xA3,
> - SlotTypePC98Card = 0xA4,
> - SlotTypePciExpress = 0xA5,
> - SlotTypePciExpressX1 = 0xA6,
> - SlotTypePciExpressX2 = 0xA7,
> - SlotTypePciExpressX4 = 0xA8,
> - SlotTypePciExpressX8 = 0xA9,
> - SlotTypePciExpressX16 = 0xAA,
> - SlotTypePciExpressGen2 = 0xAB,
> - SlotTypePciExpressGen2X1 = 0xAC,
> - SlotTypePciExpressGen2X2 = 0xAD,
> - SlotTypePciExpressGen2X4 = 0xAE,
> - SlotTypePciExpressGen2X8 = 0xAF,
> - SlotTypePciExpressGen2X16 = 0xB0,
> - SlotTypePciExpressGen3 = 0xB1,
> - SlotTypePciExpressGen3X1 = 0xB2,
> - SlotTypePciExpressGen3X2 = 0xB3,
> - SlotTypePciExpressGen3X4 = 0xB4,
> - SlotTypePciExpressGen3X8 = 0xB5,
> - SlotTypePciExpressGen3X16 = 0xB6,
> - SlotTypePciExpressGen4 = 0xB8,
> - SlotTypePciExpressGen4X1 = 0xB9,
> - SlotTypePciExpressGen4X2 = 0xBA,
> - SlotTypePciExpressGen4X4 = 0xBB,
> - SlotTypePciExpressGen4X8 = 0xBC,
> - SlotTypePciExpressGen4X16 = 0xBD
> + SlotTypeOther = 0x01,
> + SlotTypeUnknown = 0x02,
> + SlotTypeIsa = 0x03,
> + SlotTypeMca = 0x04,
> + SlotTypeEisa = 0x05,
> + SlotTypePci = 0x06,
> + SlotTypePcmcia = 0x07,
> + SlotTypeVlVesa = 0x08,
> + SlotTypeProprietary = 0x09,
> + SlotTypeProcessorCardSlot = 0x0A,
> + SlotTypeProprietaryMemoryCardSlot = 0x0B,
> + SlotTypeIORiserCardSlot = 0x0C,
> + SlotTypeNuBus = 0x0D,
> + SlotTypePci66MhzCapable = 0x0E,
> + SlotTypeAgp = 0x0F,
> + SlotTypeApg2X = 0x10,
> + SlotTypeAgp4X = 0x11,
> + SlotTypePciX = 0x12,
> + SlotTypeAgp8X = 0x13,
> + SlotTypeM2Socket1_DP = 0x14,
> + SlotTypeM2Socket1_SD = 0x15,
> + SlotTypeM2Socket2 = 0x16,
> + SlotTypeM2Socket3 = 0x17,
> + SlotTypeMxmTypeI = 0x18,
> + SlotTypeMxmTypeII = 0x19,
> + SlotTypeMxmTypeIIIStandard = 0x1A,
> + SlotTypeMxmTypeIIIHe = 0x1B,
> + SlotTypeMxmTypeIV = 0x1C,
> + SlotTypeMxm30TypeA = 0x1D,
> + SlotTypeMxm30TypeB = 0x1E,
> + SlotTypePciExpressGen2Sff_8639 = 0x1F,
> + SlotTypePciExpressGen3Sff_8639 = 0x20,
> + SlotTypePciExpressMini52pinWithBSKO = 0x21,
> ///< PCI Express Mini 52-pin (CEM spec. 2.0) with bottom-side keep-outs.
> + SlotTypePciExpressMini52pinWithoutBSKO = 0x22, ///<
> PCI Express Mini 52-pin (CEM spec. 2.0) without bottom-side keep-outs.
> + SlotTypePciExpressMini76pin = 0x23, ///<
> PCI Express Mini 76-pin (CEM spec. 2.0) Corresponds to Display-Mini card.
> + SlotTypePCIExpressGen4SFF_8639 = 0x24,
> ///< U.2
> + SlotTypePCIExpressGen5SFF_8639 = 0x25,
> ///< U.2
> + SlotTypeOCPNIC30SmallFormFactor = 0x26,
> ///< SFF
> + SlotTypeOCPNIC30LargeFormFactor = 0x27,
> ///< LFF
> + SlotTypeOCPNICPriorto30 = 0x28,
> + SlotTypeCXLFlexbus10 = 0x30,
> + SlotTypePC98C20 = 0xA0,
> + SlotTypePC98C24 = 0xA1,
> + SlotTypePC98E = 0xA2,
> + SlotTypePC98LocalBus = 0xA3,
> + SlotTypePC98Card = 0xA4,
> + SlotTypePciExpress = 0xA5,
> + SlotTypePciExpressX1 = 0xA6,
> + SlotTypePciExpressX2 = 0xA7,
> + SlotTypePciExpressX4 = 0xA8,
> + SlotTypePciExpressX8 = 0xA9,
> + SlotTypePciExpressX16 = 0xAA,
> + SlotTypePciExpressGen2 = 0xAB,
> + SlotTypePciExpressGen2X1 = 0xAC,
> + SlotTypePciExpressGen2X2 = 0xAD,
> + SlotTypePciExpressGen2X4 = 0xAE,
> + SlotTypePciExpressGen2X8 = 0xAF,
> + SlotTypePciExpressGen2X16 = 0xB0,
> + SlotTypePciExpressGen3 = 0xB1,
> + SlotTypePciExpressGen3X1 = 0xB2,
> + SlotTypePciExpressGen3X2 = 0xB3,
> + SlotTypePciExpressGen3X4 = 0xB4,
> + SlotTypePciExpressGen3X8 = 0xB5,
> + SlotTypePciExpressGen3X16 = 0xB6,
> + SlotTypePciExpressGen4 = 0xB8,
> + SlotTypePciExpressGen4X1 = 0xB9,
> + SlotTypePciExpressGen4X2 = 0xBA,
> + SlotTypePciExpressGen4X4 = 0xBB,
> + SlotTypePciExpressGen4X8 = 0xBC,
> + SlotTypePciExpressGen4X16 = 0xBD,
> + SlotTypePCIExpressGen5 = 0xBE,
> + SlotTypePCIExpressGen5X1 = 0xBF,
> + SlotTypePCIExpressGen5X2 = 0xC0,
> + SlotTypePCIExpressGen5X4 = 0xC1,
> + SlotTypePCIExpressGen5X8 = 0xC2,
> + SlotTypePCIExpressGen5X16 = 0xC3,
> + SlotTypePCIExpressGen6andBeyond = 0xC4,
> + SlotTypeEnterpriseandDatacenter1UE1FormFactorSlot = 0xC5,
> + SlotTypeEnterpriseandDatacenter3E3FormFactorSlot = 0xC6
> } MISC_SLOT_TYPE;
>
> ///
> @@ -1358,6 +1372,39 @@ typedef enum {
> SlotDataBusWidth32X = 0x0E ///< Or X32
> } MISC_SLOT_DATA_BUS_WIDTH;
>
> +///
> +/// System Slots - Slot Physical Width.
> +///
> +typedef enum {
> + SlotPhysicalWidthOther = 0x01,
> + SlotPhysicalWidthUnknown = 0x02,
> + SlotPhysicalWidth8Bit = 0x03,
> + SlotPhysicalWidth16Bit = 0x04,
> + SlotPhysicalWidth32Bit = 0x05,
> + SlotPhysicalWidth64Bit = 0x06,
> + SlotPhysicalWidth128Bit = 0x07,
> + SlotPhysicalWidth1X = 0x08, ///< Or X1
> + SlotPhysicalWidth2X = 0x09, ///< Or X2
> + SlotPhysicalWidth4X = 0x0A, ///< Or X4
> + SlotPhysicalWidth8X = 0x0B, ///< Or X8
> + SlotPhysicalWidth12X = 0x0C, ///< Or X12
> + SlotPhysicalWidth16X = 0x0D, ///< Or X16
> + SlotPhysicalWidth32X = 0x0E ///< Or X32
> +} MISC_SLOT_PHYSICAL_WIDTH;
> +
> +///
> +/// System Slots - Slot Information.
> +///
> +typedef enum {
> + Others = 0x00,
> + Gen1 = 0x01,
> + Gen2 = 0x01,
> + Gen3 = 0x03,
> + Gen4 = 0x04,
> + Gen5 = 0x05,
> + Gen6 = 0x06
> +} MISC_SLOT_INFORMATION;
> +
> ///
> /// System Slots - Current Usage.
> ///
> --
> 2.32.0.windows.1
>
>
>
>
>
prev parent reply other threads:[~2022-04-22 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <acf7b6c337eb81d451f8545381a13c052beb0cd1.1650515579.git.bo-changx.ke@intel.com>
2022-04-21 10:54 ` [PATCH v3] MdePkg: Update smbiosview type 9 with SMBIOS 3.5 fields Bo Chang Ke
2022-04-21 10:54 ` [PATCH v3] ShellPkg: " Bo Chang Ke
[not found] ` <16E7E40A8A36DFC1.23693@groups.io>
2022-04-21 11:05 ` [edk2-devel] [PATCH v3] MdePkg: " Bo Chang Ke
2022-04-22 1:26 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c101d855e7$ede34310$c9a9c930$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox