public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <joey.gouly@arm.com>
Cc: <ardb+tianocore@kernel.org>, <sami.mujawar@arm.com>,
	<jbrasen@nvidia.com>, <ipark@nvidia.com>,
	<Samer.El-Haj-Mahmoud@arm.com>, <nd@arm.com>
Subject: 回复: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid
Date: Thu, 21 Jan 2021 09:40:36 +0800	[thread overview]
Message-ID: <00c401d6ef96$6a742de0$3f5c89a0$@byosoft.com.cn> (raw)
In-Reply-To: <20210120182005.2580-2-joey.gouly@arm.com>

This change is correct. 

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70589+4905953+8761045@groups.io
> <bounce+27952+70589+4905953+8761045@groups.io> 代表 Joey Gouly
> 发送时间: 2021年1月21日 2:20
> 收件人: devel@edk2.groups.io
> 抄送: joey.gouly@arm.com; ardb+tianocore@kernel.org;
> sami.mujawar@arm.com; jbrasen@nvidia.com; ipark@nvidia.com;
> Samer.El-Haj-Mahmoud@arm.com; nd@arm.com
> 主题: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use
> gEfiMdeModulePkgTokenSpaceGuid
> 
> Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead.
> 
> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> ---
>  DynamicTablesPkg/DynamicTablesPkg.dec
> | 10 ++++++----
> 
> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx
> e.inf |  8 ++++----
>  2 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dec
> b/DynamicTablesPkg/DynamicTablesPkg.dec
> index
> f36a6e8bb7c17f82acff3c766b15202b064a64b5..291a45a69679ae82219ecd2
> f26dfabfbab1f7f65 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dec
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dec
> @@ -1,7 +1,7 @@
>  ## @file
>  # dec file for Dynamic Tables Framework.
>  #
> -# Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -36,11 +36,13 @@ [Protocols]
>  [PcdsFixedAtBuild]
> 
>    # Maximum number of Custom ACPI Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|UINT1
> 6|0xC0000001
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators|1|U
> INT16|0xC0000001
> 
>    # Maximum number of Custom SMBIOS Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|1|UI
> NT16|0xC0000002
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators|
> 1|UINT16|0xC0000002
> 
>    # Maximum number of Custom DT Generators
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UINT16|
> 0xC0000003
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators|1|UI
> NT16|0xC0000003
> 
> +[Guids]
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid = { 0xab226e66, 0x31d8, 0x4613,
> { 0x87, 0x9d, 0xd2, 0xfa, 0xb6, 0x10, 0x26, 0x3c } }
> diff --git
> a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> index
> 56b69591ac52ca3ba51250dc01a0846b22442ce9..29ed3dc2e5029206f8852c
> 4b11240e7b493bbc57 100644
> ---
> a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> +++
> b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory
> Dxe.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Module to manage the list of available table factories.
>  #
> -#  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.
> +#  Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
> @@ -41,9 +41,9 @@ [LibraryClasses]
>    UefiDriverEntryPoint
> 
>  [FixedPcd]
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxCustomDTGenerators
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomACPIGenerators
> +
> gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomSMBIOSGenerators
> +  gEdkiiDynamicTablesPkgTokenSpaceGuid.PcdMaxCustomDTGenerators
> 
>  [Protocols]
>    gEdkiiDynamicTableFactoryProtocolGuid         # PRODUCES
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
> 
> 
> 
> 




  reply	other threads:[~2021-01-21  1:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 18:20 [PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT Joey Gouly
2021-01-20 18:20 ` [PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid Joey Gouly
2021-01-21  1:40   ` gaoliming [this message]
2021-01-20 18:20 ` [PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT Joey Gouly
2021-01-20 18:27   ` Samer El-Haj-Mahmoud
2021-02-01 14:27 ` [PATCH v1 0/2] Add a Pcd to override the 16650 " Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00c401d6ef96$6a742de0$3f5c89a0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox